Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-12 Thread Brian Masney
On Mon, Nov 11, 2019 at 07:51:22AM -0700, Jeffrey Hugo wrote: > On Mon, Nov 11, 2019 at 4:38 AM Brian Masney wrote: > > > > On Sun, Nov 10, 2019 at 10:37:33AM -0700, Jeffrey Hugo wrote: > > > On Sun, Nov 10, 2019 at 6:53 AM Brian Masney > > > wrote: > > > > > > > > On Fri, Nov 08, 2019 at 07:56:

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-12 Thread Jeffrey Hugo
On Mon, Nov 11, 2019 at 4:38 AM Brian Masney wrote: > > On Sun, Nov 10, 2019 at 10:37:33AM -0700, Jeffrey Hugo wrote: > > On Sun, Nov 10, 2019 at 6:53 AM Brian Masney wrote: > > > > > > On Fri, Nov 08, 2019 at 07:56:25AM -0700, Jeffrey Hugo wrote: > > > There's a REG_MDP5_PP_AUTOREFRESH_CONFIG()

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-12 Thread Brian Masney
On Sun, Nov 10, 2019 at 10:37:33AM -0700, Jeffrey Hugo wrote: > On Sun, Nov 10, 2019 at 6:53 AM Brian Masney wrote: > > > > On Fri, Nov 08, 2019 at 07:56:25AM -0700, Jeffrey Hugo wrote: > > There's a REG_MDP5_PP_AUTOREFRESH_CONFIG() macro upstream here: > > https://git.kernel.org/pub/scm/linux/ker

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-10 Thread Jeffrey Hugo
On Sun, Nov 10, 2019 at 6:53 AM Brian Masney wrote: > > On Fri, Nov 08, 2019 at 07:56:25AM -0700, Jeffrey Hugo wrote: > > On Thu, Nov 7, 2019 at 7:03 PM Rob Clark wrote: > > > > > > On Thu, Nov 7, 2019 at 9:40 AM Jeffrey Hugo > > > wrote: > > > > > > > > On Thu, Nov 7, 2019 at 9:17 AM Rob Clark

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-10 Thread Jeffrey Hugo
On Thu, Nov 7, 2019 at 7:03 PM Rob Clark wrote: > > On Thu, Nov 7, 2019 at 9:40 AM Jeffrey Hugo wrote: > > > > On Thu, Nov 7, 2019 at 9:17 AM Rob Clark wrote: > > > > > > On Thu, Nov 7, 2019 at 3:10 AM Brian Masney wrote: > > > > > > > > On Wed, Nov 06, 2019 at 08:58:59AM -0800, Rob Clark wrote

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-10 Thread Brian Masney
On Fri, Nov 08, 2019 at 07:56:25AM -0700, Jeffrey Hugo wrote: > On Thu, Nov 7, 2019 at 7:03 PM Rob Clark wrote: > > > > On Thu, Nov 7, 2019 at 9:40 AM Jeffrey Hugo > > wrote: > > > > > > On Thu, Nov 7, 2019 at 9:17 AM Rob Clark wrote: > > > > > > > > On Thu, Nov 7, 2019 at 3:10 AM Brian Masney

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-08 Thread Jeffrey Hugo
On Thu, Nov 7, 2019 at 9:17 AM Rob Clark wrote: > > On Thu, Nov 7, 2019 at 3:10 AM Brian Masney wrote: > > > > On Wed, Nov 06, 2019 at 08:58:59AM -0800, Rob Clark wrote: > > > On Wed, Nov 6, 2019 at 8:47 AM Jeffrey Hugo > > > wrote: > > > > > > > > On Wed, Nov 6, 2019 at 9:30 AM Rob Clark wrot

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-08 Thread Rob Clark
On Thu, Nov 7, 2019 at 9:40 AM Jeffrey Hugo wrote: > > On Thu, Nov 7, 2019 at 9:17 AM Rob Clark wrote: > > > > On Thu, Nov 7, 2019 at 3:10 AM Brian Masney wrote: > > > > > > On Wed, Nov 06, 2019 at 08:58:59AM -0800, Rob Clark wrote: > > > > On Wed, Nov 6, 2019 at 8:47 AM Jeffrey Hugo > > > > w

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-08 Thread Brian Masney
On Wed, Nov 06, 2019 at 08:58:59AM -0800, Rob Clark wrote: > On Wed, Nov 6, 2019 at 8:47 AM Jeffrey Hugo wrote: > > > > On Wed, Nov 6, 2019 at 9:30 AM Rob Clark wrote: > > > > > > On Wed, Nov 6, 2019 at 1:13 AM Brian Masney wrote: > > > > > > > > On Tue, Nov 05, 2019 at 08:23:27AM -0800, Rob Cla

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-07 Thread Rob Clark
On Thu, Nov 7, 2019 at 3:10 AM Brian Masney wrote: > > On Wed, Nov 06, 2019 at 08:58:59AM -0800, Rob Clark wrote: > > On Wed, Nov 6, 2019 at 8:47 AM Jeffrey Hugo > > wrote: > > > > > > On Wed, Nov 6, 2019 at 9:30 AM Rob Clark wrote: > > > > > > > > On Wed, Nov 6, 2019 at 1:13 AM Brian Masney

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-06 Thread Jeffrey Hugo
On Wed, Nov 6, 2019 at 9:30 AM Rob Clark wrote: > > On Wed, Nov 6, 2019 at 1:13 AM Brian Masney wrote: > > > > On Tue, Nov 05, 2019 at 08:23:27AM -0800, Rob Clark wrote: > > > On Tue, Nov 5, 2019 at 2:08 AM Brian Masney wrote: > > > > The 'pp done time out' errors go away if I revert the followi

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-06 Thread Brian Masney
On Tue, Nov 05, 2019 at 08:23:27AM -0800, Rob Clark wrote: > On Tue, Nov 5, 2019 at 2:08 AM Brian Masney wrote: > > The 'pp done time out' errors go away if I revert the following three > > commits: > > > > cd6d923167b1 ("drm/msm/dpu: async commit support") > > d934a712c5e6 ("drm/msm: add atomic t

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-06 Thread Rob Clark
On Wed, Nov 6, 2019 at 8:47 AM Jeffrey Hugo wrote: > > On Wed, Nov 6, 2019 at 9:30 AM Rob Clark wrote: > > > > On Wed, Nov 6, 2019 at 1:13 AM Brian Masney wrote: > > > > > > On Tue, Nov 05, 2019 at 08:23:27AM -0800, Rob Clark wrote: > > > > On Tue, Nov 5, 2019 at 2:08 AM Brian Masney > > > > w

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-06 Thread Rob Clark
On Wed, Nov 6, 2019 at 1:13 AM Brian Masney wrote: > > On Tue, Nov 05, 2019 at 08:23:27AM -0800, Rob Clark wrote: > > On Tue, Nov 5, 2019 at 2:08 AM Brian Masney wrote: > > > The 'pp done time out' errors go away if I revert the following three > > > commits: > > > > > > cd6d923167b1 ("drm/msm/dp

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-05 Thread Rob Clark
On Tue, Nov 5, 2019 at 2:08 AM Brian Masney wrote: > > On Mon, Nov 04, 2019 at 04:19:07PM -0800, Rob Clark wrote: > > On Mon, Nov 4, 2019 at 4:01 PM Brian Masney wrote: > > > > > > Hey Rob, > > > > > > Since commit 2d99ced787e3 ("drm/msm: async commit support"), the frame > > > buffer console on

drm/msm: 'pp done time out' errors after async commit changes

2019-11-05 Thread Brian Masney
Hey Rob, Since commit 2d99ced787e3 ("drm/msm: async commit support"), the frame buffer console on my Nexus 5 began throwing these errors: msm fd90.mdss: pp done time out, lm=0 The display still works. I see that mdp5_flush_commit() was introduced in commit 9f6b65642bd2 ("drm/msm: add kms->f

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-05 Thread Brian Masney
On Mon, Nov 04, 2019 at 04:19:07PM -0800, Rob Clark wrote: > On Mon, Nov 4, 2019 at 4:01 PM Brian Masney wrote: > > > > Hey Rob, > > > > Since commit 2d99ced787e3 ("drm/msm: async commit support"), the frame > > buffer console on my Nexus 5 began throwing these errors: > > > > msm fd90.mdss: p

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-04 Thread Rob Clark
On Mon, Nov 4, 2019 at 4:01 PM Brian Masney wrote: > > Hey Rob, > > Since commit 2d99ced787e3 ("drm/msm: async commit support"), the frame > buffer console on my Nexus 5 began throwing these errors: > > msm fd90.mdss: pp done time out, lm=0 > > The display still works. > > I see that mdp5_flus