[PATCH v5 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-07 Thread Aleksandrs Vinarskis
DisplayPort requires per-segment link training when LTTPR are switched to non-transparent mode, starting with LTTPR closest to the source. Only when each segment is trained individually, source can link train to sink. Implement per-segment link traning when LTTPR(s) are detected, to support extern

[PATCH v5 0/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-07 Thread Aleksandrs Vinarskis
el.org/all/20250310211039.29843-1-alex.vinars...@gmail.com/ Aleksandrs Vinarskis (4): drm/msm/dp: Fix support of LTTPR initialization drm/msm/dp: Account for LTTPRs capabilities drm/msm/dp: Prepare for link training per-segment for LTTPRs drm/msm/dp: Introduce link training per-segment for

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-07 Thread Aleksandrs Vinarskis
On Thu, 8 May 2025 at 00:08, Abhinav Kumar wrote: > > Hi Alex > > > On 5/7/2025 3:01 PM, Aleksandrs Vinarskis wrote: > > On Tue, 6 May 2025 at 01:41, Abhinav Kumar > > wrote: > >> > >> Hi Alex > >> > >> On 5/4/2025 3:06 PM, Aleksandrs Vinarskis wrote: > >>> On Sun, 4 May 2025 at 05:02, Abhinav K

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-07 Thread Abhinav Kumar
Hi Alex On 5/7/2025 3:01 PM, Aleksandrs Vinarskis wrote: On Tue, 6 May 2025 at 01:41, Abhinav Kumar wrote: Hi Alex On 5/4/2025 3:06 PM, Aleksandrs Vinarskis wrote: On Sun, 4 May 2025 at 05:02, Abhinav Kumar wrote: Hi Alex Thanks for the response. My updates below. I also had one quest

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-07 Thread Aleksandrs Vinarskis
On Tue, 6 May 2025 at 01:41, Abhinav Kumar wrote: > > Hi Alex > > On 5/4/2025 3:06 PM, Aleksandrs Vinarskis wrote: > > On Sun, 4 May 2025 at 05:02, Abhinav Kumar > > wrote: > >> > >> Hi Alex > >> > >> Thanks for the response. > >> > >> My updates below. I also had one question for Abel below. >

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-05 Thread Abhinav Kumar
Hi Alex On 5/4/2025 3:06 PM, Aleksandrs Vinarskis wrote: On Sun, 4 May 2025 at 05:02, Abhinav Kumar wrote: Hi Alex Thanks for the response. My updates below. I also had one question for Abel below. Thanks Abhinav On 5/1/2025 8:56 AM, Aleksandrs Vinarskis wrote: On Thu, 1 May 2025 at 04:

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-05 Thread Aleksandrs Vinarskis
On Mon, 5 May 2025 at 00:06, Aleksandrs Vinarskis wrote: > > On Sun, 4 May 2025 at 05:02, Abhinav Kumar wrote: > > > > Hi Alex > > > > Thanks for the response. > > > > My updates below. I also had one question for Abel below. > > > > Thanks > > > > Abhinav > > > > On 5/1/2025 8:56 AM, Aleksandrs

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-04 Thread Aleksandrs Vinarskis
On Sun, 4 May 2025 at 05:02, Abhinav Kumar wrote: > > Hi Alex > > Thanks for the response. > > My updates below. I also had one question for Abel below. > > Thanks > > Abhinav > > On 5/1/2025 8:56 AM, Aleksandrs Vinarskis wrote: > > On Thu, 1 May 2025 at 04:11, Abhinav Kumar > > wrote: > >> > >>

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-03 Thread Abhinav Kumar
Hi Alex Thanks for the response. My updates below. I also had one question for Abel below. Thanks Abhinav On 5/1/2025 8:56 AM, Aleksandrs Vinarskis wrote: On Thu, 1 May 2025 at 04:11, Abhinav Kumar wrote: On 4/29/2025 5:09 PM, Aleksandrs Vinarskis wrote: DisplayPort requires per-segmen

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-05-01 Thread Aleksandrs Vinarskis
On Thu, 1 May 2025 at 04:11, Abhinav Kumar wrote: > > > > On 4/29/2025 5:09 PM, Aleksandrs Vinarskis wrote: > > DisplayPort requires per-segment link training when LTTPR are switched > > to non-transparent mode, starting with LTTPR closest to the source. > > Only when each segment is trained indiv

Re: [PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-30 Thread Abhinav Kumar
On 4/29/2025 5:09 PM, Aleksandrs Vinarskis wrote: DisplayPort requires per-segment link training when LTTPR are switched to non-transparent mode, starting with LTTPR closest to the source. Only when each segment is trained individually, source can link train to sink. Implement per-segment lin

[PATCH v4 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Aleksandrs Vinarskis
DisplayPort requires per-segment link training when LTTPR are switched to non-transparent mode, starting with LTTPR closest to the source. Only when each segment is trained individually, source can link train to sink. Implement per-segment link traning when LTTPR(s) are detected, to support extern

[PATCH v4 0/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Aleksandrs Vinarskis
ms on Xorg. - Link to v1: https://lore.kernel.org/all/20250310211039.29843-1-alex.vinars...@gmail.com/ Aleksandrs Vinarskis (4): drm/msm/dp: Fix support of LTTPR initialization drm/msm/dp: Account for LTTPRs capabilities drm/msm/dp: Prepare for link training per-segment for LTTPRs drm/msm/dp: I

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Dmitry Baryshkov
On Tue, Apr 29, 2025 at 12:57:16PM +0200, Aleksandrs Vinarskis wrote: > On Tue, 29 Apr 2025 at 10:03, Johan Hovold wrote: > > > > On Tue, Apr 29, 2025 at 10:50:55AM +0300, Abel Vesa wrote: > > > On 25-04-29 09:23:46, Johan Hovold wrote: > > > > On Mon, Apr 28, 2025 at 05:17:21PM +0300, Abel Vesa w

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Johan Hovold
On Tue, Apr 29, 2025 at 12:57:16PM +0200, Aleksandrs Vinarskis wrote: > On Tue, 29 Apr 2025 at 10:03, Johan Hovold wrote: > > On Tue, Apr 29, 2025 at 10:50:55AM +0300, Abel Vesa wrote: > > > On 25-04-29 09:23:46, Johan Hovold wrote: > > > > But this is the crux; does any off-board LTTPRs in trans

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Aleksandrs Vinarskis
On Tue, 29 Apr 2025 at 10:03, Johan Hovold wrote: > > On Tue, Apr 29, 2025 at 10:50:55AM +0300, Abel Vesa wrote: > > On 25-04-29 09:23:46, Johan Hovold wrote: > > > On Mon, Apr 28, 2025 at 05:17:21PM +0300, Abel Vesa wrote: > > > > On 25-04-28 14:47:04, Johan Hovold wrote: > > > > > On Mon, Apr 28

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Johan Hovold
On Tue, Apr 29, 2025 at 10:50:55AM +0300, Abel Vesa wrote: > On 25-04-29 09:23:46, Johan Hovold wrote: > > On Mon, Apr 28, 2025 at 05:17:21PM +0300, Abel Vesa wrote: > > > On 25-04-28 14:47:04, Johan Hovold wrote: > > > > On Mon, Apr 28, 2025 at 11:06:39AM +0200, Aleksandrs Vinarskis wrote: > > > >

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Abel Vesa
On 25-04-29 09:23:46, Johan Hovold wrote: > On Mon, Apr 28, 2025 at 05:17:21PM +0300, Abel Vesa wrote: > > On 25-04-28 14:47:04, Johan Hovold wrote: > > > On Mon, Apr 28, 2025 at 11:06:39AM +0200, Aleksandrs Vinarskis wrote: > > > > On Mon, 28 Apr 2025 at 09:45, Johan Hovold wrote: > > > > > On Th

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Aleksandrs Vinarskis
On Tue, 29 Apr 2025 at 08:52, Abel Vesa wrote: > > On 25-04-28 20:23:45, Aleksandrs Vinarskis wrote: > > On Mon, 28 Apr 2025 at 16:17, Abel Vesa wrote: > > > > > > The change itself makes sense though and I think makes sense to be marked > > > as a fix. > > > > Just to confirm, you mean to mark

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-29 Thread Johan Hovold
On Mon, Apr 28, 2025 at 05:17:21PM +0300, Abel Vesa wrote: > On 25-04-28 14:47:04, Johan Hovold wrote: > > On Mon, Apr 28, 2025 at 11:06:39AM +0200, Aleksandrs Vinarskis wrote: > > > On Mon, 28 Apr 2025 at 09:45, Johan Hovold wrote: > > > > On Thu, Apr 17, 2025 at 04:10:31AM +0200, Aleksandrs Vina

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-28 Thread Abel Vesa
On 25-04-28 20:23:45, Aleksandrs Vinarskis wrote: > On Mon, 28 Apr 2025 at 16:17, Abel Vesa wrote: > > > > The change itself makes sense though and I think makes sense to be marked > > as a fix. > > Just to confirm, you mean to mark as fix only the 1st patch, correct? > Since it's obvious now th

Re: [PATCH v3 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-28 Thread Rob Clark
On Wed, Apr 16, 2025 at 7:13 PM Aleksandrs Vinarskis wrote: > > DisplayPort requires per-segment link training when LTTPR are switched > to non-transparent mode, starting with LTTPR closest to the source. > Only when each segment is trained individually, source can link train > to sink. > > Implem

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-28 Thread Aleksandrs Vinarskis
On Mon, 28 Apr 2025 at 16:17, Abel Vesa wrote: > > On 25-04-28 14:47:04, Johan Hovold wrote: > > On Mon, Apr 28, 2025 at 11:06:39AM +0200, Aleksandrs Vinarskis wrote: > > > On Mon, 28 Apr 2025 at 09:45, Johan Hovold wrote: > > > > On Thu, Apr 17, 2025 at 04:10:31AM +0200, Aleksandrs Vinarskis wro

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-28 Thread Abel Vesa
On 25-04-28 14:47:04, Johan Hovold wrote: > On Mon, Apr 28, 2025 at 11:06:39AM +0200, Aleksandrs Vinarskis wrote: > > On Mon, 28 Apr 2025 at 09:45, Johan Hovold wrote: > > > On Thu, Apr 17, 2025 at 04:10:31AM +0200, Aleksandrs Vinarskis wrote: > > > > Recently added Initial LTTPR support in msm/dp

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-28 Thread Johan Hovold
On Mon, Apr 28, 2025 at 11:06:39AM +0200, Aleksandrs Vinarskis wrote: > On Mon, 28 Apr 2025 at 09:45, Johan Hovold wrote: > > On Thu, Apr 17, 2025 at 04:10:31AM +0200, Aleksandrs Vinarskis wrote: > > > Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) > > > to non-transparent

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-28 Thread Aleksandrs Vinarskis
DP altmode still > works on my X13s and T14s (while not using any docks): > > Tested-by: Johan Hovold Thanks, Alex > > > Aleksandrs Vinarskis (4): > > drm/msm/dp: Fix support of LTTPR initialization > > drm/msm/dp: Account for LTTPRs capabilities > > drm/msm/dp: Prepare for link training per-segment for LTTPRs > > drm/msm/dp: Introduce link training per-segment for LTTPRs > > Johan

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-28 Thread Johan Hovold
on my X13s and T14s (while not using any docks): Tested-by: Johan Hovold > Aleksandrs Vinarskis (4): > drm/msm/dp: Fix support of LTTPR initialization > drm/msm/dp: Account for LTTPRs capabilities > drm/msm/dp: Prepare for link training per-segment for LTTPRs > drm/msm/dp: Introduce link training per-segment for LTTPRs Johan

Re: [PATCH v3 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-25 Thread Dmitry Baryshkov
On Thu, Apr 17, 2025 at 04:10:35AM +0200, Aleksandrs Vinarskis wrote: > DisplayPort requires per-segment link training when LTTPR are switched > to non-transparent mode, starting with LTTPR closest to the source. > Only when each segment is trained individually, source can link train > to sink. >

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-24 Thread Dmitry Baryshkov
2: > > https://lore.kernel.org/all/20250311234109.136510-1-alex.vinars...@gmail.com/ > > > > Changes in v2: > > - Picked up Abel's R-b tags > > - Fixed typo as per Abel, fixed readability as per Johan > > - Updated cover and commit message on mailink iss

Re: drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-24 Thread Rob Clark
34109.136510-1-alex.vinars...@gmail.com/ > > Changes in v2: > - Picked up Abel's R-b tags > - Fixed typo as per Abel, fixed readability as per Johan > - Updated cover and commit message on mailink issue which appears to be > specific to Gnome+Wayland. No problems on Xorg. > - L

drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-18 Thread Aleksandrs Vinarskis
310211039.29843-1-alex.vinars...@gmail.com/ Aleksandrs Vinarskis (4): drm/msm/dp: Fix support of LTTPR initialization drm/msm/dp: Account for LTTPRs capabilities drm/msm/dp: Prepare for link training per-segment for LTTPRs drm/msm/dp: Introduce link training per-segment

[PATCH v3 4/4] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-16 Thread Aleksandrs Vinarskis
DisplayPort requires per-segment link training when LTTPR are switched to non-transparent mode, starting with LTTPR closest to the source. Only when each segment is trained individually, source can link train to sink. Implement per-segment link traning when LTTPR(s) are detected, to support extern

Re: [PATCH v2 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-10 Thread Dmitry Baryshkov
On 09/04/2025 01:29, Aleksandrs Vinarskis wrote: On Tue, 1 Apr 2025 at 02:55, Dmitry Baryshkov wrote: On Wed, Mar 12, 2025 at 12:38:04AM +0100, Aleksandrs Vinarskis wrote: DisplayPort requires per-segment link training when LTTPR are switched to non-transparent mode, starting with LTTPR close

Re: [PATCH v2 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-08 Thread Aleksandrs Vinarskis
On Tue, 1 Apr 2025 at 02:55, Dmitry Baryshkov wrote: > > On Wed, Mar 12, 2025 at 12:38:04AM +0100, Aleksandrs Vinarskis wrote: > > DisplayPort requires per-segment link training when LTTPR are switched > > to non-transparent mode, starting with LTTPR closest to the source. > > Only when each segme

Re: [PATCH v2 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-31 Thread Dmitry Baryshkov
On Wed, Mar 12, 2025 at 12:38:04AM +0100, Aleksandrs Vinarskis wrote: > DisplayPort requires per-segment link training when LTTPR are switched > to non-transparent mode, starting with LTTPR closest to the source. > Only when each segment is trained individually, source can link train > to sink. >

Re: [PATCH v2 0/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-15 Thread Aleksandrs Vinarskis
On 3/12/25 22:16, Stefan Schmidt wrote: Hello Aleksandrs, On Wed, 12 Mar 2025 at 00:41, Aleksandrs Vinarskis wrote: Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) to non-transparent mode to enable video output on X1E-based devices that come with LTTPR on the motherb

RE: [PATCH v2 0/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-14 Thread Tudor, Laurentiu
> -Original Message- > From: Aleksandrs Vinarskis > Sent: Wednesday, March 12, 2025 1:38 AM > Subject: [PATCH v2 0/2] drm/msm/dp: Introduce link training per-segment for > LTTPRs > > Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) to >

Re: [PATCH v2 0/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-12 Thread Stefan Schmidt
Hello Aleksandrs, On Wed, 12 Mar 2025 at 00:41, Aleksandrs Vinarskis wrote: > > Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) > to non-transparent mode to enable video output on X1E-based devices > that come with LTTPR on the motherboards. However, video would not work >

[PATCH v2 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-11 Thread Aleksandrs Vinarskis
DisplayPort requires per-segment link training when LTTPR are switched to non-transparent mode, starting with LTTPR closest to the source. Only when each segment is trained individually, source can link train to sink. Implement per-segment link traning when LTTPR(s) are detected, to support extern

[PATCH v2 0/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-11 Thread Aleksandrs Vinarskis
g. - Link to v1: https://lore.kernel.org/all/20250310211039.29843-1-alex.vinars...@gmail.com/ --- Aleksandrs Vinarskis (2): drm/msm/dp: Fix support of LTTPR handling drm/msm/dp: Introduce link training per-segment for LTTPRs drivers/gpu/drm/msm/dp/dp_ctrl.c| 137 +++---

Re: [PATCH v1 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-11 Thread Abel Vesa
On 25-03-10 22:05:52, Aleksandrs Vinarskis wrote: > DisplayPort requires per-segment link training when LTTPR are switched > to non-transparent mode, starting with LTTPR closest to the source. > Only when each segment is trained individually, source can link train > to sink. > > Implement per-segm

Re: [PATCH v1 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-11 Thread Johan Hovold
Hi Aleksandrs, Just a drive-by comment. On Mon, Mar 10, 2025 at 10:05:52PM +0100, Aleksandrs Vinarskis wrote: > @@ -1084,10 +1091,13 @@ static int msm_dp_ctrl_update_vx_px(struct > msm_dp_ctrl_private *ctrl) > } > > static bool msm_dp_ctrl_train_pattern_set(struct msm_dp_ctrl_private *ctrl,

[PATCH v1 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-10 Thread Aleksandrs Vinarskis
DisplayPort requires per-segment link training when LTTPR are switched to non-transparent mode, starting with LTTPR closest to the source. Only when each segment is trained individually, source can link train to sink. Implement per-segment link traning when LTTPR(s) are detected, to support extern

[PATCH v1 0/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-10 Thread Aleksandrs Vinarskis
driver. [1] https://lore.kernel.org/all/20250226231436.16138-2-alex.vinars...@gmail.com/ Aleksandrs Vinarskis (2): drm/msm/dp: Fix support of LTTPR handling drm/msm/dp: Introduce link training per-segment for LTTPRs drivers/gpu/drm/msm/dp/dp_ctrl.c| 136 +++- drivers/gpu/d