drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-12 Thread Indan Zupancic
On Fri, March 11, 2011 18:27, Jesse Barnes wrote: > On Fri, 11 Mar 2011 02:35:45 +0100 (CET) > "Indan Zupancic" wrote: > >> drm/i915: Fix DPMS and suspend interaction for intel_panel.c >> >> When suspending intel_panel_disable_backlight() is never called, >

Re: drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-11 Thread Indan Zupancic
On Fri, March 11, 2011 18:27, Jesse Barnes wrote: > On Fri, 11 Mar 2011 02:35:45 +0100 (CET) > "Indan Zupancic" wrote: > >> drm/i915: Fix DPMS and suspend interaction for intel_panel.c >> >> When suspending intel_panel_disable_backlight() is never called, >

drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-11 Thread Indan Zupancic
On Fri, March 11, 2011 09:07, Chris Wilson wrote: >> Nothing guarantees that those calls will be balanced, so having >> backlight_enabled makes no sense, as the real state can change >> without the panel code noticing. So keep things as stateless as >> possible. > > The problem is wider than descri

drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-11 Thread Indan Zupancic
On Fri, March 11, 2011 08:23, Takashi Iwai wrote: > [Removed stable-kernel from Cc] > > At Fri, 11 Mar 2011 02:35:45 +0100 (CET), > Indan Zupancic wrote: >> >> drm/i915: Fix DPMS and suspend interaction for intel_panel.c >> >> When suspending intel_panel_disable

Re: drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-11 Thread Jesse Barnes
On Fri, 11 Mar 2011 02:35:45 +0100 (CET) "Indan Zupancic" wrote: > drm/i915: Fix DPMS and suspend interaction for intel_panel.c > > When suspending intel_panel_disable_backlight() is never called, > but intel_panel_enable_backlight() is called at resume. With the > effe

drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-11 Thread Jesse Barnes
On Fri, 11 Mar 2011 02:35:45 +0100 (CET) "Indan Zupancic" wrote: > drm/i915: Fix DPMS and suspend interaction for intel_panel.c > > When suspending intel_panel_disable_backlight() is never called, > but intel_panel_enable_backlight() is called at resume. With the > effe

drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-11 Thread Takashi Iwai
[Removed stable-kernel from Cc] At Fri, 11 Mar 2011 02:35:45 +0100 (CET), Indan Zupancic wrote: > > drm/i915: Fix DPMS and suspend interaction for intel_panel.c > > When suspending intel_panel_disable_backlight() is never called, > but intel_panel_enable_backlight() is called

drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-11 Thread Chris Wilson
On Fri, 11 Mar 2011 02:35:45 +0100 (CET), "Indan Zupancic" wrote: > drm/i915: Fix DPMS and suspend interaction for intel_panel.c > > When suspending intel_panel_disable_backlight() is never called, > but intel_panel_enable_backlight() is called at resume. With th

drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-11 Thread Indan Zupancic
drm/i915: Fix DPMS and suspend interaction for intel_panel.c When suspending intel_panel_disable_backlight() is never called, but intel_panel_enable_backlight() is called at resume. With the effect that if the brightness was ever changed after screen blanking, the wrong brightness gets restored

Re: drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-11 Thread Indan Zupancic
On Fri, March 11, 2011 09:07, Chris Wilson wrote: >> Nothing guarantees that those calls will be balanced, so having >> backlight_enabled makes no sense, as the real state can change >> without the panel code noticing. So keep things as stateless as >> possible. > > The problem is wider than descri

Re: drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-11 Thread Indan Zupancic
On Fri, March 11, 2011 08:23, Takashi Iwai wrote: > [Removed stable-kernel from Cc] > > At Fri, 11 Mar 2011 02:35:45 +0100 (CET), > Indan Zupancic wrote: >> >> drm/i915: Fix DPMS and suspend interaction for intel_panel.c >> >> When suspending intel_panel_disable

Re: drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-11 Thread Chris Wilson
On Fri, 11 Mar 2011 02:35:45 +0100 (CET), "Indan Zupancic" wrote: > drm/i915: Fix DPMS and suspend interaction for intel_panel.c > > When suspending intel_panel_disable_backlight() is never called, > but intel_panel_enable_backlight() is called at resume. With the > effe

Re: drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-10 Thread Takashi Iwai
[Removed stable-kernel from Cc] At Fri, 11 Mar 2011 02:35:45 +0100 (CET), Indan Zupancic wrote: > > drm/i915: Fix DPMS and suspend interaction for intel_panel.c > > When suspending intel_panel_disable_backlight() is never called, > but intel_panel_enable_backlight() is called

drm/i915: Fix DPMS and suspend interaction for intel_panel.c

2011-03-10 Thread Indan Zupancic
drm/i915: Fix DPMS and suspend interaction for intel_panel.c When suspending intel_panel_disable_backlight() is never called, but intel_panel_enable_backlight() is called at resume. With the effect that if the brightness was ever changed after screen blanking, the wrong brightness gets restored