drm/i2c: tda998x: use irq for connection status and EDID read

2014-07-07 Thread Jean-Francois Moine
On Mon, 7 Jul 2014 17:22:03 +0300 Dan Carpenter wrote: > The patch 12473b7d8e60: "drm/i2c: tda998x: use irq for connection > status and EDID read" from Jan 25, 2014, leads to the following > static checker warning: > > drivers/gpu/drm/i2c/tda998x_drv.c:119

drm/i2c: tda998x: use irq for connection status and EDID read

2014-07-07 Thread Dan Carpenter
Hello Jean-Francois Moine, The patch 12473b7d8e60: "drm/i2c: tda998x: use irq for connection status and EDID read" from Jan 25, 2014, leads to the following static checker warning: drivers/gpu/drm/i2c/tda998x_drv.c:1199 tda998x_encoder_destroy() warn: variable dereferen

[PATCH v4 15/24] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-27 Thread Russell King - ARM Linux
On Sat, Jan 25, 2014 at 06:14:38PM +0100, Jean-Francois Moine wrote: > This patch adds the optional treatment of the tda998x IRQ. > > The interrupt function is used to know the display connection status > without polling and to speedup reading the EDID. > > The IRQ number is defined in the i2c cl

[PATCH v4 15/24] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-25 Thread Jean-Francois Moine
This patch adds the optional treatment of the tda998x IRQ. The interrupt function is used to know the display connection status without polling and to speedup reading the EDID. The IRQ number is defined in the i2c client either by platform data or in the DT. Signed-off-by: Jean-Francois Moine -

[PATCH v5 14/23] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-25 Thread Jean-Francois Moine
This patch adds the optional treatment of the tda998x IRQ. The interrupt function is used to know the display connection status without polling and to speedup reading the EDID. The IRQ number and trigger type are defined in the i2c client either by platform data or in the DT. Signed-off-by: Jean

[PATCH v3 15/24] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-24 Thread Sebastian Hesselbarth
On 01/22/14 23:27, Russell King - ARM Linux wrote: > On Sun, Jan 19, 2014 at 07:58:43PM +0100, Jean-Francois Moine wrote: >> This patch adds the optional treatment of the tda998x IRQ. >> >> The interrupt function is used to know the display connection status >> without polling and to speedup readin

[PATCH v3 15/24] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-24 Thread Russell King - ARM Linux
On Fri, Jan 24, 2014 at 06:29:12PM +0100, Sebastian Hesselbarth wrote: > On 01/22/14 23:27, Russell King - ARM Linux wrote: >> On Sun, Jan 19, 2014 at 07:58:43PM +0100, Jean-Francois Moine wrote: >>> This patch adds the optional treatment of the tda998x IRQ. >>> >>> The interrupt function is used t

[PATCH v3 15/24] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-22 Thread Russell King - ARM Linux
On Sun, Jan 19, 2014 at 07:58:43PM +0100, Jean-Francois Moine wrote: > This patch adds the optional treatment of the tda998x IRQ. > > The interrupt function is used to know the display connection status > without polling and to speedup reading the EDID. > > The interrupt number may be defined eit

[PATCH v3 15/24] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-19 Thread Jean-Francois Moine
This patch adds the optional treatment of the tda998x IRQ. The interrupt function is used to know the display connection status without polling and to speedup reading the EDID. The interrupt number may be defined either in the DT or at encoder set config time for non-DT boards. Signed-off-by: Je

[PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-17 Thread Jean-Francois Moine
On Sun, 12 Jan 2014 20:26:21 +0100 Sebastian Hesselbarth wrote: > On 01/12/2014 07:51 PM, Jean-Francois Moine wrote: > > On Sat, 11 Jan 2014 19:35:21 +0100 > > Sebastian Hesselbarth wrote: > > > >> At least for the DT part, I'd suggest to not ask for interrupt directly > >> but use a proper gpio

[PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-12 Thread Sebastian Hesselbarth
On 01/12/2014 07:51 PM, Jean-Francois Moine wrote: > On Sat, 11 Jan 2014 19:35:21 +0100 > Sebastian Hesselbarth wrote: > >> At least for the DT part, I'd suggest to not ask for interrupt directly >> but use a proper gpios property. The can of course be converted to >> priv->int_irq in some tda998x

[PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-12 Thread Jean-Francois Moine
On Sat, 11 Jan 2014 19:35:21 +0100 Sebastian Hesselbarth wrote: > At least for the DT part, I'd suggest to not ask for interrupt directly > but use a proper gpios property. The can of course be converted to > priv->int_irq in some tda998x_dt_probe. May you give me more information? -- Ken ar c

[PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-11 Thread Sebastian Hesselbarth
On 01/11/2014 07:14 PM, Russell King - ARM Linux wrote: > On Thu, Jan 09, 2014 at 12:04:12PM +0100, Jean-Francois Moine wrote: >> @@ -1250,6 +1311,39 @@ tda998x_encoder_init(struct i2c_client *client, >> priv->vip_cntrl_2 = video; >> } >> >> +/* install the optional HDMI conne

[PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-11 Thread Russell King - ARM Linux
On Thu, Jan 09, 2014 at 12:04:12PM +0100, Jean-Francois Moine wrote: > + if (priv->int_irq != NO_IRQ) { > + priv->wq_edid_wait = 1; > + i = wait_event_timeout(priv->wq_edid, > + !priv->wq_edid_wait, > +

[PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-09 Thread Jean-Francois Moine
This patch adds the optional treatment of the tda998x IRQ. The interrupt function is used to know the display connection status without polling and to speedup reading the EDID. Signed-off-by: Jean-Francois Moine --- drivers/gpu/drm/i2c/tda998x_drv.c| 116 +++-- .../d