Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-28 Thread Robert Foss
On Fri, 25 Mar 2022 at 07:29, Xin Ji wrote: > > On Thu, Mar 24, 2022 at 01:07:56PM +0100, Robert Foss wrote: > > > > > > The driver uses DRM_DEV_* for logs. Can we use this? > > > > > Hi Hsin-Yi, as comment in drm/drm_print.h: > > > > > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge dr

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-24 Thread Xin Ji
On Thu, Mar 24, 2022 at 01:07:56PM +0100, Robert Foss wrote: > > > > > The driver uses DRM_DEV_* for logs. Can we use this? > > > > Hi Hsin-Yi, as comment in drm/drm_print.h: > > > > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not > > > > use DRM_DEV_* any more. I'll send a pa

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-24 Thread Robert Foss
> > > > The driver uses DRM_DEV_* for logs. Can we use this? > > > Hi Hsin-Yi, as comment in drm/drm_print.h: > > > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not > > > use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_* > > > later. > > > > drm_dbg is bette

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Xin Ji
On Tue, Mar 22, 2022 at 05:16:43PM +0800, Chen-Yu Tsai wrote: > On Tue, Mar 22, 2022 at 4:52 PM Xin Ji wrote: > > > > On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote: > > > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > > > > > > > As downstream sink was set into standby mode whil

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Chen-Yu Tsai
On Tue, Mar 22, 2022 at 4:52 PM Xin Ji wrote: > > On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote: > > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > > > > > As downstream sink was set into standby mode while bridge disabled, > > > this patch used for setting downstream sink into

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Pin-yen Lin
The DRM_DEV_* macros have been deprecated: https://www.kernel.org/doc/html/latest/gpu/drm-internals.html#c.DRM_DEV_DEBUG_DRIVER On Tue, Mar 22, 2022 at 4:43 PM Hsin-Yi Wang wrote: > > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > > > As downstream sink was set into standby mode while bridge

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Xin Ji
On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote: > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > > > As downstream sink was set into standby mode while bridge disabled, > > this patch used for setting downstream sink into normal status > > while enable bridge. > > > > Signed-off-b

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Hsin-Yi Wang
On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > As downstream sink was set into standby mode while bridge disabled, > this patch used for setting downstream sink into normal status > while enable bridge. > > Signed-off-by: Xin Ji > Reviewed-by: Pin-Yen Lin > > --- > V1 -> V2: use dev_dbg repla

[PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Xin Ji
As downstream sink was set into standby mode while bridge disabled, this patch used for setting downstream sink into normal status while enable bridge. Signed-off-by: Xin Ji Reviewed-by: Pin-Yen Lin --- V1 -> V2: use dev_dbg replace of dev_info --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8

Re: drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Xin Ji
On Tue, Mar 22, 2022 at 03:33:17PM +0800, Pin-yen Lin wrote: > Hi Xin, > > Can we use dev_dbg instead of dev_info for the logging? > > The log here is more like a debugging message, and using dev_dbg makes > it consistent with anx7625_dp_stop. > > Sorry for not catching this earlier. > > Best r

Re: drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Pin-yen Lin
Hi Xin, Can we use dev_dbg instead of dev_info for the logging? The log here is more like a debugging message, and using dev_dbg makes it consistent with anx7625_dp_stop. Sorry for not catching this earlier. Best regards, Pin-yen On Thu, Mar 3, 2022 at 3:52 PM Pin-yen Lin wrote: > > Reviewed-

Re: drm/bridge: anx7625: Set downstream sink into normal status

2022-03-02 Thread Pin-yen Lin
Reviewed-by: Pin-Yen Lin On Wed, Mar 2, 2022 at 8:09 PM Xin Ji wrote: > > As downstream sink was set into standby mode while bridge disabled, > this patch used for setting downstream sink into normal status > while enable bridge. > > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analog

[PATCH] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-02 Thread Xin Ji
As downstream sink was set into standby mode while bridge disabled, this patch used for setting downstream sink into normal status while enable bridge. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/