drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Valentin Rothberg
Hi Christian, On Thu, Jun 4, 2015 at 6:47 PM, Christian König wrote: > On 04.06.2015 17:09, Alex Deucher wrote: >> >> On Thu, Jun 4, 2015 at 10:04 AM, Valentin Rothberg >> wrote: >>> >>> Hi Alex, >>> >>> On Thu, Jun 4, 2015 at 4:01 PM, Alex Deucher >>> wrote: On Thu, Jun 4, 2015 at

drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Christian König
On 04.06.2015 17:09, Alex Deucher wrote: > On Thu, Jun 4, 2015 at 10:04 AM, Valentin Rothberg > wrote: >> Hi Alex, >> >> On Thu, Jun 4, 2015 at 4:01 PM, Alex Deucher >> wrote: >>> On Thu, Jun 4, 2015 at 9:48 AM, Oded Gabbay >>> wrote: Hi Valentin, Thanks for catching that. I wou

drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Valentin Rothberg
Hi Alex, On Thu, Jun 4, 2015 at 4:01 PM, Alex Deucher wrote: > On Thu, Jun 4, 2015 at 9:48 AM, Oded Gabbay wrote: >> Hi Valentin, >> Thanks for catching that. >> I would be grateful if you could fix this yourself. > > Please try and keep CONFIG in the name since this range of registers > are cal

drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Valentin Rothberg
Hi Oded, On Thu, Jun 4, 2015 at 3:48 PM, Oded Gabbay wrote: > Hi Valentin, > Thanks for catching that. > I would be grateful if you could fix this yourself. With pleasure, I am happy if I can help. Do you have any preference to change the prefix to something else? As there are three other sym

drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Valentin Rothberg
Hi Yair, your commit fbeb661bfa89 ("drm/amdkfd: Add skeleton H/W debugger module support") has shown up in today's linux-next tree (i.e., next-20150604). The commit adds the following lines of code to drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.h: +/* CONFIG reg space definition */ +enum { + CON

drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Oded Gabbay
Hi Valentin, Thanks for catching that. I would be grateful if you could fix this yourself. Oded On Thu, Jun 4, 2015 at 4:45 PM Valentin Rothberg wrote: > Hi Yair, > > your commit fbeb661bfa89 ("drm/amdkfd: Add skeleton H/W debugger > module support") has shown up in today's linux-next tree (i.e

drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Alex Deucher
On Thu, Jun 4, 2015 at 10:04 AM, Valentin Rothberg wrote: > Hi Alex, > > On Thu, Jun 4, 2015 at 4:01 PM, Alex Deucher wrote: >> On Thu, Jun 4, 2015 at 9:48 AM, Oded Gabbay wrote: >>> Hi Valentin, >>> Thanks for catching that. >>> I would be grateful if you could fix this yourself. >> >> Please t

drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Alex Deucher
On Thu, Jun 4, 2015 at 9:48 AM, Oded Gabbay wrote: > Hi Valentin, > Thanks for catching that. > I would be grateful if you could fix this yourself. Please try and keep CONFIG in the name since this range of registers are called CONFIG registers. Alex > > Oded > > On Thu, Jun 4, 2015 at 4:45 PM