commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Sascha Hauer
On Tue, Aug 27, 2013 at 01:26:32PM +0200, Daniel Vetter wrote: > On Tue, Aug 27, 2013 at 1:22 PM, Rob Clark wrote: > >> right, but the cores on the SoC, and even any external encoder chips, > >> are not actually hot-pluggable. I have a similar scenario w/ msm drm, > > > > oh, and come to think of

commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Daniel Vetter
On Tue, Aug 27, 2013 at 1:22 PM, Rob Clark wrote: >> right, but the cores on the SoC, and even any external encoder chips, >> are not actually hot-pluggable. I have a similar scenario w/ msm drm, > > oh, and come to think of it, same approach it tilcdc. And I'm sure > there are other drivers wit

commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Lucas Stach
Am Dienstag, den 27.08.2013, 10:41 +0200 schrieb Daniel Vetter: > On Tue, Aug 27, 2013 at 10:26 AM, Lucas Stach > wrote: > >> If I understand stuff correctly you have a main driver plus a bunch of > >> encoder/crtc modules and you expect that everything gets loaded and then > >> only when the kms

commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Sascha Hauer
On Tue, Aug 27, 2013 at 10:41:20AM +0200, Daniel Vetter wrote: > On Tue, Aug 27, 2013 at 10:26 AM, Lucas Stach > wrote: > >> If I understand stuff correctly you have a main driver plus a bunch of > >> encoder/crtc modules and you expect that everything gets loaded and then > >> only when the kms

commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Daniel Vetter
On Tue, Aug 27, 2013 at 10:26 AM, Lucas Stach wrote: >> If I understand stuff correctly you have a main driver plus a bunch of >> encoder/crtc modules and you expect that everything gets loaded and then >> only when the kms driver is first opened. The current drm core just >> doesn't support hotpl

commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Lucas Stach
Hi Daniel, Am Dienstag, den 27.08.2013, 10:08 +0200 schrieb Daniel Vetter: > On Tue, Aug 27, 2013 at 9:46 AM, Lothar Wa?mann > wrote: > > the function imx_drm_driver_load() must have been called before > > calling imx_drm_add_crtc(), but the following hunk in the commit: > > @@ -446,6 +434,9 @@

commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Daniel Vetter
On Tue, Aug 27, 2013 at 9:46 AM, Lothar Wa?mann wrote: > the function imx_drm_driver_load() must have been called before > calling imx_drm_add_crtc(), but the following hunk in the commit: > @@ -446,6 +434,9 @@ static int imx_drm_driver_load(struct drm_device *drm, > unsigned long flags) >

commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Rob Clark
On Tue, Aug 27, 2013 at 7:19 AM, Rob Clark wrote: > On Tue, Aug 27, 2013 at 4:56 AM, Sascha Hauer > wrote: >> On Tue, Aug 27, 2013 at 10:41:20AM +0200, Daniel Vetter wrote: >>> On Tue, Aug 27, 2013 at 10:26 AM, Lucas Stach >>> wrote: >>> >> If I understand stuff correctly you have a main drive

commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Rob Clark
On Tue, Aug 27, 2013 at 4:56 AM, Sascha Hauer wrote: > On Tue, Aug 27, 2013 at 10:41:20AM +0200, Daniel Vetter wrote: >> On Tue, Aug 27, 2013 at 10:26 AM, Lucas Stach >> wrote: >> >> If I understand stuff correctly you have a main driver plus a bunch of >> >> encoder/crtc modules and you expect

Re: commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Sascha Hauer
On Tue, Aug 27, 2013 at 01:26:32PM +0200, Daniel Vetter wrote: > On Tue, Aug 27, 2013 at 1:22 PM, Rob Clark wrote: > >> right, but the cores on the SoC, and even any external encoder chips, > >> are not actually hot-pluggable. I have a similar scenario w/ msm drm, > > > > oh, and come to think of

Re: commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Daniel Vetter
On Tue, Aug 27, 2013 at 1:22 PM, Rob Clark wrote: >> right, but the cores on the SoC, and even any external encoder chips, >> are not actually hot-pluggable. I have a similar scenario w/ msm drm, > > oh, and come to think of it, same approach it tilcdc. And I'm sure > there are other drivers wit

Re: commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Rob Clark
On Tue, Aug 27, 2013 at 7:19 AM, Rob Clark wrote: > On Tue, Aug 27, 2013 at 4:56 AM, Sascha Hauer wrote: >> On Tue, Aug 27, 2013 at 10:41:20AM +0200, Daniel Vetter wrote: >>> On Tue, Aug 27, 2013 at 10:26 AM, Lucas Stach >>> wrote: >>> >> If I understand stuff correctly you have a main driver p

Re: commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Rob Clark
On Tue, Aug 27, 2013 at 4:56 AM, Sascha Hauer wrote: > On Tue, Aug 27, 2013 at 10:41:20AM +0200, Daniel Vetter wrote: >> On Tue, Aug 27, 2013 at 10:26 AM, Lucas Stach wrote: >> >> If I understand stuff correctly you have a main driver plus a bunch of >> >> encoder/crtc modules and you expect that

Re: commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Lucas Stach
Am Dienstag, den 27.08.2013, 10:41 +0200 schrieb Daniel Vetter: > On Tue, Aug 27, 2013 at 10:26 AM, Lucas Stach wrote: > >> If I understand stuff correctly you have a main driver plus a bunch of > >> encoder/crtc modules and you expect that everything gets loaded and then > >> only when the kms dr

Re: commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Sascha Hauer
On Tue, Aug 27, 2013 at 10:41:20AM +0200, Daniel Vetter wrote: > On Tue, Aug 27, 2013 at 10:26 AM, Lucas Stach wrote: > >> If I understand stuff correctly you have a main driver plus a bunch of > >> encoder/crtc modules and you expect that everything gets loaded and then > >> only when the kms dri

Re: commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Daniel Vetter
On Tue, Aug 27, 2013 at 10:26 AM, Lucas Stach wrote: >> If I understand stuff correctly you have a main driver plus a bunch of >> encoder/crtc modules and you expect that everything gets loaded and then >> only when the kms driver is first opened. The current drm core just >> doesn't support hotpl

Re: commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Lucas Stach
Hi Daniel, Am Dienstag, den 27.08.2013, 10:08 +0200 schrieb Daniel Vetter: > On Tue, Aug 27, 2013 at 9:46 AM, Lothar Waßmann > wrote: > > the function imx_drm_driver_load() must have been called before > > calling imx_drm_add_crtc(), but the following hunk in the commit: > > @@ -446,6 +434,9 @@

Re: commit b5dc0d108cd3c0b50ddcb6f6c54be1bea4c39e01 breaks imx-drm support

2013-08-27 Thread Daniel Vetter
On Tue, Aug 27, 2013 at 9:46 AM, Lothar Waßmann wrote: > the function imx_drm_driver_load() must have been called before > calling imx_drm_add_crtc(), but the following hunk in the commit: > @@ -446,6 +434,9 @@ static int imx_drm_driver_load(struct drm_device *drm, > unsigned long flags) >