Re: amdgpu_dm_connector_mode_valid regression

2025-04-24 Thread Alex Deucher
On Thu, Apr 24, 2025 at 4:49 AM Marek Marczykowski-Górecki wrote: > > On Fri, Apr 11, 2025 at 12:01:28PM +0200, Marek Marczykowski-Górecki wrote: > > > > Hi, > > > > On Wed, Apr 02, 2025 at 04:35:05PM +0200, Gergo Koteles wrote: > > > Hi Dmitry, > > > > > > But the code would start to become quite

Re: amdgpu_dm_connector_mode_valid regression

2025-04-24 Thread Gergo Koteles
Hi Marek, On Thu, 2025-04-24 at 10:48 +0200, Marek Marczykowski-Górecki wrote: > On Fri, Apr 11, 2025 at 12:01:28PM +0200, Marek Marczykowski-Górecki wrote: > > > > Hi, > > > > On Wed, Apr 02, 2025 at 04:35:05PM +0200, Gergo Koteles wrote: > > > Hi Dmitry, > > > > > > But the code would start t

Re: amdgpu_dm_connector_mode_valid regression

2025-04-24 Thread Marek Marczykowski-Górecki
On Fri, Apr 11, 2025 at 12:01:28PM +0200, Marek Marczykowski-Górecki wrote: > > Hi, > > On Wed, Apr 02, 2025 at 04:35:05PM +0200, Gergo Koteles wrote: > > Hi Dmitry, > > > > But the code would start to become quite untraceable. > > duplicate mode in amdgpu_dm_connector_mode_valid() > > call drm_

Re: amdgpu_dm_connector_mode_valid regression

2025-04-11 Thread Marek Marczykowski-Górecki
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On Wed, Apr 02, 2025 at 04:35:05PM +0200, Gergo Koteles wrote: > Hi Dmitry, > > But the code would start to become quite untraceable. > duplicate mode in amdgpu_dm_connector_mode_valid() > call drm_mode_set_crtcinfo() in amdgpu_dm_connector_mo

Re: amdgpu_dm_connector_mode_valid regression

2025-04-02 Thread Gergo Koteles
Hi Dmitry, On Wed, 2025-04-02 at 17:40 +0300, Dmitry Baryshkov wrote: > On Wed, 2 Apr 2025 at 17:35, Gergo Koteles wrote: > > > > Hi Dmitry, > > > > On Wed, 2025-04-02 at 16:36 +0300, Dmitry Baryshkov wrote: > > > > > > > > > > It works if I call > > > > > drm_mode_set_crtcinfo((struct drm_dis

Re: amdgpu_dm_connector_mode_valid regression

2025-04-02 Thread Dmitry Baryshkov
On Wed, 2 Apr 2025 at 17:35, Gergo Koteles wrote: > > Hi Dmitry, > > On Wed, 2025-04-02 at 16:36 +0300, Dmitry Baryshkov wrote: > > > > > > > > It works if I call > > > > drm_mode_set_crtcinfo((struct drm_display_mode *)mode, 0) before > > > > create_validate_stream_for_sink() > > > > in amdgpu_dm

Re: amdgpu_dm_connector_mode_valid regression

2025-04-02 Thread Gergo Koteles
Hi Dmitry, On Wed, 2025-04-02 at 16:36 +0300, Dmitry Baryshkov wrote: > > > > > > It works if I call > > > drm_mode_set_crtcinfo((struct drm_display_mode *)mode, 0) before > > > create_validate_stream_for_sink() > > > in amdgpu_dm_connector_mode_valid() > > > > > > or > > > > > > if I comment o

Re: amdgpu_dm_connector_mode_valid regression

2025-04-02 Thread Dmitry Baryshkov
On Wed, 2 Apr 2025 at 15:00, Gergo Koteles wrote: > > to: Dmitry's new address > cc: regressions > > On Wed, 2025-04-02 at 12:40 +0200, Gergo Koteles wrote: > > Hi, > > > > While playing with > > https://lore.kernel.org/all/61c3df83ab73aba0bc7a941a443cd7faf4cf7fb0.1743195250.git.so...@irl.hu/ > >

Re: amdgpu_dm_connector_mode_valid regression

2025-04-02 Thread Gergo Koteles
to: Dmitry's new address cc: regressions On Wed, 2025-04-02 at 12:40 +0200, Gergo Koteles wrote: > Hi, > > While playing with > https://lore.kernel.org/all/61c3df83ab73aba0bc7a941a443cd7faf4cf7fb0.1743195250.git.so...@irl.hu/ > > I found a regression that prevented some EDID DTDs from being sele

amdgpu_dm_connector_mode_valid regression

2025-04-02 Thread Gergo Koteles
Hi, While playing with https://lore.kernel.org/all/61c3df83ab73aba0bc7a941a443cd7faf4cf7fb0.1743195250.git.so...@irl.hu/ I found a regression that prevented some EDID DTDs from being selected in some specific cases. This is the first bad commit: b255ce4 ("drm/amdgpu: don't change mode in amdgpu_