__i915_spin_request() sucks

2015-11-13 Thread Chris Wilson
On Fri, Nov 13, 2015 at 09:22:52AM -0700, Jens Axboe wrote: > On 11/13/2015 09:13 AM, Mike Galbraith wrote: > >On Fri, 2015-11-13 at 08:36 -0700, Jens Axboe wrote: > >>Previous patch was obvious pre-coffee crap, this should work for using > >>ktime to spin max 1usec. > > > >1us seems a tad low. I

__i915_spin_request() sucks

2015-11-13 Thread Jens Axboe
On 11/13/2015 03:12 PM, Chris Wilson wrote: > On Fri, Nov 13, 2015 at 09:22:52AM -0700, Jens Axboe wrote: >> On 11/13/2015 09:13 AM, Mike Galbraith wrote: >>> On Fri, 2015-11-13 at 08:36 -0700, Jens Axboe wrote: Previous patch was obvious pre-coffee crap, this should work for using ktime

__i915_spin_request() sucks

2015-11-13 Thread Jens Axboe
On 11/13/2015 09:13 AM, Mike Galbraith wrote: > On Fri, 2015-11-13 at 08:36 -0700, Jens Axboe wrote: >> Previous patch was obvious pre-coffee crap, this should work for using >> ktime to spin max 1usec. > > 1us seems a tad low. I doubt the little wooden gears and pulleys of my > core2 Toshiba Sate

__i915_spin_request() sucks

2015-11-13 Thread Chris Wilson
On Thu, Nov 12, 2015 at 03:52:02PM -0700, Jens Axboe wrote: > On 11/12/2015 03:19 PM, Chris Wilson wrote: > >>>So today, I figured I'd try just killing that spin. If it fails, we'll > >>>punt to normal completions, so easy change. And wow, MASSIVE difference. > >>>I can now scroll in chrome and not

__i915_spin_request() sucks

2015-11-13 Thread Mike Galbraith
On Fri, 2015-11-13 at 08:36 -0700, Jens Axboe wrote: > Previous patch was obvious pre-coffee crap, this should work for using > ktime to spin max 1usec. 1us seems a tad low. I doubt the little wooden gears and pulleys of my core2 Toshiba Satellite lappy can get one loop ground out in a usec :) >

__i915_spin_request() sucks

2015-11-13 Thread Jens Axboe
Previous patch was obvious pre-coffee crap, this should work for using ktime to spin max 1usec. diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 5cf4a1998273..21192e55c33c 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -114

__i915_spin_request() sucks

2015-11-13 Thread Jens Axboe
On 11/13/2015 02:15 AM, Chris Wilson wrote: > On Thu, Nov 12, 2015 at 03:52:02PM -0700, Jens Axboe wrote: >> On 11/12/2015 03:19 PM, Chris Wilson wrote: > So today, I figured I'd try just killing that spin. If it fails, we'll > punt to normal completions, so easy change. And wow, MASSIVE di

__i915_spin_request() sucks

2015-11-12 Thread Chris Wilson
On Thu, Nov 12, 2015 at 01:40:33PM -0700, Jens Axboe wrote: > On 11/12/2015 01:36 PM, Jens Axboe wrote: > >Hi, > > > >So a few months ago I got an XPS13 laptop, the one with the high res > >screen. GUI performance was never really that great, I attributed it to > >coming from a more powerful laptop

__i915_spin_request() sucks

2015-11-12 Thread Jens Axboe
On 11/12/2015 03:52 PM, Jens Axboe wrote: > On 11/12/2015 03:19 PM, Chris Wilson wrote: So today, I figured I'd try just killing that spin. If it fails, we'll punt to normal completions, so easy change. And wow, MASSIVE difference. I can now scroll in chrome and not rage! It's l

__i915_spin_request() sucks

2015-11-12 Thread Jens Axboe
On 11/12/2015 03:19 PM, Chris Wilson wrote: >>> So today, I figured I'd try just killing that spin. If it fails, we'll >>> punt to normal completions, so easy change. And wow, MASSIVE difference. >>> I can now scroll in chrome and not rage! It's like the laptop is 10x >>> faster now. >>> >>> Ran gi

__i915_spin_request() sucks

2015-11-12 Thread Jens Axboe
On 11/12/2015 01:36 PM, Jens Axboe wrote: > Hi, > > So a few months ago I got an XPS13 laptop, the one with the high res > screen. GUI performance was never really that great, I attributed it to > coming from a more powerful laptop, and the i915 driving a lot of > pixels. But yesterday I browsed fr

__i915_spin_request() sucks

2015-11-12 Thread Jens Axboe
Hi, So a few months ago I got an XPS13 laptop, the one with the high res screen. GUI performance was never really that great, I attributed it to coming from a more powerful laptop, and the i915 driving a lot of pixels. But yesterday I browsed from my wife's macbook, and was blown away. Wow, sc