Re: [PATCH v6] Documentation/gpu: VM_BIND locking document

On Wed, Nov 29, 2023 at 10:06:37AM +0100, Thomas Hellström wrote: > diff --git a/Documentation/gpu/drm-vm-bind-locking.rst > b/Documentation/gpu/drm-vm-bind-locking.rst > new file mode 100644 > index ..a345aa513d12 > --- /dev/null > +++ b/Documentation/gpu/drm-vm-bind-locking.rst > @@

Re: [PATCH v6] Documentation/gpu: VM_BIND locking document

On 11/29/23 20:20, John Hubbard wrote: On 11/29/23 01:06, Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and

Re: [PATCH v6] Documentation/gpu: VM_BIND locking document

On 11/29/23 01:06, Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gpu-vmas. Intention is to be

[PATCH v6] Documentation/gpu: VM_BIND locking document

Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gpu-vmas. Intention is to be using the same nomenclature as the drm-vm

Re: [Intel-xe] [PATCH v5] Documentation/gpu: VM_BIND locking document

On Tue, Nov 28, 2023 at 04:51:25PM +0100, Thomas Hellström wrote: > On Mon, 2023-11-27 at 14:36 -0500, Rodrigo Vivi wrote: > > On Tue, Nov 21, 2023 at 11:40:46AM +0100, Thomas Hellström wrote: > > > Add the first version of the VM_BIND locking document which is > > > in

Re: [Intel-xe] [PATCH v5] Documentation/gpu: VM_BIND locking document

On Mon, 2023-11-27 at 14:36 -0500, Rodrigo Vivi wrote: > On Tue, Nov 21, 2023 at 11:40:46AM +0100, Thomas Hellström wrote: > > Add the first version of the VM_BIND locking document which is > > intended to be part of the xe driver upstreaming agreement. > > > > The doc

Re: [PATCH v5] Documentation/gpu: VM_BIND locking document

On 11/22/23 08:49, Thomas Hellström wrote: On 11/21/23 14:56, Boris Brezillon wrote: On Tue, 21 Nov 2023 11:40:46 +0100 Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes

Re: [Intel-xe] [PATCH v5] Documentation/gpu: VM_BIND locking document

On Tue, Nov 21, 2023 at 11:40:46AM +0100, Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions,

Re: [PATCH v5] Documentation/gpu: VM_BIND locking document

On 11/21/23 14:56, Boris Brezillon wrote: On Tue, 21 Nov 2023 11:40:46 +0100 Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec

Re: [PATCH v5] Documentation/gpu: VM_BIND locking document

On Tue, 21 Nov 2023 11:40:46 +0100 Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions, evicton and

Re: [PATCH v5] Documentation/gpu: VM_BIND locking document

On Tue, Nov 21, 2023 at 11:40:46AM +0100, Thomas Hellström wrote: > diff --git a/Documentation/gpu/drm-vm-bind-locking.rst > b/Documentation/gpu/drm-vm-bind-locking.rst > new file mode 100644 > index ..a7d08eccd50e > --- /dev/null > +++ b/Documentation/gpu/drm-vm-bind-locking.rst > @@

[PATCH v5] Documentation/gpu: VM_BIND locking document

Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gpu-vmas. Intention is to be using the same nomenclature as the drm-vm

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

Hi, Boris On 11/16/23 15:47, Boris Brezillon wrote: On Thu, 16 Nov 2023 14:53:50 +0100 Thomas Hellström wrote: On Thu, 2023-11-16 at 14:27 +0100, Boris Brezillon wrote: On Thu, 16 Nov 2023 12:48:45 +0100 Thomas Hellström wrote: Hi, Boris, Thanks for reviewing. Some comments below: I'

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

Hi, On 11/16/23 14:13, Bagas Sanjaya wrote: On Wed, Nov 15, 2023 at 01:49:37PM +0100, Thomas Hellström wrote: +TODO: Pointer to the gpuvm code implementation if this iteration and "... implementation of this iteration ..." +Using a MMU notifier for device DMA (and other methods) is describe

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

, 2023-11-16 at 10:48 +0100, Boris Brezillon wrote: Hi Thomas, On Wed, 15 Nov 2023 13:49:37 +0100 Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

ome comments below: > > > > > > On Thu, 2023-11-16 at 10:48 +0100, Boris Brezillon wrote: > > > > Hi Thomas, > > > > > > > > On Wed, 15 Nov 2023 13:49:37 +0100 > > > > Thomas Hellström wrote: > > > >   >

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

On Thu, 2023-11-16 at 15:02 +0100, Danilo Krummrich wrote: > On 11/16/23 12:48, Thomas Hellström wrote: > > > > > > > +Locks used and locking orders > > > > += > > > > + > > > > +One of the benefits of VM_BIND is that local GEM objects share > > > > the > > > > gpu_vm

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

On 11/16/23 12:48, Thomas Hellström wrote: +Locks used and locking orders += + +One of the benefits of VM_BIND is that local GEM objects share the gpu_vm's +dma_resv object and hence the dma_resv lock. So even with a huge +number of local GEM objects, only one lock

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

e: > > > Hi Thomas, > > > > > > On Wed, 15 Nov 2023 13:49:37 +0100 > > > Thomas Hellström wrote: > > >   > > > > Add the first version of the VM_BIND locking document which is > > > > intended to be part of the xe driver ups

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

Hellström wrote: > > > > > Add the first version of the VM_BIND locking document which is > > > intended to be part of the xe driver upstreaming agreement. > > > > > > The document describes and discuss the locking used during exec- > > >

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

On Wed, Nov 15, 2023 at 01:49:37PM +0100, Thomas Hellström wrote: > +TODO: Pointer to the gpuvm code implementation if this iteration and "... implementation of this iteration ..." > +Using a MMU notifier for device DMA (and other methods) is described in > +`this document > +

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

Hi, Boris, Thanks for reviewing. Some comments below: On Thu, 2023-11-16 at 10:48 +0100, Boris Brezillon wrote: > Hi Thomas, > > On Wed, 15 Nov 2023 13:49:37 +0100 > Thomas Hellström wrote: > > > Add the first version of the VM_BIND locking document which is > > in

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

Hi Thomas, On Wed, 15 Nov 2023 13:49:37 +0100 Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions,

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

On 11/15/23 18:02, Danilo Krummrich wrote: On 11/15/23 17:04, Thomas Hellström wrote: Hi, Danilo, On Wed, 2023-11-15 at 16:11 +0100, Danilo Krummrich wrote: On Wed, Nov 15, 2023 at 01:49:37PM +0100, Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

On 11/15/23 17:04, Thomas Hellström wrote: Hi, Danilo, On Wed, 2023-11-15 at 16:11 +0100, Danilo Krummrich wrote: On Wed, Nov 15, 2023 at 01:49:37PM +0100, Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

Hi, Danilo, On Wed, 2023-11-15 at 16:11 +0100, Danilo Krummrich wrote: > On Wed, Nov 15, 2023 at 01:49:37PM +0100, Thomas Hellström wrote: > > Add the first version of the VM_BIND locking document which is > > intended to be part of the xe driver upstreaming agreement. > &

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

On Wed, Nov 15, 2023 at 01:49:37PM +0100, Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions,

[PATCH v4] Documentation/gpu: VM_BIND locking document

Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gpu-vmas. Intention is to be using the same nomenclature as the drm-vm

Re: [Intel-xe] [PATCH v3] Documentation/gpu: VM_BIND locking document

Hi, Rodrigo On 11/1/23 21:11, Rodrigo Vivi wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gpu-vmas. Intention

VM_BIND locking document

Danilo, Boris As you might know we have a task to complete a VM_BIND locking document including userptr gating the Xe driver upstreaming. I have version 3 of that document out as a patch https://patchwork.freedesktop.org/series/122508/ updated with the latest gpuvm changes, including the

Re: [Intel-xe] [PATCH v3] Documentation/gpu: VM_BIND locking document

On Sun, Oct 22, 2023 at 08:02:36PM +0200, Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions,

Re: [Intel-xe] [PATCH v3] Documentation/gpu: VM_BIND locking document

On Sun, Oct 22, 2023 at 08:02:36PM +0200, Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions,

[PATCH v3] Documentation/gpu: VM_BIND locking document

Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gpu-vmas. Intention is to be using the same nomenclature as the drm-vm

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

Hi, Boris On 9/6/23 16:54, Boris Brezillon wrote: Hi Thomas, On Wed, 6 Sep 2023 16:08:07 +0200 Thomas Hellström wrote: Hi, Boris, On 9/6/23 15:00, Boris Brezillon wrote: On Wed, 6 Sep 2023 13:57:03 +0200 Thomas Hellström wrote: Hi, Boris On 9/6/23 13:09, Boris Brezillon wrote: On We

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

Hi Thomas, On Wed, 6 Sep 2023 16:08:07 +0200 Thomas Hellström wrote: > Hi, Boris, > > On 9/6/23 15:00, Boris Brezillon wrote: > > On Wed, 6 Sep 2023 13:57:03 +0200 > > Thomas Hellström wrote: > > > >> Hi, Boris > >> > >> On 9/6/23 13:09, Boris Brezillon wrote: > >>> On Wed, 6 Sep 2023 10:3

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

Hi, Boris, On 9/6/23 15:00, Boris Brezillon wrote: On Wed, 6 Sep 2023 13:57:03 +0200 Thomas Hellström wrote: Hi, Boris On 9/6/23 13:09, Boris Brezillon wrote: On Wed, 6 Sep 2023 10:32:24 +0200 Thomas Hellström wrote: +Introducing external (or shared) buffer objects +==

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

On Wed, 6 Sep 2023 13:57:03 +0200 Thomas Hellström wrote: > Hi, Boris > > On 9/6/23 13:09, Boris Brezillon wrote: > > On Wed, 6 Sep 2023 10:32:24 +0200 > > Thomas Hellström wrote: > > > > > >> +Introducing external (or shared) buffer objects > >> +=

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

Hi, Boris On 9/6/23 13:09, Boris Brezillon wrote: On Wed, 6 Sep 2023 10:32:24 +0200 Thomas Hellström wrote: +Introducing external (or shared) buffer objects +=== + +Since shared buffer objects may be shared by multiple gpu_vm's they +can't share th

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

On Wed, 6 Sep 2023 10:32:24 +0200 Thomas Hellström wrote: > +Introducing external (or shared) buffer objects > +=== > + > +Since shared buffer objects may be shared by multiple gpu_vm's they > +can't share their reservation obj

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

On 9/6/23 10:00, Danilo Krummrich wrote: On 9/6/23 09:06, Thomas Hellström wrote: Hi, Danilo, Thanks for taking a look. Comments inline. On 9/5/23 21:50, Danilo Krummrich wrote: On Wed, Aug 16, 2023 at 11:15:47AM +0200, Thomas Hellström wrote: Add the first version of the VM_BIND locking

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

On 9/6/23 09:06, Thomas Hellström wrote: Hi, Danilo, Thanks for taking a look. Comments inline. On 9/5/23 21:50, Danilo Krummrich wrote: On Wed, Aug 16, 2023 at 11:15:47AM +0200, Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

Hi, Danilo, Thanks for taking a look. Comments inline. On 9/5/23 21:50, Danilo Krummrich wrote: On Wed, Aug 16, 2023 at 11:15:47AM +0200, Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

On Wed, Aug 16, 2023 at 11:15:47AM +0200, Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions,

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

On Wed, Aug 16, 2023 at 11:15:47AM +0200, Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions,

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Hellstr-m/Documentation-gpu-VM_BIND-locking-document/20230816-171911 base: git://anongit.freed

[PATCH v2] Documentation/gpu: VM_BIND locking document

Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gpu-vmas. Intention is to be using the same nomenclature as the drm-vm

Re: [Intel-xe] [RFC PATCH] Documentation/gpu: Draft VM_BIND locking document

Thanks for reviewing, Rodrigo! On 8/4/23 22:15, Rodrigo Vivi wrote: On Fri, Jun 30, 2023 at 06:44:52PM +0200, Thomas Hellström wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss

Re: [Intel-xe] [RFC PATCH] Documentation/gpu: Draft VM_BIND locking document

On Fri, Jun 30, 2023 at 06:44:52PM +0200, Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions,

[RFC PATCH] Documentation/gpu: Draft VM_BIND locking document

Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gmvas. Intention is to be using the same nomenclature as the drm-vm-bind