Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-09 Thread Byungchul Park
On Sun, Mar 06, 2022 at 09:19:10AM -0500, Theodore Ts'o wrote: > On Sun, Mar 06, 2022 at 07:51:42PM +0900, Byungchul Park wrote: > > > > > > Users of DEPT must not have to understand how DEPT works in order to > > > > Users must not have to understand how Dept works for sure, and haters > > must

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-07 Thread Reimar Döffinger
Hi, Sorry to butt in as an outsider, but this seems like a shockingly disrespectful discussion for such a wide CC list. I don't want to make rules how you discuss things (I very rarely contribute), and I see the value in a frank discussion, but maybe you could continue with a reduced CC list? I

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-07 Thread Joel Fernandes
On Sat, Mar 05, 2022 at 11:15:38PM +0900, Byungchul Park wrote: > On Fri, Mar 04, 2022 at 10:26:23PM -0500, Theodore Ts'o wrote: > > On Fri, Mar 04, 2022 at 09:42:37AM +0900, Byungchul Park wrote: > > > > > > All contexts waiting for any of the events in the circular dependency > > > chain will be

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-06 Thread Byungchul Park
On Sat, Mar 05, 2022 at 03:05:23PM +, Joel Fernandes wrote: > On Sat, Mar 05, 2022 at 11:15:38PM +0900, Byungchul Park wrote: > > Almost all you've been blaming at Dept are totally non-sense. Based on > > what you're saying, I'm conviced that you don't understand how Dept > > works even 1%. You

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-06 Thread Theodore Ts'o
On Sun, Mar 06, 2022 at 07:51:42PM +0900, Byungchul Park wrote: > > > > Users of DEPT must not have to understand how DEPT works in order to > > Users must not have to understand how Dept works for sure, and haters > must not blame things based on what they guess wrong. For the record, I don't h

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-06 Thread Byungchul Park
Ted wrote: > On Sat, Mar 05, 2022 at 11:55:34PM +0900, Byungchul Park wrote: > > > that is why some of the DEPT reports were completely incomprehensible > > > > It's because you are blinded to blame at it without understanding how > > Dept works at all. I will fix those that must be fixed. Don't w

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-05 Thread Theodore Ts'o
On Sat, Mar 05, 2022 at 11:55:34PM +0900, Byungchul Park wrote: > > that is why some of the DEPT reports were completely incomprehensible > > It's because you are blinded to blame at it without understanding how > Dept works at all. I will fix those that must be fixed. Don't worry. Users of DEPT

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-05 Thread Byungchul Park
On Fri, Mar 04, 2022 at 10:40:35PM -0500, Theodore Ts'o wrote: > On Fri, Mar 04, 2022 at 12:20:02PM +0900, Byungchul Park wrote: > > > > I found a point that the two wait channels don't lead a deadlock in > > some cases thanks to Jan Kara. I will fix it so that Dept won't > > complain it. > > I s

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-05 Thread Byungchul Park
On Fri, Mar 04, 2022 at 10:26:23PM -0500, Theodore Ts'o wrote: > On Fri, Mar 04, 2022 at 09:42:37AM +0900, Byungchul Park wrote: > > > > All contexts waiting for any of the events in the circular dependency > > chain will be definitely stuck if there is a circular dependency as I > > explained. So

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-04 Thread Theodore Ts'o
On Fri, Mar 04, 2022 at 12:20:02PM +0900, Byungchul Park wrote: > > I found a point that the two wait channels don't lead a deadlock in > some cases thanks to Jan Kara. I will fix it so that Dept won't > complain it. I sent my last (admittedly cranky) message before you sent this. I'm glad you f

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-04 Thread Theodore Ts'o
On Fri, Mar 04, 2022 at 09:42:37AM +0900, Byungchul Park wrote: > > All contexts waiting for any of the events in the circular dependency > chain will be definitely stuck if there is a circular dependency as I > explained. So we need another wakeup source to break the circle. In > ext4 code, you m

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-03 Thread Byungchul Park
On Thu, Mar 03, 2022 at 09:36:25AM -0500, Theodore Ts'o wrote: > On Thu, Mar 03, 2022 at 02:23:33PM +0900, Byungchul Park wrote: > > I totally agree with you. *They aren't really locks but it's just waits > > and wakeups.* That's exactly why I decided to develop Dept. Dept is not > > interested in

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-03 Thread Byungchul Park
On Thu, Mar 03, 2022 at 10:54:56AM +0100, Jan Kara wrote: > On Thu 03-03-22 10:00:33, Byungchul Park wrote: > > Unfortunately, it's neither perfect nor safe without another wakeup > > source - rescue wakeup source. > > > >consumer producer > > > > l

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-03 Thread Byungchul Park
On Thu, Mar 03, 2022 at 09:36:25AM -0500, Theodore Ts'o wrote: > On Thu, Mar 03, 2022 at 02:23:33PM +0900, Byungchul Park wrote: > > I totally agree with you. *They aren't really locks but it's just waits > > and wakeups.* That's exactly why I decided to develop Dept. Dept is not > > interested in

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-03 Thread Theodore Ts'o
On Thu, Mar 03, 2022 at 02:23:33PM +0900, Byungchul Park wrote: > I totally agree with you. *They aren't really locks but it's just waits > and wakeups.* That's exactly why I decided to develop Dept. Dept is not > interested in locks unlike Lockdep, but fouces on waits and wakeup > sources itself.

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-03 Thread Jan Kara
On Thu 03-03-22 10:00:33, Byungchul Park wrote: > On Mon, Feb 28, 2022 at 11:14:44AM +0100, Jan Kara wrote: > > On Mon 28-02-22 18:28:26, Byungchul Park wrote: > > > case 1. Code with an actual circular dependency, but not deadlock. > > > > > >A circular dependency can be broken by a rescue wa

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-02 Thread Byungchul Park
Ted wrote: > On Thu, Mar 03, 2022 at 10:00:33AM +0900, Byungchul Park wrote: > > > > Unfortunately, it's neither perfect nor safe without another wakeup > > source - rescue wakeup source. > > > >consumer producer > > > > lock L > >

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-02 Thread Theodore Ts'o
On Thu, Mar 03, 2022 at 10:00:33AM +0900, Byungchul Park wrote: > > Unfortunately, it's neither perfect nor safe without another wakeup > source - rescue wakeup source. > >consumer producer > > lock L > (too much w

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-02 Thread Byungchul Park
On Mon, Feb 28, 2022 at 04:25:04PM -0500, Theodore Ts'o wrote: > On Mon, Feb 28, 2022 at 11:14:44AM +0100, Jan Kara wrote: > > > case 1. Code with an actual circular dependency, but not deadlock. > > > > > >A circular dependency can be broken by a rescue wakeup source e.g. > > >timeout. It

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-02 Thread Byungchul Park
On Mon, Feb 28, 2022 at 11:14:44AM +0100, Jan Kara wrote: > On Mon 28-02-22 18:28:26, Byungchul Park wrote: > > case 1. Code with an actual circular dependency, but not deadlock. > > > >A circular dependency can be broken by a rescue wakeup source e.g. > >timeout. It's not a deadlock. If i

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-02-28 Thread Theodore Ts'o
On Mon, Feb 28, 2022 at 11:14:44AM +0100, Jan Kara wrote: > > case 1. Code with an actual circular dependency, but not deadlock. > > > >A circular dependency can be broken by a rescue wakeup source e.g. > >timeout. It's not a deadlock. If it's okay that the contexts > >participating in

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-02-28 Thread Jan Kara
On Mon 28-02-22 18:28:26, Byungchul Park wrote: > On Thu, Feb 24, 2022 at 11:22:39AM +0100, Jan Kara wrote: > > On Thu 24-02-22 10:11:02, Byungchul Park wrote: > > > On Wed, Feb 23, 2022 at 03:48:59PM +0100, Jan Kara wrote: > > > > > KJOURNALD2(kthread) TASK1(ksys_write) TASK2(ksys_write) >

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-02-28 Thread Byungchul Park
On Thu, Feb 24, 2022 at 11:22:39AM +0100, Jan Kara wrote: > On Thu 24-02-22 10:11:02, Byungchul Park wrote: > > On Wed, Feb 23, 2022 at 03:48:59PM +0100, Jan Kara wrote: > > > > KJOURNALD2(kthread) TASK1(ksys_write) TASK2(ksys_write) > > > > > > > > wait A > > > > --- stuck > > > >

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-02-24 Thread Jan Kara
On Thu 24-02-22 10:11:02, Byungchul Park wrote: > On Wed, Feb 23, 2022 at 03:48:59PM +0100, Jan Kara wrote: > > > KJOURNALD2(kthread) TASK1(ksys_write) TASK2(ksys_write) > > > > > > wait A > > > --- stuck > > > wait B > > > --- stuck > > >

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-02-23 Thread Byungchul Park
On Wed, Feb 23, 2022 at 03:48:59PM +0100, Jan Kara wrote: > On Wed 23-02-22 09:35:34, Byungchul Park wrote: > > On Mon, Feb 21, 2022 at 08:02:04PM +0100, Jan Kara wrote: > > > On Thu 17-02-22 20:10:04, Byungchul Park wrote: > > > > [9.008161] ===

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-02-23 Thread Jan Kara
On Wed 23-02-22 09:35:34, Byungchul Park wrote: > On Mon, Feb 21, 2022 at 08:02:04PM +0100, Jan Kara wrote: > > On Thu 17-02-22 20:10:04, Byungchul Park wrote: > > > [9.008161] === > > > [9.008163] DEPT: Circular dependency has been detected.

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-02-22 Thread Byungchul Park
On Mon, Feb 21, 2022 at 08:02:04PM +0100, Jan Kara wrote: > On Thu 17-02-22 20:10:04, Byungchul Park wrote: > > [9.008161] === > > [9.008163] DEPT: Circular dependency has been detected. > > [9.008164] 5.17.0-rc1-00015-gb94f67143867-dirty

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-02-21 Thread Jan Kara
So I was trying to understand what this report is about for some time but honestly I have failed... On Thu 17-02-22 20:10:04, Byungchul Park wrote: > [9.008161] === > [9.008163] DEPT: Circular dependency has been detected. > [9.008164]

Report 2 in ext4 and journal based on v5.17-rc1

2022-02-19 Thread Byungchul Park
[9.008161] === [9.008163] DEPT: Circular dependency has been detected. [9.008164] 5.17.0-rc1-00015-gb94f67143867-dirty #2 Tainted: GW [9.008166] --- [9.008167] summary [9.