Re: bug report: potential integer overflow in validate_exec_list()

2010-11-22 Thread Chris Wilson
On Mon, 22 Nov 2010 12:56:42 +0300, Dan Carpenter wrote: > On Sun, Nov 21, 2010 at 09:23:46AM +, Chris Wilson wrote: > > Yes, it could. Not through normal use since relocation count can not be > > more than buffer length, hence realistically capped at around 4k entries. > > However... > > >

Re: bug report: potential integer overflow in validate_exec_list()

2010-11-22 Thread Dan Carpenter
On Sun, Nov 21, 2010 at 09:23:46AM +, Chris Wilson wrote: > On Sat, 20 Nov 2010 21:32:07 +0300, Dan Carpenter wrote: > > Hello Chris, > > > > Is there an integer overflow in validate_exec_list()? > > > > drivers/gpu/drm/i915/i915_gem.c > > 3633 size_t length = exec[i].relocation_c

Re: bug report: potential integer overflow in validate_exec_list()

2010-11-21 Thread Chris Wilson
On Sat, 20 Nov 2010 21:32:07 +0300, Dan Carpenter wrote: > Hello Chris, > > Is there an integer overflow in validate_exec_list()? > > drivers/gpu/drm/i915/i915_gem.c > 3633 size_t length = exec[i].relocation_count * sizeof(struct > drm_i915_gem_relocation_entry); > 3634 > 3635