Re: Fix for vblank on nvc0

2012-11-15 Thread Sven Joachim
On 2012-11-12 22:52 +0100, Maarten Lankhorst wrote: > Op 12-11-12 22:30, Kelly Doran schreef: >> I had Sven test this patch... he said it works. I think chipset >> number test was executing code that we thought was only either 0x50 or >> 0xc0, but was actually more specific with things like 0x92.

Re: Fix for vblank on nvc0

2012-11-12 Thread Kelly Doran
I had Sven test this patch... he said it works. I think chipset number test was executing code that we thought was only either 0x50 or 0xc0, but was actually more specific with things like 0x92. On Sun, Nov 11, 2012 at 2:25 PM, Maarten Lankhorst wrote: > Op 11-11-12 19:35, Marcin Slusarz schreef

Re: Fix for vblank on nvc0

2012-11-12 Thread Marcin Slusarz
On Mon, Nov 12, 2012 at 06:14:05AM -0600, Kelly Doran wrote: > Okay I have added two patches, one of them should fix the problem... > vblank-fix1.patch works, thanks. Marcin ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freede

Re: Fix for vblank on nvc0

2012-11-12 Thread Maarten Lankhorst
Op 12-11-12 22:30, Kelly Doran schreef: > I had Sven test this patch... he said it works. I think chipset > number test was executing code that we thought was only either 0x50 or > 0xc0, but was actually more specific with things like 0x92. > Oh right vblank is busted anyway... needs to be nv_devi

Re: Fix for vblank on nvc0

2012-11-12 Thread Sven Joachim
On 2012-11-11 21:25 +0100, Maarten Lankhorst wrote: > Op 11-11-12 19:35, Marcin Slusarz schreef: >> On Sun, Nov 11, 2012 at 07:26:17PM +0100, Marcin Slusarz wrote: >>> On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote: Op 06-11-12 15:48, Kelly Doran schreef: > The vbl

Re: Fix for vblank on nvc0

2012-11-12 Thread Kelly Doran
Okay I have added two patches, one of them should fix the problem... On Sun, Nov 11, 2012 at 12:51 PM, Kelly Doran wrote: > I was under the impression that the "else" block was only executed for nvc0 > code, but maybe the nv92 code was executing it too, so that may need an > extra code block to w

Re: Fix for vblank on nvc0

2012-11-12 Thread Kelly Doran
I was under the impression that the "else" block was only executed for nvc0 code, but maybe the nv92 code was executing it too, so that may need an extra code block to work again. Otherwise the bar flush in the nv50 section is causing the problems... I can write up some patches later if you want

Re: Fix for vblank on nvc0

2012-11-11 Thread Maarten Lankhorst
Op 11-11-12 19:35, Marcin Slusarz schreef: > On Sun, Nov 11, 2012 at 07:26:17PM +0100, Marcin Slusarz wrote: >> On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote: >>> >>> Op 06-11-12 15:48, Kelly Doran schreef: The vblank on nvc0 was not working correctly and would freeze X, I

Re: Fix for vblank on nvc0

2012-11-11 Thread Marcin Slusarz
On Sun, Nov 11, 2012 at 07:26:17PM +0100, Marcin Slusarz wrote: > On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote: > > > > > > Op 06-11-12 15:48, Kelly Doran schreef: > > > The vblank on nvc0 was not working correctly and would freeze X, I managed > > > to track it down and fix

Re: Fix for vblank on nvc0

2012-11-11 Thread Marcin Slusarz
On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote: > > > Op 06-11-12 15:48, Kelly Doran schreef: > > The vblank on nvc0 was not working correctly and would freeze X, I managed > > to track it down and fix it with some help from m.b.lankhorst, see > > https://bugs.freedesktop.org/s

Re: Fix for vblank on nvc0

2012-11-06 Thread Maarten Lankhorst
Op 06-11-12 15:48, Kelly Doran schreef: > The vblank on nvc0 was not working correctly and would freeze X, I managed > to track it down and fix it with some help from m.b.lankhorst, see > https://bugs.freedesktop.org/show_bug.cgi?id=56692 for details. > Reviewed-by: Maarten Lankhorst I recommen