Re: [net-next v1 06/16] netdev: support binding dma-buf to netdevice

2023-12-10 Thread Mina Almasry
On Sat, Dec 9, 2023 at 3:29 PM David Ahern wrote: > > On 12/8/23 12:22 PM, Mina Almasry wrote: > > On Fri, Dec 8, 2023 at 9:48 AM David Ahern wrote: > >> > >> On 12/7/23 5:52 PM, Mina Almasry wrote: > > ... > >>> + > >>> + xa_for_each(&binding->bound_rxq_list, xa_idx, rxq) { > >>> +

Re: [net-next v1 06/16] netdev: support binding dma-buf to netdevice

2023-12-09 Thread David Ahern
On 12/8/23 12:22 PM, Mina Almasry wrote: > On Fri, Dec 8, 2023 at 9:48 AM David Ahern wrote: >> >> On 12/7/23 5:52 PM, Mina Almasry wrote: > ... >>> + >>> + xa_for_each(&binding->bound_rxq_list, xa_idx, rxq) { >>> + if (rxq->binding == binding) { >>> + /* We hol

Re: [net-next v1 06/16] netdev: support binding dma-buf to netdevice

2023-12-08 Thread Mina Almasry
On Fri, Dec 8, 2023 at 11:22 AM Mina Almasry wrote: > > On Fri, Dec 8, 2023 at 9:48 AM David Ahern wrote: > > > > On 12/7/23 5:52 PM, Mina Almasry wrote: > ... > > > + > > > + xa_for_each(&binding->bound_rxq_list, xa_idx, rxq) { > > > + if (rxq->binding == binding) { > > > +

Re: [net-next v1 06/16] netdev: support binding dma-buf to netdevice

2023-12-08 Thread Mina Almasry
On Fri, Dec 8, 2023 at 9:48 AM David Ahern wrote: > > On 12/7/23 5:52 PM, Mina Almasry wrote: ... > > + > > + xa_for_each(&binding->bound_rxq_list, xa_idx, rxq) { > > + if (rxq->binding == binding) { > > + /* We hold the rtnl_lock while binding/unbinding > > +

Re: [net-next v1 06/16] netdev: support binding dma-buf to netdevice

2023-12-08 Thread David Ahern
On 12/7/23 5:52 PM, Mina Almasry wrote: > + > +static int netdev_restart_rx_queue(struct net_device *dev, int rxq_idx) > +{ > + void *new_mem; > + void *old_mem; > + int err; > + > + if (!dev || !dev->netdev_ops) > + return -EINVAL; > + > + if (!dev->netdev_ops->ndo_

Re: [net-next v1 06/16] netdev: support binding dma-buf to netdevice

2023-12-08 Thread kernel test robot
Hi Mina, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Mina-Almasry/net-page_pool-factor-out-releasing-DMA-from-releasing-the-page/20231208-085531 base: net-next/main patch link: ht

Re: [net-next v1 06/16] netdev: support binding dma-buf to netdevice

2023-12-08 Thread kernel test robot
Hi Mina, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Mina-Almasry/net-page_pool-factor-out-releasing-DMA-from-releasing-the-page/20231208-085531 base: net-next/main patch link: ht