Re: [RFC PATCH v2 15/17] drm/tegra: Add power_on/power_off engine callbacks

2020-09-09 Thread Mikko Perttunen
On 9/9/20 3:16 AM, Dmitry Osipenko wrote: 05.09.2020 13:34, Mikko Perttunen пишет: ... +static int vic_power_on(struct tegra_drm_client *client) +{ + struct vic *vic = to_vic(client); + + return pm_runtime_get_sync(vic->dev); Please keep in mind that RPM needs to be put in a case o

Re: [RFC PATCH v2 15/17] drm/tegra: Add power_on/power_off engine callbacks

2020-09-09 Thread Dmitry Osipenko
05.09.2020 13:34, Mikko Perttunen пишет: ... > +static int vic_power_on(struct tegra_drm_client *client) > +{ > + struct vic *vic = to_vic(client); > + > + return pm_runtime_get_sync(vic->dev); Please keep in mind that RPM needs to be put in a case of error. Maybe it would be better if dr