Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-06-21 Thread Dmitry Osipenko
On Wednesday, 20 June 2018 13:10:07 MSK Daniel Vetter wrote: > On Wed, Jun 20, 2018 at 11:33 AM, Russell King - ARM Linux > > wrote: > > On Wed, Jun 20, 2018 at 11:17:50AM +0200, Daniel Vetter wrote: > >> Yes -modesetting (or whichever other driver) would need to set up the > >> properties correc

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-06-21 Thread Russell King - ARM Linux
On Wed, Jun 20, 2018 at 11:17:50AM +0200, Daniel Vetter wrote: > Yes -modesetting (or whichever other driver) would need to set up the > properties correctly for Xvideo color keying. Since default assumption for > all other (generic) compositors is that planes won't do any color keying > in the boo

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-06-21 Thread Dmitry Osipenko
On Tuesday, 19 June 2018 20:40:12 MSK Russell King - ARM Linux wrote: > On Tue, May 29, 2018 at 10:11:03AM +0300, Ville Syrjälä wrote: > > On Tue, May 29, 2018 at 02:48:22AM +0300, Dmitry Osipenko wrote: > > > Though maybe "color components replacement" and "replacement with a > > > complete transp

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-06-20 Thread Daniel Vetter
On Wed, Jun 20, 2018 at 11:33 AM, Russell King - ARM Linux wrote: > On Wed, Jun 20, 2018 at 11:17:50AM +0200, Daniel Vetter wrote: >> Yes -modesetting (or whichever other driver) would need to set up the >> properties correctly for Xvideo color keying. Since default assumption for >> all other (ge

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-06-20 Thread Daniel Vetter
On Tue, Jun 19, 2018 at 06:40:12PM +0100, Russell King - ARM Linux wrote: > On Tue, May 29, 2018 at 10:11:03AM +0300, Ville Syrjälä wrote: > > On Tue, May 29, 2018 at 02:48:22AM +0300, Dmitry Osipenko wrote: > > > Though maybe "color components replacement" and "replacement with a > > > complete >

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-06-20 Thread Russell King - ARM Linux
On Tue, May 29, 2018 at 10:11:03AM +0300, Ville Syrjälä wrote: > On Tue, May 29, 2018 at 02:48:22AM +0300, Dmitry Osipenko wrote: > > Though maybe "color components replacement" and "replacement with a complete > > transparency" could be factored out into a specific color keying modes. > > Yes. I'

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-06-03 Thread Dmitry Osipenko
On 29.05.2018 10:17, Ville Syrjälä wrote: > On Sat, May 26, 2018 at 06:56:22PM +0300, Dmitry Osipenko wrote: >> Color keying is the action of replacing pixels matching a given color >> (or range of colors) with transparent pixels in an overlay when >> performing blitting. Depending on the hardware

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-29 Thread Ville Syrjälä
On Sat, May 26, 2018 at 06:56:22PM +0300, Dmitry Osipenko wrote: > Color keying is the action of replacing pixels matching a given color > (or range of colors) with transparent pixels in an overlay when > performing blitting. Depending on the hardware capabilities, the > matching pixel can either b

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-29 Thread Dmitry Osipenko
On 29.05.2018 02:48, Dmitry Osipenko wrote: > inversion=true" if mask has form of 0x11000111, though this could be not For clarity: I meant s/0x11000111/0xFF000FFF/. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-29 Thread Dmitry Osipenko
On 28.05.2018 16:15, Ville Syrjälä wrote: > On Sat, May 26, 2018 at 06:56:22PM +0300, Dmitry Osipenko wrote: >> Color keying is the action of replacing pixels matching a given color >> (or range of colors) with transparent pixels in an overlay when >> performing blitting. Depending on the hardware

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-29 Thread Ville Syrjälä
On Tue, May 29, 2018 at 02:48:22AM +0300, Dmitry Osipenko wrote: > On 28.05.2018 16:15, Ville Syrjälä wrote: > > On Sat, May 26, 2018 at 06:56:22PM +0300, Dmitry Osipenko wrote: > >> Color keying is the action of replacing pixels matching a given color > >> (or range of colors) with transparent pix

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-28 Thread Ville Syrjälä
On Sat, May 26, 2018 at 06:56:22PM +0300, Dmitry Osipenko wrote: > Color keying is the action of replacing pixels matching a given color > (or range of colors) with transparent pixels in an overlay when > performing blitting. Depending on the hardware capabilities, the > matching pixel can either b

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-27 Thread Dmitry Osipenko
On 26.05.2018 19:18, Laurent Pinchart wrote: > On Saturday, 26 May 2018 19:16:54 EEST Laurent Pinchart wrote: >> Hi Dimitri, > > And sorry for the spelling mistake :-/ That's also a kinda correct spelling. No worries ;) ___ dri-devel mailing list dri-de

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-27 Thread Dmitry Osipenko
On 26.05.2018 19:16, Laurent Pinchart wrote: > Hi Dimitri, > > Thank you for the patch. > > I'll review this in details, but as this patch is based on the "[PATCH/RFC > 1/4] drm: Add colorkey properties" patch I've submitted, please retain the > authorship, both in the Signed-off-by line, and i

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-26 Thread Laurent Pinchart
On Saturday, 26 May 2018 19:16:54 EEST Laurent Pinchart wrote: > Hi Dimitri, And sorry for the spelling mistake :-/ > Thank you for the patch. > > I'll review this in details, but as this patch is based on the "[PATCH/RFC > 1/4] drm: Add colorkey properties" patch I've submitted, please retain t

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-26 Thread Laurent Pinchart
Hi Dimitri, Thank you for the patch. I'll review this in details, but as this patch is based on the "[PATCH/RFC 1/4] drm: Add colorkey properties" patch I've submitted, please retain the authorship, both in the Signed-off-by line, and in the patch author in git. On Saturday, 26 May 2018 18:56: