Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-10 Thread Danilo Krummrich
On Sat, Jun 08, 2024 at 08:28:06AM +0900, FUJITA Tomonori wrote: > On Fri, 7 Jun 2024 19:55:49 +0200 > Danilo Krummrich wrote: > > > On Fri, Jun 07, 2024 at 05:41:11PM +0200, Greg KH wrote: > >> On Fri, Jun 07, 2024 at 03:33:39PM +0200, Danilo Krummrich wrote: > >> > On Fri, Jun 07, 2024 at 02:36

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread FUJITA Tomonori
On Fri, 7 Jun 2024 19:55:49 +0200 Danilo Krummrich wrote: > On Fri, Jun 07, 2024 at 05:41:11PM +0200, Greg KH wrote: >> On Fri, Jun 07, 2024 at 03:33:39PM +0200, Danilo Krummrich wrote: >> > On Fri, Jun 07, 2024 at 02:36:50PM +0200, Greg KH wrote: >> > > Anyway, that's all hand-wavy right now, so

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Danilo Krummrich
On Fri, Jun 07, 2024 at 05:41:11PM +0200, Greg KH wrote: > On Fri, Jun 07, 2024 at 03:33:39PM +0200, Danilo Krummrich wrote: > > On Fri, Jun 07, 2024 at 02:36:50PM +0200, Greg KH wrote: > > > Anyway, that's all hand-wavy right now, sorry, to get back to the point > > > here, again, let's take this,

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Greg KH
On Fri, Jun 07, 2024 at 03:33:39PM +0200, Danilo Krummrich wrote: > On Fri, Jun 07, 2024 at 02:36:50PM +0200, Greg KH wrote: > > Anyway, that's all hand-wavy right now, sorry, to get back to the point > > here, again, let's take this, which will allow the firmware bindings to > > be resubmitted and

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Danilo Krummrich
On Fri, Jun 07, 2024 at 02:36:50PM +0200, Greg KH wrote: > Anyway, that's all hand-wavy right now, sorry, to get back to the point > here, again, let's take this, which will allow the firmware bindings to > be resubmitted and hopefully accepted, and we can move forward from > there to "real" things

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Danilo Krummrich
On Fri, Jun 07, 2024 at 02:36:50PM +0200, Greg KH wrote: > On Fri, Jun 07, 2024 at 09:11:32PM +0900, FUJITA Tomonori wrote: > > Hi, > > > > On Fri, 31 May 2024 11:59:47 +0200 > > Danilo Krummrich wrote: > > > > > Once we get to a conclusion I can send a series with only the device and > > > fir

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Danilo Krummrich
On Fri, Jun 07, 2024 at 09:11:32PM +0900, FUJITA Tomonori wrote: > Hi, > > On Fri, 31 May 2024 11:59:47 +0200 > Danilo Krummrich wrote: > > > Once we get to a conclusion I can send a series with only the device and > > firmare > > abstractions such that we can get them in outside of the scope o

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Greg KH
On Fri, Jun 07, 2024 at 09:11:32PM +0900, FUJITA Tomonori wrote: > Hi, > > On Fri, 31 May 2024 11:59:47 +0200 > Danilo Krummrich wrote: > > > Once we get to a conclusion I can send a series with only the device and > > firmare > > abstractions such that we can get them in outside of the scope o

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread FUJITA Tomonori
Hi, On Fri, 31 May 2024 11:59:47 +0200 Danilo Krummrich wrote: > Once we get to a conclusion I can send a series with only the device and > firmare > abstractions such that we can get them in outside of the scope of the reset of > both series to get your driver going. Since your discussion wit

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-31 Thread Danilo Krummrich
On Fri, May 31, 2024 at 04:50:32PM +0900, FUJITA Tomonori wrote: > On Thu, 30 May 2024 08:47:25 +0200 > Danilo Krummrich wrote: > > >> >> >> For a Rust PHY driver, you know that you have a valid pointer to C's > >> >> >> device object of C's PHY device during the probe callback. The driver > >> >

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-31 Thread FUJITA Tomonori
On Thu, 30 May 2024 08:47:25 +0200 Danilo Krummrich wrote: >> >> >> For a Rust PHY driver, you know that you have a valid pointer to C's >> >> >> device object of C's PHY device during the probe callback. The driver >> >> >> creates a Rust device object to wrap the C pointer to the C's device >>

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-29 Thread Danilo Krummrich
On Thu, May 30, 2024 at 01:24:33PM +0900, FUJITA Tomonori wrote: > Hi, > > On Thu, 30 May 2024 04:01:39 +0200 > Danilo Krummrich wrote: > > > On Thu, May 30, 2024 at 08:28:24AM +0900, FUJITA Tomonori wrote: > >> Hi, > >> > >> On Wed, 29 May 2024 21:57:03 +0200 > >> Greg KH wrote: > >> > >> >>

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-29 Thread FUJITA Tomonori
Hi, On Thu, 30 May 2024 04:01:39 +0200 Danilo Krummrich wrote: > On Thu, May 30, 2024 at 08:28:24AM +0900, FUJITA Tomonori wrote: >> Hi, >> >> On Wed, 29 May 2024 21:57:03 +0200 >> Greg KH wrote: >> >> >> For a Rust PHY driver, you know that you have a valid pointer to C's >> >> device object

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-29 Thread Danilo Krummrich
On Thu, May 30, 2024 at 08:28:24AM +0900, FUJITA Tomonori wrote: > Hi, > > On Wed, 29 May 2024 21:57:03 +0200 > Greg KH wrote: > > >> For a Rust PHY driver, you know that you have a valid pointer to C's > >> device object of C's PHY device during the probe callback. The driver > >> creates a Rus

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-29 Thread FUJITA Tomonori
Hi, On Wed, 29 May 2024 21:57:03 +0200 Greg KH wrote: >> For a Rust PHY driver, you know that you have a valid pointer to C's >> device object of C's PHY device during the probe callback. The driver >> creates a Rust device object to wrap the C pointer to the C's device >> object and passes it t

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-29 Thread Greg KH
On Wed, May 29, 2024 at 09:28:21AM +0900, FUJITA Tomonori wrote: > Hi, > > On Tue, 28 May 2024 14:45:02 +0200 > Greg KH wrote: > > > On Tue, May 28, 2024 at 02:19:24PM +0200, Danilo Krummrich wrote: > >> However, if you have a driver that needs the firmware abstractions, I > >> would be > >> su

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread FUJITA Tomonori
On Tue, 28 May 2024 14:19:24 +0200 Danilo Krummrich wrote: > On Tue, May 28, 2024 at 08:01:26PM +0900, FUJITA Tomonori wrote: >> On Mon, 27 May 2024 21:22:47 +0200 >> Danilo Krummrich wrote: >> >> >> > +/// Abstraction around a C firmware struct. >> >> > +/// >> >> > +/// This is a simple abstr

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread FUJITA Tomonori
Hi, On Tue, 28 May 2024 14:45:02 +0200 Greg KH wrote: > On Tue, May 28, 2024 at 02:19:24PM +0200, Danilo Krummrich wrote: >> However, if you have a driver that needs the firmware abstractions, I would >> be >> surprised if there were any hesitations to already merge the minimum device >> abstra

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Zhi Wang
On 28/05/2024 17.18, Danilo Krummrich wrote: > External email: Use caution opening links or attachments > > > On Tue, May 28, 2024 at 08:40:20AM +, Zhi Wang wrote: >> On 27/05/2024 22.18, Danilo Krummrich wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> On Tue,

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Danilo Krummrich
On Tue, May 28, 2024 at 08:40:20AM +, Zhi Wang wrote: > On 27/05/2024 22.18, Danilo Krummrich wrote: > > External email: Use caution opening links or attachments > > > > > > On Tue, May 21, 2024 at 08:32:31AM +0300, Zhi Wang wrote: > >> On Mon, 20 May 2024 19:24:19 +0200 > >> Danilo Krummrich

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Danilo Krummrich
On Tue, May 28, 2024 at 02:45:02PM +0200, Greg KH wrote: > On Tue, May 28, 2024 at 02:19:24PM +0200, Danilo Krummrich wrote: > > However, if you have a driver that needs the firmware abstractions, I would > > be > > surprised if there were any hesitations to already merge the minimum device > > ab

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Greg KH
On Tue, May 28, 2024 at 02:19:24PM +0200, Danilo Krummrich wrote: > However, if you have a driver that needs the firmware abstractions, I would be > surprised if there were any hesitations to already merge the minimum device > abstractions [1] and this one (once reviewed) without the rest. At least

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Danilo Krummrich
On Tue, May 28, 2024 at 08:01:26PM +0900, FUJITA Tomonori wrote: > On Mon, 27 May 2024 21:22:47 +0200 > Danilo Krummrich wrote: > > >> > +/// Abstraction around a C firmware struct. > >> > +/// > >> > +/// This is a simple abstraction around the C firmware API. Just like > >> > with the C API, f

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Danilo Krummrich
Hi Luis and Russ, I just noted I forgot to add you to this patch, sorry for that. Please find the full series and previous discussions in [1]. - Danilo [1] https://lore.kernel.org/rust-for-linux/20240520172059.181256-1-d...@redhat.com/ On Mon, May 20, 2024 at 07:24:19PM +0200, Danilo Krummric

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Zhi Wang
On 28/05/2024 13.17, FUJITA Tomonori wrote: > External email: Use caution opening links or attachments > > > Hi, > > On Tue, 28 May 2024 08:40:20 + > Zhi Wang wrote: > >> On 27/05/2024 22.18, Danilo Krummrich wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> O

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Zhi Wang
On 27/05/2024 22.18, Danilo Krummrich wrote: > External email: Use caution opening links or attachments > > > On Tue, May 21, 2024 at 08:32:31AM +0300, Zhi Wang wrote: >> On Mon, 20 May 2024 19:24:19 +0200 >> Danilo Krummrich wrote: >> >>> Add an abstraction around the kernels firmware API to re

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread FUJITA Tomonori
On Mon, 27 May 2024 21:22:47 +0200 Danilo Krummrich wrote: >> > +/// Abstraction around a C firmware struct. >> > +/// >> > +/// This is a simple abstraction around the C firmware API. Just like >> > with the C API, firmware can >> > +/// be requested. Once requested the abstraction provides dir

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread FUJITA Tomonori
Hi, On Tue, 28 May 2024 08:40:20 + Zhi Wang wrote: > On 27/05/2024 22.18, Danilo Krummrich wrote: >> External email: Use caution opening links or attachments >> >> >> On Tue, May 21, 2024 at 08:32:31AM +0300, Zhi Wang wrote: >>> On Mon, 20 May 2024 19:24:19 +0200 >>> Danilo Krummrich wrot

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-27 Thread Danilo Krummrich
On Wed, May 22, 2024 at 08:53:34AM +0900, FUJITA Tomonori wrote: > Hi, > Thanks for working on the firmware API! > > On Mon, 20 May 2024 19:24:19 +0200 > Danilo Krummrich wrote: > > > Add an abstraction around the kernels firmware API to request firmware > > images. The abstraction provides func

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-27 Thread Danilo Krummrich
On Tue, May 21, 2024 at 08:32:31AM +0300, Zhi Wang wrote: > On Mon, 20 May 2024 19:24:19 +0200 > Danilo Krummrich wrote: > > > Add an abstraction around the kernels firmware API to request firmware > > images. The abstraction provides functions to access the firmware > > buffer and / or copy it t

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-22 Thread Boqun Feng
On Thu, May 23, 2024 at 08:15:13AM +0900, FUJITA Tomonori wrote: > Hi, > > On Wed, 22 May 2024 09:37:30 +0200 > Philipp Stanner wrote: > > >> > +/// Abstraction around a C firmware struct. > >> > +/// > >> > +/// This is a simple abstraction around the C firmware API. Just > >> > like with the C

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-22 Thread FUJITA Tomonori
Hi, On Wed, 22 May 2024 09:37:30 +0200 Philipp Stanner wrote: >> > +/// Abstraction around a C firmware struct. >> > +/// >> > +/// This is a simple abstraction around the C firmware API. Just >> > like with the C API, firmware can >> > +/// be requested. Once requested the abstraction provides

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-22 Thread Philipp Stanner
On Wed, 2024-05-22 at 08:53 +0900, FUJITA Tomonori wrote: > Hi, > Thanks for working on the firmware API! > > On Mon, 20 May 2024 19:24:19 +0200 > Danilo Krummrich wrote: > > > Add an abstraction around the kernels firmware API to request > > firmware > > images. The abstraction provides functio

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-21 Thread FUJITA Tomonori
Hi, Thanks for working on the firmware API! On Mon, 20 May 2024 19:24:19 +0200 Danilo Krummrich wrote: > Add an abstraction around the kernels firmware API to request firmware > images. The abstraction provides functions to access the firmware > buffer and / or copy it to a new buffer allocated

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-21 Thread Zhi Wang
On Mon, 20 May 2024 19:24:19 +0200 Danilo Krummrich wrote: > Add an abstraction around the kernels firmware API to request firmware > images. The abstraction provides functions to access the firmware > buffer and / or copy it to a new buffer allocated with a given > allocator backend. > Was pla