Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-14 Thread Rob Herring
On Thu, Mar 14, 2019 at 4:01 AM Neil Armstrong wrote: > > On 08/03/2019 01:24, Rob Herring wrote: > > From: "Marty E. Plummer" > > > > This adds the initial driver for panfrost which supports Arm Mali > > Midgard and Bifrost family of GPUs. Currently, only the T860 Midgard GPU > > has been tested

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-14 Thread Neil Armstrong
On 08/03/2019 01:24, Rob Herring wrote: > From: "Marty E. Plummer" > > This adds the initial driver for panfrost which supports Arm Mali > Midgard and Bifrost family of GPUs. Currently, only the T860 Midgard GPU > has been tested. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-13 Thread Rob Herring
On Wed, Mar 13, 2019 at 11:09 AM Eric Anholt wrote: > > Rob Herring writes: > > > On Fri, Mar 8, 2019 at 10:29 AM Eric Anholt wrote: > >> > >> Rob Herring writes: > >> > >> > From: "Marty E. Plummer" > >> > > >> > This adds the initial driver for panfrost which supports Arm Mali > >> > Midgard

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-13 Thread Eric Anholt
Rob Herring writes: > On Fri, Mar 8, 2019 at 10:29 AM Eric Anholt wrote: >> >> Rob Herring writes: >> >> > From: "Marty E. Plummer" >> > >> > This adds the initial driver for panfrost which supports Arm Mali >> > Midgard and Bifrost family of GPUs. Currently, only the T860 Midgard GPU >> > has

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-13 Thread Eric Anholt
Rob Herring writes: > On Fri, Mar 8, 2019 at 10:29 AM Eric Anholt wrote: >> >> Rob Herring writes: >> >> > From: "Marty E. Plummer" >> > >> > This adds the initial driver for panfrost which supports Arm Mali >> > Midgard and Bifrost family of GPUs. Currently, only the T860 Midgard GPU >> > has

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-13 Thread Rob Herring
On Fri, Mar 8, 2019 at 10:29 AM Eric Anholt wrote: > > Rob Herring writes: > > > From: "Marty E. Plummer" > > > > This adds the initial driver for panfrost which supports Arm Mali > > Midgard and Bifrost family of GPUs. Currently, only the T860 Midgard GPU > > has been tested. [...] > It looks

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-09 Thread Alyssa Rosenzweig
> It was given to me and a bunch of other ARM kernel devs, but I think > it was in production by then. It's an A01 rev which matches this: > > https://www.notebookcheck.net/Samsung-Chromebook-XE303C12-A01US.84022.0.html > > The only other rev is a UK version. Wacky. Something seems decidedly odd

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-09 Thread Alyssa Rosenzweig
> bitmasks in the kernel use unsigned long arrays. A strange choice > which I guess was either because it predated 64-bit or enables atomic > ops which tend to be on the native size. So this just fixes the size > to 64-bits for 32 and 64 bit systems. Bizarre, but if that's the standard, then OK.

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-08 Thread Eric Anholt
Rob Herring writes: > From: "Marty E. Plummer" > > This adds the initial driver for panfrost which supports Arm Mali > Midgard and Bifrost family of GPUs. Currently, only the T860 Midgard GPU > has been tested. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-08 Thread Rob Herring
On Fri, Mar 8, 2019 at 9:34 AM Alyssa Rosenzweig wrote: > > > bitmasks in the kernel use unsigned long arrays. A strange choice > > which I guess was either because it predated 64-bit or enables atomic > > ops which tend to be on the native size. So this just fixes the size > > to 64-bits for 32 a

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-08 Thread Rob Herring
On Fri, Mar 8, 2019 at 2:20 AM Neil Armstrong wrote: > > On 08/03/2019 01:24, Rob Herring wrote: > > From: "Marty E. Plummer" > > > > This adds the initial driver for panfrost which supports Arm Mali > > Midgard and Bifrost family of GPUs. Currently, only the T860 Midgard GPU > > has been tested.

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-08 Thread Neil Armstrong
On 08/03/2019 15:39, Rob Herring wrote: > On Fri, Mar 8, 2019 at 2:18 AM Neil Armstrong wrote: >> >> On 08/03/2019 06:00, Alyssa Rosenzweig wrote: >>> Oh my onions, it's really here! It's really coming! It's really here! >>> >>> >>> >> >> >> >>> +static const struct of_device_id dt_matc

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-08 Thread Rob Herring
On Fri, Mar 8, 2019 at 2:18 AM Neil Armstrong wrote: > > On 08/03/2019 06:00, Alyssa Rosenzweig wrote: > > Oh my onions, it's really here! It's really coming! It's really here! > > > > > > > > > > > > >> +static const struct of_device_id dt_match[] = { > >> +{ .compatible = "arm,mali-t76

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-08 Thread Rob Herring
On Thu, Mar 7, 2019 at 11:00 PM Alyssa Rosenzweig wrote: > > Oh my onions, it's really here! It's really coming! It's really here! > > > > > + DRM driver for ARM Mali Midgard (t6xx, t7xx, t8xx) and > > + Bifrost (G3x, G5x, G7x) GPUs. > > Nitpick: the model names should maybe be ca

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-08 Thread Neil Armstrong
On 08/03/2019 01:24, Rob Herring wrote: > From: "Marty E. Plummer" > > This adds the initial driver for panfrost which supports Arm Mali > Midgard and Bifrost family of GPUs. Currently, only the T860 Midgard GPU > has been tested. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-08 Thread Neil Armstrong
On 08/03/2019 06:00, Alyssa Rosenzweig wrote: > Oh my onions, it's really here! It's really coming! It's really here! > > > > >> +static const struct of_device_id dt_match[] = { >> +{ .compatible = "arm,mali-t760" }, >> +{ .compatible = "arm,mali-t860" }, >> +{} >> +}; > > D

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-07 Thread Alyssa Rosenzweig
Oh my onions, it's really here! It's really coming! It's really here! > + DRM driver for ARM Mali Midgard (t6xx, t7xx, t8xx) and > + Bifrost (G3x, G5x, G7x) GPUs. Nitpick: the model names should maybe be capitalized? Or at least, the T/G should be consistent? I'm not sure what t

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-07 Thread Alyssa Rosenzweig
> I really think to write a decent vulkan driver, you need to take > arrays of in sync, Vulkan? What's that? ;) ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver

2019-03-07 Thread Dave Airlie
+struct drm_panfrost_submit { > + > + /** Address to GPU mapping of job descriptor */ > + __u64 jc; > + > + /** An optional sync object to wait on before starting this job. */ > + __u32 in_sync; > + > + /** An optional sync object to place the completion fence in. */