Re: [RFC PATCH] drm/msm: Remove dead code in msm_ioctl_gem_submit()

2025-07-01 Thread Rob Clark
On Tue, Jul 1, 2025 at 12:38 PM Shuah Khan wrote: > > On 6/23/25 12:47, I Hsin Cheng wrote: > > According to the report of Coverity Scan [1], "sync_file" is going to be > > NULL when entering the "if" section after "out_post_unlock", so > > "fput(sync_file->file)" is never going to be exected in t

Re: [RFC PATCH] drm/msm: Remove dead code in msm_ioctl_gem_submit()

2025-07-01 Thread Shuah Khan
On 6/23/25 12:47, I Hsin Cheng wrote: According to the report of Coverity Scan [1], "sync_file" is going to be NULL when entering the "if" section after "out_post_unlock", so "fput(sync_file->file)" is never going to be exected in this block. [1]: https://scan5.scan.coverity.com/#/project-view/