Re: [RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-30 Thread Thierry Reding
On Mon, Dec 17, 2012 at 10:36:10AM -0600, Rob Clark wrote: > On Mon, Dec 17, 2012 at 9:26 AM, Sekhar Nori wrote: > > Hi Rob, > > > > > > On Monday, December 17, 2012, Rob Clark wrote: > >> > >> On Mon, Dec 17, 2012 at 8:39 AM, Rob Clark wrote: > >> >> I'm not very enthusiastic about adding ti-lcd

Re: [RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-17 Thread Sekhar Nori
Hi Rob, On Monday, December 17, 2012, Rob Clark wrote: > On Mon, Dec 17, 2012 at 8:39 AM, Rob Clark > > wrote: > >> I'm not very enthusiastic about adding ti-lcdc specific panel/chip > >> drivers. It's not really a big deal if it's only kernel code, but you > >> add device-tree bindings also, whi

Re: [RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-17 Thread Tomi Valkeinen
On 2012-12-14 02:04, Rob Clark wrote: > A simple DRM/KMS driver for the TI LCD Controller found in various > smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the > CMA helpers. Currently only the TFP410 DVI encoder is supported > (tested with beaglebone + DVI cape). There are also vari

Re: [RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-17 Thread Rob Clark
On Mon, Dec 17, 2012 at 9:26 AM, Sekhar Nori wrote: > Hi Rob, > > > On Monday, December 17, 2012, Rob Clark wrote: >> >> On Mon, Dec 17, 2012 at 8:39 AM, Rob Clark wrote: >> >> I'm not very enthusiastic about adding ti-lcdc specific panel/chip >> >> drivers. It's not really a big deal if it's onl

Re: [RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-17 Thread Rob Clark
On Mon, Dec 17, 2012 at 8:39 AM, Rob Clark wrote: >> I'm not very enthusiastic about adding ti-lcdc specific panel/chip >> drivers. It's not really a big deal if it's only kernel code, but you >> add device-tree bindings also, which is an external API that you need to >> support after adding it. >

Re: [RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-17 Thread Rob Clark
On Mon, Dec 17, 2012 at 7:56 AM, Tomi Valkeinen wrote: > On 2012-12-14 02:04, Rob Clark wrote: >> A simple DRM/KMS driver for the TI LCD Controller found in various >> smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the >> CMA helpers. Currently only the TFP410 DVI encoder is supporte

Re: [RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-14 Thread Daniel Vetter
On Fri, Dec 14, 2012 at 1:04 AM, Rob Clark wrote: > +static int lcdc_crtc_page_flip(struct drm_crtc *crtc, > + struct drm_framebuffer *fb, > + struct drm_pending_vblank_event *event) > +{ > + struct lcdc_crtc *lcdc_crtc = to_lcdc_crtc(crtc); > + struct drm_d