Re: [RFC] Implicit vs explicit user fence sync

2021-05-12 Thread Daniel Vetter
On Wed, May 12, 2021 at 10:23:04AM +0200, Christian König wrote: > Am 12.05.21 um 10:13 schrieb Daniel Vetter: > > On Tue, May 11, 2021 at 09:34:11PM +0200, Christian König wrote: > > > Am 11.05.21 um 18:48 schrieb Daniel Vetter: > > > > [SNIP] > > > > > Why? > > > > If you allow implicit fencing t

Re: [RFC] Implicit vs explicit user fence sync

2021-05-12 Thread Christian König
Am 12.05.21 um 10:13 schrieb Daniel Vetter: On Tue, May 11, 2021 at 09:34:11PM +0200, Christian König wrote: Am 11.05.21 um 18:48 schrieb Daniel Vetter: [SNIP] Why? If you allow implicit fencing then you can end up with - an implicit userspace fence as the in-fence - but an explicit dma_fence

Re: [RFC] Implicit vs explicit user fence sync

2021-05-12 Thread Daniel Vetter
On Tue, May 11, 2021 at 09:34:11PM +0200, Christian König wrote: > Am 11.05.21 um 18:48 schrieb Daniel Vetter: > > [SNIP] > > > Why? > > If you allow implicit fencing then you can end up with > > - an implicit userspace fence as the in-fence > > - but an explicit dma_fence as the out fence > > > >

Re: [RFC] Implicit vs explicit user fence sync

2021-05-11 Thread Christian König
Am 11.05.21 um 18:48 schrieb Daniel Vetter: [SNIP] Why? If you allow implicit fencing then you can end up with - an implicit userspace fence as the in-fence - but an explicit dma_fence as the out fence Which is not allowed. So there's really no way to make this work, except if you stall in the

Re: [RFC] Implicit vs explicit user fence sync

2021-05-11 Thread Daniel Vetter
On Tue, May 11, 2021 at 05:32:29PM +0200, Christian König wrote: > Am 11.05.21 um 16:23 schrieb Daniel Vetter: > > On Tue, May 11, 2021 at 09:47:56AM +0200, Christian König wrote: > > > Am 11.05.21 um 09:31 schrieb Daniel Vetter: > > > > [SNIP] > > > > > > And that's just the one ioctl I know is bi

Re: [RFC] Implicit vs explicit user fence sync

2021-05-11 Thread Christian König
Am 11.05.21 um 16:23 schrieb Daniel Vetter: On Tue, May 11, 2021 at 09:47:56AM +0200, Christian König wrote: Am 11.05.21 um 09:31 schrieb Daniel Vetter: [SNIP] And that's just the one ioctl I know is big trouble, I'm sure we'll find more funny corner cases when we roll out explicit user fencin

Re: [RFC] Implicit vs explicit user fence sync

2021-05-11 Thread Daniel Vetter
On Tue, May 11, 2021 at 09:47:56AM +0200, Christian König wrote: > Am 11.05.21 um 09:31 schrieb Daniel Vetter: > > [SNIP] > > > > And that's just the one ioctl I know is big trouble, I'm sure we'll find > > > > more funny corner cases when we roll out explicit user fencing. > > > I think we can jus

Re: [RFC] Implicit vs explicit user fence sync

2021-05-11 Thread Christian König
Am 11.05.21 um 09:31 schrieb Daniel Vetter: [SNIP] And that's just the one ioctl I know is big trouble, I'm sure we'll find more funny corner cases when we roll out explicit user fencing. I think we can just ignore sync_file. As far as it concerns me that UAPI is pretty much dead. Uh that's ra

Re: [RFC] Implicit vs explicit user fence sync

2021-05-11 Thread Daniel Vetter
On Mon, May 10, 2021 at 08:12:31PM +0200, Christian König wrote: > Am 04.05.21 um 17:11 schrieb Daniel Vetter: > > On Tue, May 04, 2021 at 04:26:42PM +0200, Christian König wrote: > > > Hi Daniel, > > > > > > Am 04.05.21 um 16:15 schrieb Daniel Vetter: > > > > Hi Christian, > > > > > > > > On Tue

Re: [RFC] Implicit vs explicit user fence sync

2021-05-10 Thread Christian König
Am 04.05.21 um 17:11 schrieb Daniel Vetter: On Tue, May 04, 2021 at 04:26:42PM +0200, Christian König wrote: Hi Daniel, Am 04.05.21 um 16:15 schrieb Daniel Vetter: Hi Christian, On Tue, May 04, 2021 at 03:27:17PM +0200, Christian König wrote: Hi guys, with this patch set I want to look into

Re: [RFC] Implicit vs explicit user fence sync

2021-05-04 Thread Daniel Vetter
On Tue, May 04, 2021 at 04:26:42PM +0200, Christian König wrote: > Hi Daniel, > > Am 04.05.21 um 16:15 schrieb Daniel Vetter: > > Hi Christian, > > > > On Tue, May 04, 2021 at 03:27:17PM +0200, Christian König wrote: > > > Hi guys, > > > > > > with this patch set I want to look into how much mor

Re: [RFC] Implicit vs explicit user fence sync

2021-05-04 Thread Christian König
Hi Daniel, Am 04.05.21 um 16:15 schrieb Daniel Vetter: Hi Christian, On Tue, May 04, 2021 at 03:27:17PM +0200, Christian König wrote: Hi guys, with this patch set I want to look into how much more additional work it would be to support implicit sync compared to only explicit sync. Turned out

Re: [RFC] Implicit vs explicit user fence sync

2021-05-04 Thread Daniel Vetter
Hi Christian, On Tue, May 04, 2021 at 03:27:17PM +0200, Christian König wrote: > Hi guys, > > with this patch set I want to look into how much more additional work it > would be to support implicit sync compared to only explicit sync. > > Turned out that this is much simpler than expected since