Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-31 Thread Michel Dänzer
On 2021-05-20 4:18 p.m., Daniel Vetter wrote: > On Thu, May 20, 2021 at 10:13:38AM +0200, Michel Dänzer wrote: >> On 2021-05-20 9:55 a.m., Daniel Vetter wrote: >>> On Wed, May 19, 2021 at 5:48 PM Michel Dänzer wrote: On 2021-05-19 5:21 p.m., Jason Ekstrand wrote: > On Wed, May 19, 20

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-21 Thread Bas Nieuwenhuizen
On Thu, May 20, 2021 at 9:15 PM Daniel Vetter wrote: > > On Thu, May 20, 2021 at 9:04 PM Jason Ekstrand wrote: > > > > On Thu, May 20, 2021 at 12:23 PM Jason Ekstrand > > wrote: > > > > > > On Thu, May 20, 2021 at 5:50 AM Christian König > > > wrote: > > > > > > > > Am 20.05.21 um 09:55 schrie

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-21 Thread Christian König
Am 20.05.21 um 21:14 schrieb Daniel Vetter: On Thu, May 20, 2021 at 9:04 PM Jason Ekstrand wrote: On Thu, May 20, 2021 at 12:23 PM Jason Ekstrand wrote: On Thu, May 20, 2021 at 5:50 AM Christian König wrote: Am 20.05.21 um 09:55 schrieb Daniel Vetter: On Wed, May 19, 2021 at 5:48 PM Michel

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-21 Thread Christian König
Am 20.05.21 um 19:23 schrieb Jason Ekstrand: [SNIP] I'd argue then that making amdgpu poll semantics match those of other drivers is a pre-requisite for the new ioctl, otherwise it seems unlikely that the ioctl will be widely adopted. This seems backwards, because that means useful improvem

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-20 Thread Daniel Vetter
On Thu, May 20, 2021 at 9:04 PM Jason Ekstrand wrote: > > On Thu, May 20, 2021 at 12:23 PM Jason Ekstrand wrote: > > > > On Thu, May 20, 2021 at 5:50 AM Christian König > > wrote: > > > > > > Am 20.05.21 um 09:55 schrieb Daniel Vetter: > > > > On Wed, May 19, 2021 at 5:48 PM Michel Dänzer > >

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-20 Thread Jason Ekstrand
On Thu, May 20, 2021 at 12:23 PM Jason Ekstrand wrote: > > On Thu, May 20, 2021 at 5:50 AM Christian König > wrote: > > > > Am 20.05.21 um 09:55 schrieb Daniel Vetter: > > > On Wed, May 19, 2021 at 5:48 PM Michel Dänzer wrote: > > >> On 2021-05-19 5:21 p.m., Jason Ekstrand wrote: > > >>> On Wed,

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-20 Thread Jason Ekstrand
On Thu, May 20, 2021 at 5:50 AM Christian König wrote: > > Am 20.05.21 um 09:55 schrieb Daniel Vetter: > > On Wed, May 19, 2021 at 5:48 PM Michel Dänzer wrote: > >> On 2021-05-19 5:21 p.m., Jason Ekstrand wrote: > >>> On Wed, May 19, 2021 at 5:52 AM Michel Dänzer wrote: > On 2021-05-19 12:0

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-20 Thread Jason Ekstrand
On Thu, May 20, 2021 at 9:18 AM Daniel Vetter wrote: > > On Thu, May 20, 2021 at 10:13:38AM +0200, Michel Dänzer wrote: > > On 2021-05-20 9:55 a.m., Daniel Vetter wrote: > > > On Wed, May 19, 2021 at 5:48 PM Michel Dänzer wrote: > > >> > > >> On 2021-05-19 5:21 p.m., Jason Ekstrand wrote: > > >>>

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-20 Thread Michel Dänzer
On 2021-05-20 4:18 p.m., Daniel Vetter wrote: > On Thu, May 20, 2021 at 10:13:38AM +0200, Michel Dänzer wrote: >> On 2021-05-20 9:55 a.m., Daniel Vetter wrote: >>> On Wed, May 19, 2021 at 5:48 PM Michel Dänzer wrote: On 2021-05-19 5:21 p.m., Jason Ekstrand wrote: > On Wed, May 19, 20

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-20 Thread Daniel Vetter
On Thu, May 20, 2021 at 10:13:38AM +0200, Michel Dänzer wrote: > On 2021-05-20 9:55 a.m., Daniel Vetter wrote: > > On Wed, May 19, 2021 at 5:48 PM Michel Dänzer wrote: > >> > >> On 2021-05-19 5:21 p.m., Jason Ekstrand wrote: > >>> On Wed, May 19, 2021 at 5:52 AM Michel Dänzer wrote: > >

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-20 Thread Christian König
Am 20.05.21 um 09:55 schrieb Daniel Vetter: On Wed, May 19, 2021 at 5:48 PM Michel Dänzer wrote: On 2021-05-19 5:21 p.m., Jason Ekstrand wrote: On Wed, May 19, 2021 at 5:52 AM Michel Dänzer wrote: On 2021-05-19 12:06 a.m., Jason Ekstrand wrote: On Tue, May 18, 2021 at 4:17 PM Daniel Vetter

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-20 Thread Christian König
Am 20.05.21 um 10:13 schrieb Michel Dänzer: On 2021-05-20 9:55 a.m., Daniel Vetter wrote: On Wed, May 19, 2021 at 5:48 PM Michel Dänzer wrote: On 2021-05-19 5:21 p.m., Jason Ekstrand wrote: On Wed, May 19, 2021 at 5:52 AM Michel Dänzer wrote: On 2021-05-19 12:06 a.m., Jason Ekstrand wrote:

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-20 Thread Michel Dänzer
On 2021-05-20 9:55 a.m., Daniel Vetter wrote: > On Wed, May 19, 2021 at 5:48 PM Michel Dänzer wrote: >> >> On 2021-05-19 5:21 p.m., Jason Ekstrand wrote: >>> On Wed, May 19, 2021 at 5:52 AM Michel Dänzer wrote: On 2021-05-19 12:06 a.m., Jason Ekstrand wrote: > On Tue, May 18, 2021 a

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-20 Thread Daniel Vetter
On Wed, May 19, 2021 at 1:24 PM Christian König wrote: > > Am 18.05.21 um 23:17 schrieb Daniel Vetter: > > [SNIP] > >> The problem in this case is not starting a new CS, but synchronizing to > >> the existing ones. > >> > >> See a heavy TLB flush is made completely out of sync. E.g. it doesn't > >

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-20 Thread Daniel Vetter
On Wed, May 19, 2021 at 5:48 PM Michel Dänzer wrote: > > On 2021-05-19 5:21 p.m., Jason Ekstrand wrote: > > On Wed, May 19, 2021 at 5:52 AM Michel Dänzer wrote: > >> > >> On 2021-05-19 12:06 a.m., Jason Ekstrand wrote: > >>> On Tue, May 18, 2021 at 4:17 PM Daniel Vetter wrote: > > On T

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-19 Thread Michel Dänzer
On 2021-05-19 5:21 p.m., Jason Ekstrand wrote: > On Wed, May 19, 2021 at 5:52 AM Michel Dänzer wrote: >> >> On 2021-05-19 12:06 a.m., Jason Ekstrand wrote: >>> On Tue, May 18, 2021 at 4:17 PM Daniel Vetter wrote: On Tue, May 18, 2021 at 7:40 PM Christian König wrote: > > A

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-19 Thread Jason Ekstrand
On Wed, May 19, 2021 at 6:43 AM Christian König wrote: > > Am 19.05.21 um 00:06 schrieb Jason Ekstrand: > > [SNIP] > >>> E.g. we can't add a fence which doesn't wait for the exclusive one as > >>> shared. > >> Ok I think that's a real problem, and guess it's also related to all > >> the ttm priva

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-19 Thread Jason Ekstrand
On Wed, May 19, 2021 at 5:52 AM Michel Dänzer wrote: > > On 2021-05-19 12:06 a.m., Jason Ekstrand wrote: > > On Tue, May 18, 2021 at 4:17 PM Daniel Vetter wrote: > >> > >> On Tue, May 18, 2021 at 7:40 PM Christian König > >> wrote: > >>> > >>> Am 18.05.21 um 18:48 schrieb Daniel Vetter: > O

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-19 Thread Christian König
Am 19.05.21 um 00:06 schrieb Jason Ekstrand: [SNIP] E.g. we can't add a fence which doesn't wait for the exclusive one as shared. Ok I think that's a real problem, and guess it's also related to all the ttm privatization tricks and all that. So essentially we'd need the opposite of ttm_bo->mov

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-19 Thread Christian König
Am 18.05.21 um 23:17 schrieb Daniel Vetter: [SNIP] The problem in this case is not starting a new CS, but synchronizing to the existing ones. See a heavy TLB flush is made completely out of sync. E.g. it doesn't want to wait for any previous operation. In other words imagine the following exam

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-19 Thread Michel Dänzer
On 2021-05-19 12:06 a.m., Jason Ekstrand wrote: > On Tue, May 18, 2021 at 4:17 PM Daniel Vetter wrote: >> >> On Tue, May 18, 2021 at 7:40 PM Christian König >> wrote: >>> >>> Am 18.05.21 um 18:48 schrieb Daniel Vetter: On Tue, May 18, 2021 at 2:49 PM Christian König wrote: > A

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-18 Thread Jason Ekstrand
On Tue, May 18, 2021 at 4:17 PM Daniel Vetter wrote: > > On Tue, May 18, 2021 at 7:40 PM Christian König > wrote: > > > > Am 18.05.21 um 18:48 schrieb Daniel Vetter: > > > On Tue, May 18, 2021 at 2:49 PM Christian König > > > wrote: > > >> Hi Jason & Daniel, > > >> > > >> Am 18.05.21 um 07:59 sc

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-18 Thread Dave Airlie
> > We basically don't know during CS if a BO is shared or not. Who doesn't know? We should be able to track this quite easily, userspace either imports or exports buffers, it can surely keep track of these and flag them. Is this a userspace might lie to use worry or do you have some really broke

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-18 Thread Daniel Vetter
On Tue, May 18, 2021 at 7:40 PM Christian König wrote: > > Am 18.05.21 um 18:48 schrieb Daniel Vetter: > > On Tue, May 18, 2021 at 2:49 PM Christian König > > wrote: > >> Hi Jason & Daniel, > >> > >> Am 18.05.21 um 07:59 schrieb Daniel Vetter: > >>> On Tue, May 18, 2021 at 12:49 AM Jason Ekstrand

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-18 Thread Christian König
Am 18.05.21 um 18:48 schrieb Daniel Vetter: On Tue, May 18, 2021 at 2:49 PM Christian König wrote: Hi Jason & Daniel, Am 18.05.21 um 07:59 schrieb Daniel Vetter: On Tue, May 18, 2021 at 12:49 AM Jason Ekstrand wrote: On Mon, May 17, 2021 at 3:15 PM Daniel Vetter wrote: On Mon, May 17, 202

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-18 Thread Daniel Vetter
On Tue, May 18, 2021 at 2:49 PM Christian König wrote: > > Hi Jason & Daniel, > > Am 18.05.21 um 07:59 schrieb Daniel Vetter: > > On Tue, May 18, 2021 at 12:49 AM Jason Ekstrand > > wrote: > >> On Mon, May 17, 2021 at 3:15 PM Daniel Vetter wrote: > >>> On Mon, May 17, 2021 at 9:38 PM Christian

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-18 Thread Christian König
Am 18.05.21 um 15:26 schrieb Daniel Stone: On Tue, 18 May 2021 at 13:49, Christian König wrote: Am 18.05.21 um 07:59 schrieb Daniel Vetter: First step in fixing that is (and frankly was since years) to fix the amdgpu CS so winsys can pass along a bunch of flags about which CS should actually s

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-18 Thread Daniel Stone
On Tue, 18 May 2021 at 13:49, Christian König wrote: > Am 18.05.21 um 07:59 schrieb Daniel Vetter: > > First step in fixing that is (and frankly was since years) to fix the > > amdgpu CS so winsys can pass along a bunch of flags about which CS > > should actually set the exclusive fence, so that y

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-18 Thread Christian König
Hi Jason & Daniel, Am 18.05.21 um 07:59 schrieb Daniel Vetter: On Tue, May 18, 2021 at 12:49 AM Jason Ekstrand wrote: On Mon, May 17, 2021 at 3:15 PM Daniel Vetter wrote: On Mon, May 17, 2021 at 9:38 PM Christian König wrote: Am 17.05.21 um 17:04 schrieb Daniel Vetter: On Mon, May 17, 202

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-18 Thread Daniel Vetter
On Tue, May 18, 2021 at 7:59 AM Daniel Vetter wrote: > > On Tue, May 18, 2021 at 12:49 AM Jason Ekstrand wrote: > > > > On Mon, May 17, 2021 at 3:15 PM Daniel Vetter wrote: > > > > > > On Mon, May 17, 2021 at 9:38 PM Christian König > > > wrote: > > > > > > > > Am 17.05.21 um 17:04 schrieb Dani

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-17 Thread Daniel Vetter
On Tue, May 18, 2021 at 12:49 AM Jason Ekstrand wrote: > > On Mon, May 17, 2021 at 3:15 PM Daniel Vetter wrote: > > > > On Mon, May 17, 2021 at 9:38 PM Christian König > > wrote: > > > > > > Am 17.05.21 um 17:04 schrieb Daniel Vetter: > > > > On Mon, May 17, 2021 at 04:11:18PM +0200, Christian K

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-17 Thread Jason Ekstrand
On Mon, May 17, 2021 at 3:15 PM Daniel Vetter wrote: > > On Mon, May 17, 2021 at 9:38 PM Christian König > wrote: > > > > Am 17.05.21 um 17:04 schrieb Daniel Vetter: > > > On Mon, May 17, 2021 at 04:11:18PM +0200, Christian König wrote: > > >> We had a long outstanding problem in amdgpu that buff

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-17 Thread Daniel Vetter
On Mon, May 17, 2021 at 9:38 PM Christian König wrote: > > Am 17.05.21 um 17:04 schrieb Daniel Vetter: > > On Mon, May 17, 2021 at 04:11:18PM +0200, Christian König wrote: > >> We had a long outstanding problem in amdgpu that buffers exported to > >> user drivers by DMA-buf serialize all command s

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-17 Thread Jason Ekstrand
On Mon, May 17, 2021 at 2:38 PM Christian König wrote: > > Am 17.05.21 um 17:04 schrieb Daniel Vetter: > > On Mon, May 17, 2021 at 04:11:18PM +0200, Christian König wrote: > >> We had a long outstanding problem in amdgpu that buffers exported to > >> user drivers by DMA-buf serialize all command s

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-17 Thread Christian König
Am 17.05.21 um 17:04 schrieb Daniel Vetter: On Mon, May 17, 2021 at 04:11:18PM +0200, Christian König wrote: We had a long outstanding problem in amdgpu that buffers exported to user drivers by DMA-buf serialize all command submissions using them. In other words we can't compose the buffer with

Re: [RFC] Add DMA_RESV_USAGE flags

2021-05-17 Thread Daniel Vetter
On Mon, May 17, 2021 at 04:11:18PM +0200, Christian König wrote: > We had a long outstanding problem in amdgpu that buffers exported to > user drivers by DMA-buf serialize all command submissions using them. > > In other words we can't compose the buffer with different engines and > then send it t