Re: [RESEND][PATCH v8 1/5] dma-buf: Add dma-buf heaps framework

2019-10-02 Thread John Stultz
On Sun, Sep 29, 2019 at 8:27 PM Hillf Danton wrote: > On Fri, 6 Sep 2019 18:47:08 + John Stultz wrote: > > +/** > > + * dma_heap_get_data() - get per-heap driver data > > + * @heap: DMA-Heap to retrieve private data for > > + * > > + * Returns: > > + * The per-heap data for the heap. > > + */

Re: [RESEND][PATCH v8 1/5] dma-buf: Add dma-buf heaps framework

2019-09-29 Thread Hillf Danton
On Fri, 6 Sep 2019 18:47:08 + John Stultz wrote: > +/** > + * dma_heap_get_data() - get per-heap driver data > + * @heap: DMA-Heap to retrieve private data for > + * > + * Returns: > + * The per-heap data for the heap. > + */ > +void *dma_heap_get_data(struct dma_heap *heap); > + It will hel

Re: [RESEND][PATCH v8 1/5] dma-buf: Add dma-buf heaps framework

2019-09-24 Thread John Stultz
On Mon, Sep 23, 2019 at 3:08 PM Brian Starkey wrote: > One miniscule nit from me below, but whether you change it or not, you > can add my r-b: > > Reviewed-by: Brian Starkey > > Thanks for pushing this through! Thanks again for the review! I'll address your issues and resubmit. thanks -john

Re: [RESEND][PATCH v8 1/5] dma-buf: Add dma-buf heaps framework

2019-09-23 Thread Brian Starkey
Hi John, On Fri, Sep 06, 2019 at 06:47:08PM +, John Stultz wrote: > From: "Andrew F. Davis" > > This framework allows a unified userspace interface for dma-buf > exporters, allowing userland to allocate specific types of memory > for use in dma-buf sharing. > > Each heap is given its own de