Re: [PATCHv3/RFC 1/4] drm/arm: Factor out generic afbc helpers

2019-11-28 Thread james qian wang (Arm Technology China)
On Mon, Nov 25, 2019 at 09:55:06AM +0100, Daniel Vetter wrote: > On Thu, Nov 21, 2019 at 06:22:44PM +0100, Andrzej Pietrasiewicz wrote: > > These are useful for other users of afbc, e.g. rockchip. > > > > Signed-off-by: Andrzej Pietrasiewicz > > --- > > drivers/gpu/drm/Makefile | 2 +-

Re: [PATCHv3/RFC 1/4] drm/arm: Factor out generic afbc helpers

2019-11-27 Thread Daniel Vetter
On Tue, Nov 26, 2019 at 09:27:59PM +0100, Andrzej Pietrasiewicz wrote: > Hi Daniel, > > Thanks for the comments, please see inline > > W dniu 25.11.2019 o 09:55, Daniel Vetter pisze: > > On Thu, Nov 21, 2019 at 06:22:44PM +0100, Andrzej Pietrasiewicz wrote: > > > These are useful for other users

Re: [PATCHv3/RFC 1/4] drm/arm: Factor out generic afbc helpers

2019-11-26 Thread Andrzej Pietrasiewicz
Hi Daniel, Thanks for the comments, please see inline W dniu 25.11.2019 o 09:55, Daniel Vetter pisze: On Thu, Nov 21, 2019 at 06:22:44PM +0100, Andrzej Pietrasiewicz wrote: These are useful for other users of afbc, e.g. rockchip. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/Mak

Re: [PATCHv3/RFC 1/4] drm/arm: Factor out generic afbc helpers

2019-11-25 Thread Daniel Vetter
On Thu, Nov 21, 2019 at 06:22:44PM +0100, Andrzej Pietrasiewicz wrote: > These are useful for other users of afbc, e.g. rockchip. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/Makefile | 2 +- > drivers/gpu/drm/drm_afbc.c| 84 +++ >

Re: [PATCHv3/RFC 1/4] drm/arm: Factor out generic afbc helpers

2019-11-22 Thread Ezequiel Garcia
Hi Andrzej, Thanks for the series. It's certainly going well. Please see some minor comments below. On Thu, 2019-11-21 at 18:22 +0100, Andrzej Pietrasiewicz wrote: > These are useful for other users of afbc, e.g. rockchip. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/Makef