Re: [PATCH v8 10/19] drm/i915/dsc: Compute Rate Control parameters for DSC

2018-11-06 Thread Ville Syrjälä
On Tue, Nov 06, 2018 at 12:14:50PM -0800, Manasi Navare wrote: > On Tue, Nov 06, 2018 at 07:00:50PM +0200, Ville Syrjälä wrote: > > On Tue, Nov 06, 2018 at 08:52:41AM -0800, Manasi Navare wrote: > > > On Tue, Nov 06, 2018 at 04:33:38PM +0200, Ville Syrjälä wrote: > > > > On Fri, Nov 02, 2018 at 02:

Re: [PATCH v8 10/19] drm/i915/dsc: Compute Rate Control parameters for DSC

2018-11-06 Thread Manasi Navare
On Tue, Nov 06, 2018 at 07:00:50PM +0200, Ville Syrjälä wrote: > On Tue, Nov 06, 2018 at 08:52:41AM -0800, Manasi Navare wrote: > > On Tue, Nov 06, 2018 at 04:33:38PM +0200, Ville Syrjälä wrote: > > > On Fri, Nov 02, 2018 at 02:31:29PM -0700, Manasi Navare wrote: > > > > From: Gaurav K Singh > > >

Re: [PATCH v8 10/19] drm/i915/dsc: Compute Rate Control parameters for DSC

2018-11-06 Thread Ville Syrjälä
On Tue, Nov 06, 2018 at 08:52:41AM -0800, Manasi Navare wrote: > On Tue, Nov 06, 2018 at 04:33:38PM +0200, Ville Syrjälä wrote: > > On Fri, Nov 02, 2018 at 02:31:29PM -0700, Manasi Navare wrote: > > > From: Gaurav K Singh > > > > > > This computation of RC params happens in the atomic commit phas

Re: [PATCH v8 10/19] drm/i915/dsc: Compute Rate Control parameters for DSC

2018-11-06 Thread Manasi Navare
On Tue, Nov 06, 2018 at 04:33:38PM +0200, Ville Syrjälä wrote: > On Fri, Nov 02, 2018 at 02:31:29PM -0700, Manasi Navare wrote: > > From: Gaurav K Singh > > > > This computation of RC params happens in the atomic commit phase > > during compute_config() to validate if display stream compression >

Re: [PATCH v8 10/19] drm/i915/dsc: Compute Rate Control parameters for DSC

2018-11-06 Thread Ville Syrjälä
On Fri, Nov 02, 2018 at 02:31:29PM -0700, Manasi Navare wrote: > From: Gaurav K Singh > > This computation of RC params happens in the atomic commit phase > during compute_config() to validate if display stream compression > can be enabled for the requested mode. > > v7 (From Manasi): > * Use DR