Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-16 Thread Sascha Hauer
On Wed, Mar 16, 2022 at 04:01:49PM +0300, Dmitry Osipenko wrote: > On 3/16/22 12:12, Sascha Hauer wrote: > > On Mon, Mar 14, 2022 at 08:54:27PM +0300, Dmitry Osipenko wrote: > >> On 3/14/22 11:18, Sascha Hauer wrote: > >>> On Sun, Mar 13, 2022 at 12:07:56AM +0300, Dmitry Osipenko wrote: > On 3

Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-16 Thread Dmitry Osipenko
On 3/16/22 16:55, Robin Murphy wrote: >> To me that NIU quirk should be internal to the clk h/w module, so it >> doesn't feel nice to mix the clk h/w description with the HDMI h/w >> description. >> >> On the other hand, making clk driver to handle this case indeed will >> take some effort as I see

Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-16 Thread Robin Murphy
On 2022-03-16 13:01, Dmitry Osipenko wrote: On 3/16/22 12:12, Sascha Hauer wrote: On Mon, Mar 14, 2022 at 08:54:27PM +0300, Dmitry Osipenko wrote: On 3/14/22 11:18, Sascha Hauer wrote: On Sun, Mar 13, 2022 at 12:07:56AM +0300, Dmitry Osipenko wrote: On 3/11/22 11:33, Sascha Hauer wrote: The

Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-16 Thread Dmitry Osipenko
On 3/16/22 12:12, Sascha Hauer wrote: > On Mon, Mar 14, 2022 at 08:54:27PM +0300, Dmitry Osipenko wrote: >> On 3/14/22 11:18, Sascha Hauer wrote: >>> On Sun, Mar 13, 2022 at 12:07:56AM +0300, Dmitry Osipenko wrote: On 3/11/22 11:33, Sascha Hauer wrote: > The rk3568 HDMI has an additional c

Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-16 Thread Sascha Hauer
On Mon, Mar 14, 2022 at 08:54:27PM +0300, Dmitry Osipenko wrote: > On 3/14/22 11:18, Sascha Hauer wrote: > > On Sun, Mar 13, 2022 at 12:07:56AM +0300, Dmitry Osipenko wrote: > >> On 3/11/22 11:33, Sascha Hauer wrote: > >>> The rk3568 HDMI has an additional clock that needs to be enabled for the > >

Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-14 Thread Dmitry Osipenko
On 3/14/22 11:18, Sascha Hauer wrote: > On Sun, Mar 13, 2022 at 12:07:56AM +0300, Dmitry Osipenko wrote: >> On 3/11/22 11:33, Sascha Hauer wrote: >>> The rk3568 HDMI has an additional clock that needs to be enabled for the >>> HDMI controller to work. This clock is not needed for the HDMI >>> contr

Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-14 Thread Sascha Hauer
On Sun, Mar 13, 2022 at 12:07:56AM +0300, Dmitry Osipenko wrote: > On 3/11/22 11:33, Sascha Hauer wrote: > > The rk3568 HDMI has an additional clock that needs to be enabled for the > > HDMI controller to work. This clock is not needed for the HDMI > > controller itself, but to make the SoC interna

Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-12 Thread Dmitry Osipenko
On 3/11/22 11:33, Sascha Hauer wrote: > The rk3568 HDMI has an additional clock that needs to be enabled for the > HDMI controller to work. This clock is not needed for the HDMI > controller itself, but to make the SoC internal bus logic work. From the > reference manual: > >> 2.8.6 NIU Clock gati