Re: [PATCH v7 05/28] dma-heap: Add proper kref handling on dma-buf heaps

2024-07-22 Thread Markus Elfring
>> … >>> +++ b/drivers/dma-buf/dma-heap.c >> … >>> +static void dma_heap_release(struct kref *ref) >>> +{ >> … >>> + mutex_lock(&heap_list_lock); >>> + list_del(&heap->list); >>> + mutex_unlock(&heap_list_lock); >> … >> >> Under which circumstances would you become interested to apply a

Re: [PATCH v7 05/28] dma-heap: Add proper kref handling on dma-buf heaps

2024-07-22 Thread John Stultz
On Sat, Jul 20, 2024 at 8:13 AM Markus Elfring wrote: > > … > > +++ b/drivers/dma-buf/dma-heap.c > … > > +static void dma_heap_release(struct kref *ref) > > +{ > … > > + mutex_lock(&heap_list_lock); > > + list_del(&heap->list); > > + mutex_unlock(&heap_list_lock); > … > > Under which c

Re: [PATCH v7 05/28] dma-heap: Add proper kref handling on dma-buf heaps

2024-07-20 Thread Markus Elfring
… > +++ b/drivers/dma-buf/dma-heap.c … > +static void dma_heap_release(struct kref *ref) > +{ … > + mutex_lock(&heap_list_lock); > + list_del(&heap->list); > + mutex_unlock(&heap_list_lock); … Under which circumstances would you become interested to apply a statement like “guard(mutex)