Re: [PATCH v5 19/21] drm/tegra: Implement new UAPI

2021-03-23 Thread Thierry Reding
On Tue, Mar 23, 2021 at 06:00:34PM +0300, Dmitry Osipenko wrote: > 23.03.2021 17:43, Mikko Perttunen пишет: > >> > >> FWIW, I would've been fine with stashing all of this into drm.c as well > >> since the rest of the UAPI is in that already. The churn in this patch > >> is reasonably small, but it

Re: [PATCH v5 19/21] drm/tegra: Implement new UAPI

2021-03-23 Thread Dmitry Osipenko
23.03.2021 17:43, Mikko Perttunen пишет: >> >> FWIW, I would've been fine with stashing all of this into drm.c as well >> since the rest of the UAPI is in that already. The churn in this patch >> is reasonably small, but it would've been even less if this was just all >> in drm.c. > > I think we s

Re: [PATCH v5 19/21] drm/tegra: Implement new UAPI

2021-03-23 Thread Mikko Perttunen
On 3/23/21 3:25 PM, Thierry Reding wrote: On Mon, Jan 11, 2021 at 03:00:17PM +0200, Mikko Perttunen wrote: Implement the non-submission parts of the new UAPI, including channel management and memory mapping. The UAPI is under the CONFIG_DRM_TEGRA_STAGING config flag for now. Signed-off-by: Mikk

Re: [PATCH v5 19/21] drm/tegra: Implement new UAPI

2021-03-23 Thread Thierry Reding
On Mon, Jan 11, 2021 at 03:00:17PM +0200, Mikko Perttunen wrote: > Implement the non-submission parts of the new UAPI, including > channel management and memory mapping. The UAPI is under the > CONFIG_DRM_TEGRA_STAGING config flag for now. > > Signed-off-by: Mikko Perttunen > --- > v5: > * Set io

Re: [PATCH v5 19/21] drm/tegra: Implement new UAPI

2021-01-13 Thread Dmitry Osipenko
11.01.2021 16:00, Mikko Perttunen пишет: > +int tegra_drm_ioctl_channel_open(struct drm_device *drm, void *data, > + struct drm_file *file) > +{ > + struct tegra_drm_file *fpriv = file->driver_priv; > + struct tegra_drm *tegra = drm->dev_private; > + struct

Re: [PATCH v5 19/21] drm/tegra: Implement new UAPI

2021-01-11 Thread kernel test robot
Hi Mikko, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20210111] [cannot apply to tegra-drm/drm/tegra/for-next tegra/for-next linus/master v5.11-rc3 v5.11-rc2 v5.11-rc1 v5.11-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. A