Re: [PATCH v5 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-07-03 Thread Brendan Higgins
On Fri, Jun 21, 2019 at 5:54 PM Brendan Higgins wrote: > > On Fri, Jun 21, 2019 at 12:21 PM shuah wrote: > > > > On 6/21/19 12:13 PM, Theodore Ts'o wrote: > > > On Fri, Jun 21, 2019 at 08:59:48AM -0600, shuah wrote: > > ### But wait! Doesn't kselftest support in kernel testing?! > > > >

Re: [PATCH v5 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-06-25 Thread Luis Chamberlain
On Wed, Jun 19, 2019 at 06:17:51PM -0700, Frank Rowand wrote: > It does not matter whether KUnit provides additional things, relative > to kselftest. The point I was making is that there appears to be > _some_ overlap between kselftest and KUnit, and if there is overlap > then it is worth consider

Re: [PATCH v5 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-06-21 Thread Brendan Higgins
On Fri, Jun 21, 2019 at 12:21 PM shuah wrote: > > On 6/21/19 12:13 PM, Theodore Ts'o wrote: > > On Fri, Jun 21, 2019 at 08:59:48AM -0600, shuah wrote: > ### But wait! Doesn't kselftest support in kernel testing?! > > > >> > >> I think I commented on this before. I agree with th

Re: [PATCH v5 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-06-21 Thread Brendan Higgins
On Wed, Jun 19, 2019 at 6:17 PM Frank Rowand wrote: > > Hi Brendan, > > I am only responding to this because you asked me to in the v4 thread. Yes, I did! Thank you, I appreciate it! > Thank you for evaluating my comments in the v4 thread and asking me to > comment on v5 Of course, I feel as th

Re: [PATCH v5 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-06-21 Thread shuah
On 6/21/19 12:13 PM, Theodore Ts'o wrote: On Fri, Jun 21, 2019 at 08:59:48AM -0600, shuah wrote: ### But wait! Doesn't kselftest support in kernel testing?! I think I commented on this before. I agree with the statement that there is no overlap between Kselftest and KUnit. I would like s

Re: [PATCH v5 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-06-21 Thread Theodore Ts'o
On Fri, Jun 21, 2019 at 08:59:48AM -0600, shuah wrote: > > > ### But wait! Doesn't kselftest support in kernel testing?! > > > > > > > > I think I commented on this before. I agree with the statement that > there is no overlap between Kselftest and KUnit. I would like see this > removed. Ksel

Re: [PATCH v5 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-06-21 Thread shuah
Hi Brendan, On 6/19/19 7:17 PM, Frank Rowand wrote: Hi Brendan, I am only responding to this because you asked me to in the v4 thread. Thank you for evaluating my comments in the v4 thread and asking me to comment on v5 On 6/17/19 1:25 AM, Brendan Higgins wrote: ## TL;DR A not so quick foll

Re: [PATCH v5 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-06-19 Thread Frank Rowand
Hi Brendan, I am only responding to this because you asked me to in the v4 thread. Thank you for evaluating my comments in the v4 thread and asking me to comment on v5 On 6/17/19 1:25 AM, Brendan Higgins wrote: > ## TL;DR > > A not so quick follow-up to Stephen's suggestions on PATCH v4. Nothin