Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver

2023-01-02 Thread Javier Martinez Canillas
On 1/2/23 16:20, Ondřej Jirman wrote: > On Mon, Jan 02, 2023 at 02:51:42PM +0100, Javier Martinez Canillas wrote: >> Hello Ondřej, >> >> [...] >> >> My goal was to have some initial support in mainline even if there could be >> some >> issues. IMO it is better to use upstream as a baseline and att

Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver

2023-01-02 Thread Ondřej Jirman
On Mon, Jan 02, 2023 at 02:51:42PM +0100, Javier Martinez Canillas wrote: > Hello Ondřej, > > [...] > > My goal was to have some initial support in mainline even if there could be > some > issues. IMO it is better to use upstream as a baseline and attempt to support > the > PPP incrementally. >

Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver

2023-01-02 Thread Javier Martinez Canillas
Hello Ondřej, On 1/2/23 11:59, Ondřej Jirman wrote: [...] >> Yes, because as you said were debug printks. Feel free to propose adding the >> debug printks if you consider useful for normal usage and not just for devel >> purposes. > > I already did, and used them do debug and fix the issues. Th

Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver

2023-01-02 Thread Ondřej Jirman
Hello Javier, On Sat, Dec 31, 2022 at 04:15:24PM +0100, Javier Martinez Canillas wrote: > Hello Ondřej, > > Thanks a lot for your comments. > > On 12/30/22 16:40, Ondřej Jirman wrote: > > Hi Javier, > > > > On Fri, Dec 30, 2022 at 12:31:52PM +0100, Javier Martinez Canillas wrote: > >> From: Kam

Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver

2022-12-31 Thread Javier Martinez Canillas
Hello Ondřej, Thanks a lot for your comments. On 12/30/22 16:40, Ondřej Jirman wrote: > Hi Javier, > > On Fri, Dec 30, 2022 at 12:31:52PM +0100, Javier Martinez Canillas wrote: >> From: Kamil Trzciński >> >> The driver is for panels based on the Himax HX8394 controller, such as the >> HannStar

Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver

2022-12-30 Thread Ondřej Jirman
Hi Javier, On Fri, Dec 30, 2022 at 12:31:52PM +0100, Javier Martinez Canillas wrote: > From: Kamil Trzciński > > The driver is for panels based on the Himax HX8394 controller, such as the > HannStar HSD060BHW4 720x1440 TFT LCD panel that uses a MIPI-DSI interface. I see you've removed debug pri