Re: [PATCH v4] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-05 Thread Boris Brezillon
On Thu, 5 Nov 2020 13:27:04 + Steven Price wrote: > > + old_status = atomic_xchg(&queue->status, > > +PANFROST_QUEUE_STATUS_STOPPED); > > + WARN_ON(old_status != PANFROST_QUEUE_STATUS_ACTIVE && > > + old_status != PANFROST_QUEUE_STATUS_STOPPED); > > +

Re: [PATCH v4] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-05 Thread Steven Price
On 04/11/2020 17:07, Boris Brezillon wrote: We've fixed many races in panfrost_job_timedout() but some remain. Instead of trying to fix it again, let's simplify the logic and move the reset bits to a separate work scheduled when one of the queue reports a timeout. v4: - Rework the logic to preve

Re: [PATCH v4] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-04 Thread Boris Brezillon
+amdgpu maintainers On Wed, 4 Nov 2020 18:07:29 +0100 Boris Brezillon wrote: > We've fixed many races in panfrost_job_timedout() but some remain. > Instead of trying to fix it again, let's simplify the logic and move > the reset bits to a separate work scheduled when one of the queue > reports