Re: [PATCH v3 3/3] drm/bridge: ti-sn65dsi86: Support hotplug detection

2022-03-11 Thread Doug Anderson
Hi, On Thu, Mar 10, 2022 at 9:47 PM Kieran Bingham wrote: > > > > +static void ti_sn_bridge_hpd_disable(struct drm_bridge *bridge) > > > +{ > > > + struct ti_sn65dsi86 *pdata = bridge_to_ti_sn65dsi86(bridge); > > > + > > > + regmap_write(pdata->regmap, SN_IRQ_HPD_REG, 0); > > > +

Re: [PATCH v3 3/3] drm/bridge: ti-sn65dsi86: Support hotplug detection

2022-03-10 Thread Kieran Bingham
Hi Doug, Quoting Doug Anderson (2022-03-10 23:10:12) > Hi, > > On Thu, Mar 10, 2022 at 7:22 AM Kieran Bingham > wrote: > > > > @@ -1135,6 +1161,36 @@ static void ti_sn_bridge_atomic_post_disable(struct > > drm_bridge *bridge, > > pm_runtime_put_sync(pdata->dev); > > } > > > > +static e

Re: [PATCH v3 3/3] drm/bridge: ti-sn65dsi86: Support hotplug detection

2022-03-10 Thread Doug Anderson
Hi, On Thu, Mar 10, 2022 at 7:22 AM Kieran Bingham wrote: > > @@ -1135,6 +1161,36 @@ static void ti_sn_bridge_atomic_post_disable(struct > drm_bridge *bridge, > pm_runtime_put_sync(pdata->dev); > } > > +static enum drm_connector_status ti_sn_bridge_detect(struct drm_bridge > *bridge) >

Re: [PATCH v3 3/3] drm/bridge: ti-sn65dsi86: Support hotplug detection

2022-03-10 Thread Kieran Bingham
Hi Laurent Quoting Laurent Pinchart (2022-03-10 16:42:48) > Hi Kieran, > > Thank you for the patch. > > On Thu, Mar 10, 2022 at 03:22:27PM +, Kieran Bingham wrote: > > When the SN65DSI86 is used in DisplayPort mode, its output is likely > > routed to a DisplayPort connector, which can benefi

Re: [PATCH v3 3/3] drm/bridge: ti-sn65dsi86: Support hotplug detection

2022-03-10 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thu, Mar 10, 2022 at 03:22:27PM +, Kieran Bingham wrote: > When the SN65DSI86 is used in DisplayPort mode, its output is likely > routed to a DisplayPort connector, which can benefit from hotplug > detection. Support it in such cases, with polling mode o

Re: [PATCH v3 3/3] drm/bridge: ti-sn65dsi86: Support hotplug detection

2022-03-10 Thread Kieran Bingham
Quoting Kieran Bingham (2022-03-10 15:22:27) > When the SN65DSI86 is used in DisplayPort mode, its output is likely > routed to a DisplayPort connector, which can benefit from hotplug > detection. Support it in such cases, with polling mode only for now. > > The implementation is limited to the br