On 18/12/2019 03:45, Laurent Pinchart wrote:
+ dev_info(&pdev->dev,
+"Found %s display connector '%s' %s DDC bus and %s HPD GPIO (ops
0x%x)\n",
+drm_get_connector_type_name(conn->bridge.type),
+conn->label ? conn->label : "",
+
Hi Sam,
Thank you for the review.
On Sun, Dec 15, 2019 at 01:03:31PM +0100, Sam Ravnborg wrote:
> Hi Laurent.
>
> One nit below.
>
> > +
> > +struct display_connector {
> > + struct drm_bridge bridge;
> > +
> > + const char *label;
>
> label is defined here.
>
> > + st
Hi Tomi,
On Mon, Dec 16, 2019 at 03:11:23PM +0200, Tomi Valkeinen wrote:
> On 11/12/2019 00:57, Laurent Pinchart wrote:
> > Display connectors are modelled in DT as a device node, but have so far
> > been handled manually in several bridge drivers. This resulted in
> > duplicate code in several br
On 11/12/2019 00:57, Laurent Pinchart wrote:
Display connectors are modelled in DT as a device node, but have so far
been handled manually in several bridge drivers. This resulted in
duplicate code in several bridge drivers, with slightly different (and
thus confusing) logics.
In order to fix th
On Wed, 11 Dec 2019 00:57:11 +0200
Laurent Pinchart wrote:
> Display connectors are modelled in DT as a device node, but have so far
> been handled manually in several bridge drivers. This resulted in
> duplicate code in several bridge drivers, with slightly different (and
> thus confusing) logic
Hi Laurent.
One nit below.
> +
> +struct display_connector {
> + struct drm_bridge bridge;
> +
> + const char *label;
label is defined here.
> + struct gpio_desc*hpd_gpio;
> + int hpd_irq;
> +};
> +
...
> +
> + /* Get the optiona
