Re: [PATCH v3 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-22 Thread Helge Deller
On 12/22/24 21:50, Arnd Bergmann wrote: On Sun, Dec 22, 2024, at 21:15, Helge Deller wrote: On 12/22/24 17:09, Thomas Zimmermann wrote: +    depends on BACKLIGHT_CLASS_DEVICE=y || BACKLIGHT_CLASS_DEVICE=FB_NVIDIA Seems wrong. BACKLIGHT_CLASS_DEVICE is of type tristate. There are more of tho

Re: [PATCH v3 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-22 Thread Arnd Bergmann
On Sun, Dec 22, 2024, at 21:15, Helge Deller wrote: > On 12/22/24 17:09, Thomas Zimmermann wrote: +    depends on BACKLIGHT_CLASS_DEVICE=y || BACKLIGHT_CLASS_DEVICE=FB_NVIDIA >>> >>> Seems wrong. BACKLIGHT_CLASS_DEVICE is of type tristate. >>> There are more of those, please check. >> >

Re: [PATCH v3 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-22 Thread Helge Deller
On 12/22/24 17:09, Thomas Zimmermann wrote: Hi Am 22.12.24 um 07:31 schrieb Helge Deller: On 12/16/24 08:42, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev driv

Re: [PATCH v3 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-22 Thread Thomas Zimmermann
Hi Am 22.12.24 um 07:31 schrieb Helge Deller: On 12/16/24 08:42, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let

Re: [PATCH v3 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-21 Thread Helge Deller
On 12/16/24 08:42, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warnings about