Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-26 Thread Ryan Walklin
On Wed, 26 Jun 2024, at 9:16 PM, Neil Armstrong wrote: > Well anbernic is not the wl-355608-a8 panel manufaturer, so as Maxime > is suggesting to use the > name of the device where the panel is found like > anbernic,rg353v-panel-v2 as submitted > in > https://lore.kernel.org/all/20230426143213.4

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-26 Thread Neil Armstrong
On 26/06/2024 11:10, Ryan Walklin wrote: Hi Maxime, On Wed, 26 Jun 2024, at 8:56 PM, Maxime Ripard wrote: We're getting fairly late into the release cycle and I'd like to get it fixed before the release. Can you send a patch to address it please? Sure, happy to. So to confirm add 'anbernic'

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-26 Thread Ryan Walklin
Hi Maxime, On Wed, 26 Jun 2024, at 8:56 PM, Maxime Ripard wrote: > We're getting fairly late into the release cycle and I'd like to get it > fixed before the release. Can you send a patch to address it please? Sure, happy to. So to confirm add 'anbernic' to the vendor binding list and 'anbernic

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-26 Thread Maxime Ripard
On Tue, Jun 18, 2024 at 02:05:50PM GMT, Neil Armstrong wrote: > On 18/06/2024 13:13, Conor Dooley wrote: > > On Tue, Jun 18, 2024 at 11:04:09AM +0200, Maxime Ripard wrote: > > > Hi Conor, > > > > > > Sorry, I missed the news of you becoming a DT maintainer, so most of my > > > previous points are

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-18 Thread Neil Armstrong
On 18/06/2024 13:13, Conor Dooley wrote: On Tue, Jun 18, 2024 at 11:04:09AM +0200, Maxime Ripard wrote: Hi Conor, Sorry, I missed the news of you becoming a DT maintainer, so most of my previous points are obviously bogus. And congrats :) I've been doing it for over a year, so news travels to

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-18 Thread Conor Dooley
On Tue, Jun 18, 2024 at 11:04:09AM +0200, Maxime Ripard wrote: > Hi Conor, > > Sorry, I missed the news of you becoming a DT maintainer, so most of my > previous points are obviously bogus. And congrats :) I've been doing it for over a year, so news travels to some corners slowly I guess. I'm not

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-18 Thread Maxime Ripard
Hi Conor, Sorry, I missed the news of you becoming a DT maintainer, so most of my previous points are obviously bogus. And congrats :) On Thu, Jun 06, 2024 at 12:51:33PM GMT, Conor Dooley wrote: > On Thu, Jun 06, 2024 at 01:23:03PM +0200, Maxime Ripard wrote: > > On Thu, Jun 06, 2024 at 11:37:31A

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Neil Armstrong
On 06/06/2024 13:23, Maxime Ripard wrote: On Thu, Jun 06, 2024 at 11:37:31AM GMT, Neil Armstrong wrote: On 06/06/2024 11:32, Maxime Ripard wrote: On Fri, May 31, 2024 at 09:12:14AM GMT, Ryan Walklin wrote: The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display used in a number of handheld gam

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Conor Dooley
On Thu, Jun 06, 2024 at 01:23:03PM +0200, Maxime Ripard wrote: > On Thu, Jun 06, 2024 at 11:37:31AM GMT, Neil Armstrong wrote: > > On 06/06/2024 11:32, Maxime Ripard wrote: > > > On Fri, May 31, 2024 at 09:12:14AM GMT, Ryan Walklin wrote: > > > > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD disp

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Maxime Ripard
On Thu, Jun 06, 2024 at 09:48:54PM GMT, Ryan Walklin wrote: > On Thu, 6 Jun 2024, at 9:32 PM, Maxime Ripard wrote: > Hi Maxime, thanks for reviewing. > > > Where has this consensus been found? > > As Neil notes Conor suggested it [1], and we did consider Hironori's > suggestion [2] of using anber

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Maxime Ripard
On Thu, Jun 06, 2024 at 11:37:31AM GMT, Neil Armstrong wrote: > On 06/06/2024 11:32, Maxime Ripard wrote: > > On Fri, May 31, 2024 at 09:12:14AM GMT, Ryan Walklin wrote: > > > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display used in a > > > number of handheld gaming devices made by Anbernic.

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Ryan Walklin
On Thu, 6 Jun 2024, at 9:32 PM, Maxime Ripard wrote: Hi Maxime, thanks for reviewing. > Where has this consensus been found? As Neil notes Conor suggested it [1], and we did consider Hironori's suggestion [2] of using anbernic as the vendor prefix, although my (not strong) feeling at the time w

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Neil Armstrong
On 06/06/2024 11:32, Maxime Ripard wrote: On Fri, May 31, 2024 at 09:12:14AM GMT, Ryan Walklin wrote: The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display used in a number of handheld gaming devices made by Anbernic. By consensus a vendor prefix is not provided as the panel OEM is unknown.

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel

2024-06-06 Thread Maxime Ripard
On Fri, May 31, 2024 at 09:12:14AM GMT, Ryan Walklin wrote: > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display used in a > number of handheld gaming devices made by Anbernic. By consensus a > vendor prefix is not provided as the panel OEM is unknown. Where has this consensus been found? I