Re: [PATCH v3 08/14] drm: rcar-du: Add support for CMM

2019-09-05 Thread Laurent Pinchart
Hi Jacopo, On Thu, Sep 05, 2019 at 03:14:53PM +0200, Jacopo Mondi wrote: > On Thu, Sep 05, 2019 at 02:17:12PM +0300, Laurent Pinchart wrote: > > Hi Jacopo, > > > >> +/** > >> + * rcar_cmm_enable() - enable the CMM unit > >> + * > >> + * @pdev: The platform device associated with th

Re: [PATCH v3 08/14] drm: rcar-du: Add support for CMM

2019-09-05 Thread Jacopo Mondi
Hi Laurent, On Thu, Sep 05, 2019 at 02:17:12PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > > +/** > > + * rcar_cmm_enable() - enable the CMM unit > > + * > > + * @pdev: The platform device associated with the CMM instance > > + * > > + * Enable the CMM unit by ena

Re: [PATCH v3 08/14] drm: rcar-du: Add support for CMM

2019-09-05 Thread Laurent Pinchart
Hi Jacopo, On Thu, Sep 05, 2019 at 11:57:57AM +0200, Jacopo Mondi wrote: > On Tue, Aug 27, 2019 at 07:34:23PM +0300, Laurent Pinchart wrote: > > On Tue, Aug 27, 2019 at 04:56:19PM +0200, Jacopo Mondi wrote: > >> On Tue, Aug 27, 2019 at 03:24:22AM +0300, Laurent Pinchart wrote: > >>> On Sun, Aug 25

Re: [PATCH v3 08/14] drm: rcar-du: Add support for CMM

2019-09-05 Thread Jacopo Mondi
Hi Laurent, On Tue, Aug 27, 2019 at 07:34:23PM +0300, Laurent Pinchart wrote: > Hi Laurent, > > On Tue, Aug 27, 2019 at 04:56:19PM +0200, Jacopo Mondi wrote: > > On Tue, Aug 27, 2019 at 03:24:22AM +0300, Laurent Pinchart wrote: > > > On Sun, Aug 25, 2019 at 03:51:48PM +0200, Jacopo Mondi wrote: >

Re: [PATCH v3 08/14] drm: rcar-du: Add support for CMM

2019-08-27 Thread Laurent Pinchart
Hi Laurent, On Tue, Aug 27, 2019 at 04:56:19PM +0200, Jacopo Mondi wrote: > On Tue, Aug 27, 2019 at 03:24:22AM +0300, Laurent Pinchart wrote: > > On Sun, Aug 25, 2019 at 03:51:48PM +0200, Jacopo Mondi wrote: > > > Add a driver for the R-Car Display Unit Color Correction Module. > > > > > > In most

Re: [PATCH v3 08/14] drm: rcar-du: Add support for CMM

2019-08-27 Thread Jacopo Mondi
On Tue, Aug 27, 2019 at 04:56:19PM +0200, Jacopo Mondi wrote: > Hi Laurent, > > On Tue, Aug 27, 2019 at 03:24:22AM +0300, Laurent Pinchart wrote: > > Hi Jacopo, > > > > Thank you for the patch. > > > > On Sun, Aug 25, 2019 at 03:51:48PM +0200, Jacopo Mondi wrote: > > > Add a driver for the R-Car Di

Re: [PATCH v3 08/14] drm: rcar-du: Add support for CMM

2019-08-27 Thread Jacopo Mondi
Hi Laurent, On Tue, Aug 27, 2019 at 03:24:22AM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Sun, Aug 25, 2019 at 03:51:48PM +0200, Jacopo Mondi wrote: > > Add a driver for the R-Car Display Unit Color Correction Module. > > > > In most of Gen3 SoCs, each DU outpu

Re: [PATCH v3 08/14] drm: rcar-du: Add support for CMM

2019-08-26 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Sun, Aug 25, 2019 at 03:51:48PM +0200, Jacopo Mondi wrote: > Add a driver for the R-Car Display Unit Color Correction Module. > > In most of Gen3 SoCs, each DU output channel is provided with a CMM unit > to perform image enhancement and color correction. >

Re: [PATCH v3 08/14] drm: rcar-du: Add support for CMM

2019-08-26 Thread Jacopo Mondi
Hi Geert, On Mon, Aug 26, 2019 at 09:31:02AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Sun, Aug 25, 2019 at 3:51 PM Jacopo Mondi > wrote: > > Add a driver for the R-Car Display Unit Color Correction Module. > > In most of Gen3 SoCs, each DU output channel is provided with a CMM unit >

Re: [PATCH v3 08/14] drm: rcar-du: Add support for CMM

2019-08-26 Thread Geert Uytterhoeven
Hi Jacopo, On Sun, Aug 25, 2019 at 3:51 PM Jacopo Mondi wrote: > Add a driver for the R-Car Display Unit Color Correction Module. > In most of Gen3 SoCs, each DU output channel is provided with a CMM unit > to perform image enhancement and color correction. > > Add support for CMM through a drive