On Tuesday, July 30th, 2024 at 12:43 PM, Andy Yan
wrote:
> Hi Piotr,
Hi Andy
> On 7/30/24 05:20, Piotr Zalewski wrote:
>
> >
> > On Monday, July 29th, 2024 at 4:35 AM, Andy Yan andy@rock-chips.com
> > wrote:
> >
> > > > > > +
> > > > > > +static void vop2_crtc_gamma_set(struct vop2 *vo
Hi Piotr,
On 7/30/24 05:20, Piotr Zalewski wrote:
Hi Andy
On Monday, July 29th, 2024 at 4:35 AM, Andy Yan wrote:
+
+static void vop2_crtc_gamma_set(struct vop2 *vop2, struct drm_crtc *crtc,
+ struct drm_crtc_state *old_state)
+{
+ struct drm_crtc_state *state = crtc->state;
+ struct vop2_vid
Hi Andy
On Monday, July 29th, 2024 at 4:35 AM, Andy Yan wrote:
> > > > +
> > > > +static void vop2_crtc_gamma_set(struct vop2 *vop2, struct drm_crtc
> > > > *crtc,
> > > > + struct drm_crtc_state *old_state)
> > > > +{
> > > > + struct drm_crtc_state *state = crtc->state;
> > > > + struct vop2_
On Friday, July 26th, 2024 at 10:55 AM, Andy Yan
wrote:
> Hi Piotr
Hi Andy!
> Thanks for your work.
>
> On 7/25/24 06:05, Piotr Zalewski wrote:
>
> > Add support for gamma LUT in VOP2 driver. The implementation is based on
> > the one found in VOP driver and modified to be compatible with
On Friday, July 26th, 2024 at 1:31 PM, Daniel Stone
wrote:
> Hi Piotr,
Hi Daniel, sorry for delayed response.
>
> > static void vop2_dither_setup(struct drm_crtc *crtc, u32 *dsp_ctrl)
> > @@ -2152,6 +2127,9 @@ static void vop2_crtc_atomic_enable(struct drm_crtc
> > *crtc,
> >
> > vop2_post_co
Hi Piotr,
On 7/27/24 03:49, Piotr Zalewski wrote:
On Friday, July 26th, 2024 at 10:55 AM, Andy Yan
wrote:
Hi Piotr
Hi Andy!
Thanks for your work.
On 7/25/24 06:05, Piotr Zalewski wrote:
Add support for gamma LUT in VOP2 driver. The implementation is based on
the one found in VOP driv
Hi Piotr,
On Thu, 25 Jul 2024 at 20:06, Piotr Zalewski wrote:
> I based my patch on how gamma LUT is handled in VOP. There, in atomic
> enable, gamma LUT write takes places at the end too, after the mutex was
> already first-time unlocked. I understand the concept of DRM atomic state
> updates an
Hi Piotr,
Thanks for your work.
On 7/25/24 06:05, Piotr Zalewski wrote:
Add support for gamma LUT in VOP2 driver. The implementation is based on
the one found in VOP driver and modified to be compatible with VOP2. Blue
and red channels in gamma LUT register write were swapped with respect to
On Thursday, July 25th, 2024 at 12:28 PM, Daniel Stone
wrote:
> Hi Piotr,
Hi, Daniel!
Thank you for the review.
>
> In the atomic_enable callback, we are already holding the VOP lock,
> and waiting to set cfg_done etc - we then do it all over again here.
> This should all be atomic, so th
Hi Piotr,
On Wed, 24 Jul 2024 at 23:06, Piotr Zalewski wrote:
> Add support for gamma LUT in VOP2 driver. The implementation is based on
> the one found in VOP driver and modified to be compatible with VOP2. Blue
> and red channels in gamma LUT register write were swapped with respect to
> how ga
10 matches
Mail list logo
