Re: [PATCH v3] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-03 Thread Boris Brezillon
On Tue, 3 Nov 2020 12:08:47 +0100 Daniel Vetter wrote: > On Tue, Nov 03, 2020 at 12:03:26PM +0100, Boris Brezillon wrote: > > On Tue, 3 Nov 2020 11:25:40 +0100 > > Daniel Vetter wrote: > > > > > On Tue, Nov 03, 2020 at 09:13:47AM +0100, Boris Brezillon wrote: > > > > We've fixed many races

Re: [PATCH v3] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-03 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 12:03:26PM +0100, Boris Brezillon wrote: > On Tue, 3 Nov 2020 11:25:40 +0100 > Daniel Vetter wrote: > > > On Tue, Nov 03, 2020 at 09:13:47AM +0100, Boris Brezillon wrote: > > > We've fixed many races in panfrost_job_timedout() but some remain. > > > Instead of trying to fi

Re: [PATCH v3] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-03 Thread Boris Brezillon
On Tue, 3 Nov 2020 11:25:40 +0100 Daniel Vetter wrote: > On Tue, Nov 03, 2020 at 09:13:47AM +0100, Boris Brezillon wrote: > > We've fixed many races in panfrost_job_timedout() but some remain. > > Instead of trying to fix it again, let's simplify the logic and move > > the reset bits to a separat

Re: [PATCH v3] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-03 Thread Daniel Vetter
On Tue, Nov 03, 2020 at 09:13:47AM +0100, Boris Brezillon wrote: > We've fixed many races in panfrost_job_timedout() but some remain. > Instead of trying to fix it again, let's simplify the logic and move > the reset bits to a separate work scheduled when one of the queue > reports a timeout. > >