Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-04-04 Thread Laurent Pinchart
On Mon, Mar 24, 2025 at 10:17:05AM -0700, Doug Anderson wrote: > On Mon, Mar 24, 2025 at 9:40 AM Laurent Pinchart wrote: > > On Tue, Mar 18, 2025 at 10:00:31PM +0100, Wolfram Sang wrote: > > > Hi Laurent, > > > > > > > > Read out and check the ID registers, so we can bail out if I2C > > > > > commu

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-24 Thread Doug Anderson
Hi, On Mon, Mar 24, 2025 at 10:31 AM Laurent Pinchart wrote: > > On Mon, Mar 24, 2025 at 10:17:05AM -0700, Doug Anderson wrote: > > On Mon, Mar 24, 2025 at 9:40 AM Laurent Pinchart wrote: > > > On Tue, Mar 18, 2025 at 10:00:31PM +0100, Wolfram Sang wrote: > > > > Hi Laurent, > > > > > > > > > > R

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-24 Thread Doug Anderson
Hi, On Mon, Mar 24, 2025 at 9:40 AM Laurent Pinchart wrote: > > On Tue, Mar 18, 2025 at 10:00:31PM +0100, Wolfram Sang wrote: > > Hi Laurent, > > > > > > Read out and check the ID registers, so we can bail out if I2C > > > > communication does not work or if the device is unknown. > > > > > > Wha

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-24 Thread Laurent Pinchart
On Tue, Mar 18, 2025 at 10:00:31PM +0100, Wolfram Sang wrote: > Hi Laurent, > > > > Read out and check the ID registers, so we can bail out if I2C > > > communication does not work or if the device is unknown. > > > > What's the advantage of that, what are you trying to guard against ? > > That

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-24 Thread Doug Anderson
Hi, On Tue, Mar 18, 2025 at 10:56 AM Doug Anderson wrote: > > Hi, > > On Tue, Mar 18, 2025 at 8:56 AM Wolfram Sang > wrote: > > > > Read out and check the ID registers, so we can bail out if I2C > > communication does not work or if the device is unknown. Tested on a > > Renesas GrayHawk board (

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-18 Thread Wolfram Sang
Hi Laurent, > > Read out and check the ID registers, so we can bail out if I2C > > communication does not work or if the device is unknown. > > What's the advantage of that, what are you trying to guard against ? That a random chip at address 0x2c will be used. > > Tested on a > > Renesas GrayH

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-18 Thread Laurent Pinchart
Hi Wolfram, Thank you for the patch. On Tue, Mar 18, 2025 at 04:52:56PM +0100, Wolfram Sang wrote: > Read out and check the ID registers, so we can bail out if I2C > communication does not work or if the device is unknown. What's the advantage of that, what are you trying to guard against ? > T

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-18 Thread Doug Anderson
Hi, On Tue, Mar 18, 2025 at 8:56 AM Wolfram Sang wrote: > > Read out and check the ID registers, so we can bail out if I2C > communication does not work or if the device is unknown. Tested on a > Renesas GrayHawk board (R-Car V4M) by using a wrong I2C address and by > not enabling RuntimePM for t

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-18 Thread Wolfram Sang
On Tue, Mar 18, 2025 at 04:52:56PM +0100, Wolfram Sang wrote: > Read out and check the ID registers, so we can bail out if I2C > communication does not work or if the device is unknown. Tested on a > Renesas GrayHawk board (R-Car V4M) by using a wrong I2C address and by > not enabling RuntimePM for