Re: [PATCH v2 4/8] rust: drm: add device abstraction

2025-04-17 Thread Danilo Krummrich
On Thu, Apr 17, 2025 at 02:53:33PM -0400, Lyude Paul wrote: > On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > > +    /// Not intended to be called externally, except via > > declare_drm_ioctls!() > > +    /// > > +    /// # Safety > > +    /// > > +    /// Callers must ensure that `pt

Re: [PATCH v2 4/8] rust: drm: add device abstraction

2025-04-17 Thread Lyude Paul
On Fri, 2025-04-11 at 01:55 +0200, Danilo Krummrich wrote: > +    /// Not intended to be called externally, except via > declare_drm_ioctls!() > +    /// > +    /// # Safety > +    /// > +    /// Callers must ensure that `ptr` is valid, non-null, and has a > non-zero reference count, > +    /// i

Re: [PATCH v2 4/8] rust: drm: add device abstraction

2025-04-14 Thread Alyssa Rosenzweig
> +/// # Safety > +/// > +/// `ptr` must be a valid poiner to a `struct device` embedded in `Self`. pointer With that fixed, Reviewed-by: Alyssa Rosenzweig