Re: [PATCH v2 3/4] drm/bridge: dw-hdmi: add cec driver

2017-08-02 Thread Russell King - ARM Linux
On Wed, Aug 02, 2017 at 05:22:54PM +0300, Laurent Pinchart wrote: > Then it should be even simpler. Instead of creating a separate platform > device > for the DW HDMI CEC, we can just call the DW HDMI CEC driver init/cleanup > functions directly when the IP core implements CEC. When it doesn't,

Re: [PATCH v2 3/4] drm/bridge: dw-hdmi: add cec driver

2017-08-02 Thread Russell King - ARM Linux
On Wed, Aug 02, 2017 at 04:14:34PM +0300, Laurent Pinchart wrote: > Hi Hans, > > On Wednesday 02 Aug 2017 08:47:23 Hans Verkuil wrote: > > On 08/02/2017 12:32 AM, Laurent Pinchart wrote: > > >> + > > >> +cec_register_cec_notifier(cec->adap, cec->notify); > > >> + > > >> +return 0;

Re: [PATCH v2 3/4] drm/bridge: dw-hdmi: add cec driver

2017-08-02 Thread Laurent Pinchart
Hi Hans, On Wednesday 02 Aug 2017 15:34:33 Hans Verkuil wrote: > On 08/02/17 15:27, Russell King - ARM Linux wrote: > > On Wed, Aug 02, 2017 at 04:14:34PM +0300, Laurent Pinchart wrote: > >> On Wednesday 02 Aug 2017 08:47:23 Hans Verkuil wrote: > >>> On 08/02/2017 12:32 AM, Laurent Pinchart wrote:

Re: [PATCH v2 3/4] drm/bridge: dw-hdmi: add cec driver

2017-08-02 Thread Neil Armstrong
On 08/02/2017 03:14 PM, Laurent Pinchart wrote: > Hi Hans, > > On Wednesday 02 Aug 2017 08:47:23 Hans Verkuil wrote: >> On 08/02/2017 12:32 AM, Laurent Pinchart wrote: + + cec_register_cec_notifier(cec->adap, cec->notify); + + return 0; +} + +static int dw_hdmi

Re: [PATCH v2 3/4] drm/bridge: dw-hdmi: add cec driver

2017-08-02 Thread Hans Verkuil
On 08/02/17 15:27, Russell King - ARM Linux wrote: > On Wed, Aug 02, 2017 at 04:14:34PM +0300, Laurent Pinchart wrote: >> Hi Hans, >> >> On Wednesday 02 Aug 2017 08:47:23 Hans Verkuil wrote: >>> On 08/02/2017 12:32 AM, Laurent Pinchart wrote: > + > + cec_register_cec_notifier(cec->adap, cec

Re: [PATCH v2 3/4] drm/bridge: dw-hdmi: add cec driver

2017-08-02 Thread Laurent Pinchart
Hi Hans, On Wednesday 02 Aug 2017 08:47:23 Hans Verkuil wrote: > On 08/02/2017 12:32 AM, Laurent Pinchart wrote: > >> + > >> + cec_register_cec_notifier(cec->adap, cec->notify); > >> + > >> + return 0; > >> +} > >> + > >> +static int dw_hdmi_cec_remove(struct platform_device *pdev) > >> +{ > >>

Re: [PATCH v2 3/4] drm/bridge: dw-hdmi: add cec driver

2017-08-01 Thread Hans Verkuil
On 08/02/2017 12:32 AM, Laurent Pinchart wrote: >> + >> +cec_register_cec_notifier(cec->adap, cec->notify); >> + >> +return 0; >> +} >> + >> +static int dw_hdmi_cec_remove(struct platform_device *pdev) >> +{ >> +struct dw_hdmi_cec *cec = platform_get_drvdata(pdev); >> + >> +cec_unre

Re: [PATCH v2 3/4] drm/bridge: dw-hdmi: add cec driver

2017-08-01 Thread Laurent Pinchart
Hi Russell, Thank you for the patch. On Monday 31 Jul 2017 15:29:51 Russell King wrote: > Add a CEC driver for the dw-hdmi hardware. > > Reviewed-by: Neil Armstrong > Signed-off-by: Russell King > --- > drivers/gpu/drm/bridge/synopsys/Kconfig | 9 + > drivers/gpu/drm/bridge/synopsys/M

Re: [PATCH v2 3/4] drm/bridge: dw-hdmi: add cec driver

2017-07-31 Thread Hans Verkuil
Hi Russell, Just two small comments below. After that's fixed you can add my: Acked-by: Hans Verkuil and: Tested-by: Hans Verkuil (on my SolidRun Cubox-i). On 07/31/2017 04:29 PM, Russell King wrote: > Add a CEC driver for the dw-hdmi hardware. > > Reviewed-by: Neil Armstrong > Signed-of