Re: [PATCH v2 2/3] drm/amdgpu: Allow dma_map_sg() coalescing

2018-04-30 Thread Robin Murphy
On 27/04/18 20:42, Sinan Kaya wrote: On 4/27/2018 11:54 AM, Robin Murphy wrote: ubuntu@ubuntu:~/amdgpu$_./vectoradd_hip.exe [  834.002206] create_process:620 [  837.413021] Unable to handle kernel NULL pointer dereference at virtual address 0018 £5 says that's sg_dma_len(NULL), which im

Re: [PATCH v2 2/3] drm/amdgpu: Allow dma_map_sg() coalescing

2018-04-29 Thread Sinan Kaya
On 4/27/2018 11:54 AM, Robin Murphy wrote: > >> ubuntu@ubuntu:~/amdgpu$_./vectoradd_hip.exe >> [  834.002206] create_process:620 >> [  837.413021] Unable to handle kernel NULL pointer dereference at virtual >> address 0018 > > £5 says that's sg_dma_len(NULL), which implies either that someth

Re: [PATCH v2 2/3] drm/amdgpu: Allow dma_map_sg() coalescing

2018-04-29 Thread Sinan Kaya
On 4/27/2018 11:54 AM, Robin Murphy wrote: >> I'm taking this back. I observed a crash with the HSA applications: > > FWIW, was this working before, or is this somewhere new that we're only > reaching now that pin_userpages can succeed? Yes, HSA application is a different test. Previous DRM libr

Re: [PATCH v2 2/3] drm/amdgpu: Allow dma_map_sg() coalescing

2018-04-27 Thread Robin Murphy
On 25/04/18 21:44, Sinan Kaya wrote: On 4/17/2018 5:13 PM, Sinan Kaya wrote: Tested-by: Sinan Kaya using QDF2400 and XFX Vega64 GPU for the first two patches. ./builddir/tests/amdgpu/amdgpu_test -s 1 Suite: Basic Tests Test: Userptr Test ...passed Userptr Test fails without this patch.

Re: [PATCH v2 2/3] drm/amdgpu: Allow dma_map_sg() coalescing

2018-04-26 Thread Sinan Kaya
On 4/17/2018 5:13 PM, Sinan Kaya wrote: > Tested-by: Sinan Kaya > > using QDF2400 and XFX Vega64 GPU for the first two patches. > > ./builddir/tests/amdgpu/amdgpu_test -s 1 > > Suite: Basic Tests > Test: Userptr Test ...passed > > Userptr Test fails without this patch. I'm taking this back

Re: [PATCH v2 2/3] drm/amdgpu: Allow dma_map_sg() coalescing

2018-04-18 Thread Sinan Kaya
On 4/17/2018 11:58 AM, Robin Murphy wrote: > The amdgpu driver doesn't appear to directly use the scatterlist mapped > by amdgpu_ttm_tt_pin_userptr(), it merely hands it off to > drm_prime_sg_to_page_addr_arrays() to generate the dma_address array > which it actually cares about. Now that the latte