Re: [PATCH v2 1/4] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-28 Thread Anusha Srivatsa
On Fri, Mar 28, 2025 at 4:34 AM Luca Ceresoli wrote: > Hello Anusha, > > Thanks for your continued effort. > > I have a few minor comments. Nothing big, but since Maxime requested a > change you'll have to send a new iteration, so find my comments below. > > On Thu, 27 Mar 2025 10:55:39 -0400 > A

Re: [PATCH v2 1/4] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-28 Thread Maxime Ripard
On Thu, Mar 27, 2025 at 11:33:15AM -0400, Anusha Srivatsa wrote: > On Thu, Mar 27, 2025 at 11:58 AM Maxime Ripard wrote: > > > On Thu, Mar 27, 2025 at 10:55:39AM -0400, Anusha Srivatsa wrote: > > > Introduce reference counted allocations for panels to avoid > > > use-after-free. The patch adds th

Re: [PATCH v2 1/4] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-28 Thread Luca Ceresoli
Hello Anusha, Thanks for your continued effort. I have a few minor comments. Nothing big, but since Maxime requested a change you'll have to send a new iteration, so find my comments below. On Thu, 27 Mar 2025 10:55:39 -0400 Anusha Srivatsa wrote: [...] > diff --git a/include/drm/drm_panel.h

Re: [PATCH v2 1/4] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-27 Thread Anusha Srivatsa
On Thu, Mar 27, 2025 at 11:58 AM Maxime Ripard wrote: > On Thu, Mar 27, 2025 at 10:55:39AM -0400, Anusha Srivatsa wrote: > > Introduce reference counted allocations for panels to avoid > > use-after-free. The patch adds the macro devm_drm_bridge_alloc() > > to allocate a new refcounted panel. Fol

Re: [PATCH v2 1/4] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-27 Thread Maxime Ripard
On Thu, Mar 27, 2025 at 10:55:39AM -0400, Anusha Srivatsa wrote: > Introduce reference counted allocations for panels to avoid > use-after-free. The patch adds the macro devm_drm_bridge_alloc() > to allocate a new refcounted panel. Followed the documentation for > drmm_encoder_alloc() and devm_drm_

Re: [PATCH v2 1/4] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-27 Thread Maxime Ripard
On Thu, 27 Mar 2025 10:55:39 -0400, Anusha Srivatsa wrote: > Introduce reference counted allocations for panels to avoid > use-after-free. The patch adds the macro devm_drm_bridge_alloc() > to allocate a new refcounted panel. Followed the documentation for > drmm_encoder_alloc() and devm_drm_dev_al