Re: [PATCH v2 1/3] dt-bindings: accel: add device tree for AMD PKI accelerator

2025-04-11 Thread Gupta, Nipun
On 10-04-2025 12:59, Krzysztof Kozlowski wrote: On Wed, Apr 09, 2025 at 11:00:31PM GMT, Nipun Gupta wrote: + interrupts: +maxItems: 1 + And the resets? I understand from previous email that there is a reset controller. It was not reset controller, those were register from clock cont

Re: [PATCH v2 1/3] dt-bindings: accel: add device tree for AMD PKI accelerator

2025-04-11 Thread Jeff Hugo
On 4/9/2025 11:30 AM, Nipun Gupta wrote: No cover letter? Add binding documentation for AMD PKI accelerator supported for AMD versal-net SoC. AMD PKI accelerator is a device on AMD versa-net SoC to execute public key asymmetric crypto operations like ECDSA, ECDH, RSA etc. with high performance

Re: [PATCH v2 1/3] dt-bindings: accel: add device tree for AMD PKI accelerator

2025-04-10 Thread Krzysztof Kozlowski
On Wed, Apr 09, 2025 at 11:00:31PM GMT, Nipun Gupta wrote: > Add binding documentation for AMD PKI accelerator supported for AMD > versal-net SoC. > A nit, subject: drop second/last, redundant "device tree for". The "dt-bindings" prefix is already stating that these are bindings. See also: https:/