Re: [PATCH v2 1/3] drm/mgag200: Only set VIDRST bits in CRTC modesetting

2024-07-10 Thread Thomas Zimmermann
Hi Am 10.07.24 um 16:25 schrieb Jocelyn Falempe: +    if (set_vidrst)   crtcext1 |= MGAREG_CRTCEXT1_VRSTEN |   MGAREG_CRTCEXT1_HRSTEN; +    else +    crtcext1 &= ~(MGAREG_CRTCEXT1_VRSTEN | MGAREG_CRTCEXT1_HRSTEN); The else case is useless, as crtcext1 has already

Re: [PATCH v2 1/3] drm/mgag200: Only set VIDRST bits in CRTC modesetting

2024-07-10 Thread Jocelyn Falempe
On 10/07/2024 10:42, Thomas Zimmermann wrote: The VRSTEN and HRSTEN bits control whether a CRTC synchronizes its display signal with an external source on the VIDRST pin. The G200WB and G200EW3 models synchronize with a BMC chip, but different external video encoders, such as the Matrox Maven,