Re: [PATCH v2 08/43] drm/fbdev: Add fbdev-shmem

2024-04-17 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Apr 16, 2024 at 2:07 PM Thomas Zimmermann wrote: > Am 16.04.24 um 13:25 schrieb Javier Martinez Canillas: > > Thomas Zimmermann writes: > > Do I understand correctly that info->fix.smem_start doesn't have to be set > > because that's only used for I/O memory? > > It's the star

Re: [PATCH v2 08/43] drm/fbdev: Add fbdev-shmem

2024-04-16 Thread Javier Martinez Canillas
Thomas Zimmermann writes: [...] >> >> I guess is OK because is_vmalloc_addr() is always true for this case ? > > It's not a vmalloc'ed address, but see patch 7. Fbdev-shmem uses a new > get_page callback in fb_defio. It provides the necessary page directly > to fb_defio. > Thanks! That was th

Re: [PATCH v2 08/43] drm/fbdev: Add fbdev-shmem

2024-04-16 Thread Thomas Zimmermann
Hi Javier Am 16.04.24 um 13:25 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Add an fbdev emulation for SHMEM-based memory managers. The code is similar to fbdev-generic, but does not require an addition shadow "additional" I think ? Yes. buffer for mmap().

Re: [PATCH v2 08/43] drm/fbdev: Add fbdev-shmem

2024-04-16 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Add an fbdev emulation for SHMEM-based memory managers. The code is > similar to fbdev-generic, but does not require an addition shadow "additional" I think ? > buffer for mmap(). Fbdev-shmem operates directly on the buffer object's > SHMEM pages. Fbde