Re: [PATCH v2 07/15] drm/mgag200: Set pitch in a separate helper function

2020-05-13 Thread Emil Velikov
On Tue, 12 May 2020 at 19:34, Thomas Zimmermann wrote: > > Hi Emil > > Am 12.05.20 um 12:27 schrieb Emil Velikov: > > Hi Thomas, > > > > On Tue, 12 May 2020 at 09:43, Thomas Zimmermann wrote: > > > >> @@ -1143,20 +1178,15 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, > >> WREG_CR

Re: [PATCH v2 07/15] drm/mgag200: Set pitch in a separate helper function

2020-05-12 Thread Thomas Zimmermann
Hi Emil Am 12.05.20 um 12:27 schrieb Emil Velikov: > Hi Thomas, > > On Tue, 12 May 2020 at 09:43, Thomas Zimmermann wrote: > >> @@ -1143,20 +1178,15 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, >> WREG_CRT(13, 0); >> WREG_CRT(14, 0); >> WREG_CRT(15, 0); >> -

Re: [PATCH v2 07/15] drm/mgag200: Set pitch in a separate helper function

2020-05-12 Thread Emil Velikov
Hi Thomas, On Tue, 12 May 2020 at 09:43, Thomas Zimmermann wrote: > @@ -1143,20 +1178,15 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, > WREG_CRT(13, 0); > WREG_CRT(14, 0); > WREG_CRT(15, 0); > - WREG_CRT(19, pitch & 0xFF); > - This write has disappeared wi