Re: [PATCH v2 01/22] drm: Add GEM backed framebuffer library

2017-08-11 Thread Daniel Vetter
On Thu, Aug 10, 2017 at 08:55:59PM +0200, Noralf Trønnes wrote: > > Den 09.08.2017 22.04, skrev Daniel Vetter: > > On Wed, Aug 09, 2017 at 12:11:04PM +0200, Noralf Trønnes wrote: > > > This library provides helpers for drivers that don't subclass > > > drm_framebuffer and are backed by drm_gem_obj

Re: [PATCH v2 01/22] drm: Add GEM backed framebuffer library

2017-08-10 Thread Noralf Trønnes
Den 09.08.2017 22.04, skrev Daniel Vetter: On Wed, Aug 09, 2017 at 12:11:04PM +0200, Noralf Trønnes wrote: This library provides helpers for drivers that don't subclass drm_framebuffer and are backed by drm_gem_object. The code is taken from drm_fb_cma_helper. Signed-off-by: Noralf Trønnes l

Re: [PATCH v2 01/22] drm: Add GEM backed framebuffer library

2017-08-10 Thread Joe Kniss
A few nits. On Wed, Aug 9, 2017 at 3:12 AM, wrote: > Send dri-devel mailing list submissions to > dri-devel@lists.freedesktop.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.freedesktop.org/mailman/listinfo/dri-devel > or, via email, send a messag

Re: [PATCH v2 01/22] drm: Add GEM backed framebuffer library

2017-08-09 Thread Daniel Vetter
On Wed, Aug 09, 2017 at 12:11:04PM +0200, Noralf Trønnes wrote: > This library provides helpers for drivers that don't subclass > drm_framebuffer and are backed by drm_gem_object. The code is > taken from drm_fb_cma_helper. > > Signed-off-by: Noralf Trønnes lgtm, a few nits below to polish the d