Re: [PATCH v2 01/17] drm/tests: helpers: Move the helper header to include/drm

2022-12-01 Thread Javier Martinez Canillas
Hello Maxime, On 12/1/22 11:27, Maxime Ripard wrote: [...] >> >> I wonder if now that this header was moved outside of the tests directory, >> if we should add stub functions in the header file that are just defined >> but do nothing if CONFIG_DRM_KUNIT_TEST isn't enabled. So that including >> i

Re: [PATCH v2 01/17] drm/tests: helpers: Move the helper header to include/drm

2022-12-01 Thread Maxime Ripard
Hi Javier, On Wed, Nov 30, 2022 at 09:00:03AM +0100, Javier Martinez Canillas wrote: > On 11/28/22 15:53, Maxime Ripard wrote: > > We'll need to use those helpers from drivers too, so let's move it to a > > more visible location. > > > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/

Re: [PATCH v2 01/17] drm/tests: helpers: Move the helper header to include/drm

2022-11-30 Thread Javier Martinez Canillas
On 11/28/22 15:53, Maxime Ripard wrote: > We'll need to use those helpers from drivers too, so let's move it to a > more visible location. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_client_modeset_test.c| 3 +-- > drivers/gpu/drm/tests/drm_kunit_helpers.c