Re: [PATCH v2] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-10-17 Thread Dave Airlie
Reviewed-by: Dave Airlie On Fri, 5 Oct 2018 at 22:52, Gerd Hoffmann wrote: > > The feature allows the guest request an EDID blob (describing monitor > capabilities) for a given scanout (aka virtual monitor connector). > > It brings a new command message, which has just a scanout field (beside > t

Re: [PATCH v2] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-10-05 Thread Gerd Hoffmann
Hi, > >>> +/* VIRTIO_GPU_RESP_OK_EDID */ > >>> +struct virtio_gpu_resp_edid { > >>> + struct virtio_gpu_ctrl_hdr hdr; > >>> + __le32 scanout; > >>> + __le32 size; > >>> + __u8 edid[1024]; > >> > >> Wouldn’t it be enough to stick to EDID 2.0 (256 bytes)? > >> > >> If not, maybe add comment to e

Re: [PATCH v2] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-10-05 Thread Christophe de Dinechin
> On 5 Oct 2018, at 16:41, Daniel Vetter wrote: > > On Fri, Oct 05, 2018 at 04:38:11PM +0200, Christophe de Dinechin wrote: >> >> >>> On 5 Oct 2018, at 14:51, Gerd Hoffmann wrote: >>> >>> The feature allows the guest request an EDID blob (describing monitor >>> capabilities) for a given sca

Re: [PATCH v2] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-10-05 Thread Daniel Vetter
On Fri, Oct 05, 2018 at 04:38:11PM +0200, Christophe de Dinechin wrote: > > > > On 5 Oct 2018, at 14:51, Gerd Hoffmann wrote: > > > > The feature allows the guest request an EDID blob (describing monitor > > capabilities) for a given scanout (aka virtual monitor connector). > > > > It brings a

Re: [PATCH v2] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-10-05 Thread Christophe de Dinechin
> On 5 Oct 2018, at 14:51, Gerd Hoffmann wrote: > > The feature allows the guest request an EDID blob (describing monitor > capabilities) for a given scanout (aka virtual monitor connector). > > It brings a new command message, which has just a scanout field (beside > the standard virtio-gpu h